linux-next: Fixes tag needs some work in the soundwire tree

linux-next: Fixes tag needs some work in the soundwire tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

Hi all,

In commit

  531f45f2bdf6 ("soundwire: export sdw_write/read_no_pm functions")

Fixes tag

  Fixes: 60ee9be25571 ('soundwire: bus: add PM/no-PM versions of

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the soundwire tree

[Vinod Koul]

On 07-02-21, 21:59, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   531f45f2bdf6 ("soundwire: export sdw_write/read_no_pm functions")
> 
> Fixes tag
> 
>   Fixes: 60ee9be25571 ('soundwire: bus: add PM/no-PM versions of
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
> 
> Please do not split Fixes tags over more than one line.

Thanks for spotting it, fixed it up now

-- 
~Vinod

linux-next: Fixes tag needs some work in the soundwire tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 545 bytes --]

Hi all,

In commit

  187c59cdcfe9 ("soundwire: stream: fix memory leak in stream config error path")

Fixes tag

  Fixes: bbe7379d8040a ("soundwire: Add support for SoundWire stream management")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Did you mean

Fixes: bbe7379d8040 ("soundwire: Add support for port management")

or

Fixes: 89e590535f32 ("soundwire: Add support for SoundWire stream management")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the soundwire tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 379 bytes --]

Hi all,

In commit

  f136f3279d85 ("soundwire: qcom: fix handling of qcom,ports-block-pack-mode")

Fixes tag

  Fixes: 5943e4fb14e3 ("soundwire: qcom: check of_property_read status")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: a5943e4fb14e ("soundwire: qcom: check of_property_read status")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the soundwire tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 544 bytes --]

Hi all,

On Wed, 12 May 2021 07:50:55 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> In commit
> 
>   f136f3279d85 ("soundwire: qcom: fix handling of qcom,ports-block-pack-mode")
> 
> Fixes tag
> 
>   Fixes: 5943e4fb14e3 ("soundwire: qcom: check of_property_read status")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: a5943e4fb14e ("soundwire: qcom: check of_property_read status")

Actually this is in the soundwire-fixes tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]