From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E24FC433E6 for ; Mon, 8 Feb 2021 13:12:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 533A364E7A for ; Mon, 8 Feb 2021 13:12:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230257AbhBHNL6 (ORCPT ); Mon, 8 Feb 2021 08:11:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:54382 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229993AbhBHNLt (ORCPT ); Mon, 8 Feb 2021 08:11:49 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3219764E85; Mon, 8 Feb 2021 13:11:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612789869; bh=DhCfAvO4/Izxym8gYZJsjsSzL8u4lIOArAufKfQ5KWg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=E41nSyaObGZmRvYnJMugLW6g9aKHgkpjh4OmKX5Tx0K/jv8gNoo2b3Zxh8Jv3mOyM 7uAsI3O7G8jlNfZ24kG1I5EqBjpm3B0TT334Xo0XvdH7nSbR/udPLFI8qlrNVB+xTJ Y0J2+aGxOrveBbiu5pWFuwcog8eEgNRfi2/Z7IO7Tr2KwwjOz3LkmrK76F2ANbiqQm HzdQiAyWmCKpjyK6tBLA2HnDjsa0rhucinKudTu/B1zhRKDIIQIMeiY0edVcpgiHrb /yZifOQa/AP3UKFeRoHGa3LFw2FzfyXimLX4c37V9+XCsijRy61IswXf8LK/CHmffv 443ZbYvgzYF+g== Date: Mon, 8 Feb 2021 14:11:02 +0100 From: Mauro Carvalho Chehab To: Jacopo Mondi Cc: Laurent Pinchart , Sakari Ailus , Linux Media Mailing List , Jacopo Mondi , Stephen Rothwell , linux-next@vger.kernel.org Subject: Re: [PATCH] media: i2c: fix max9271 build dependencies Message-ID: <20210208141102.3d5999dd@coco.lan> In-Reply-To: <20210208114142.skwc22xps5xiqdyo@uno.localdomain> References: <20210208113208.35449879@canb.auug.org.au> <20210208065315.1914616-1-mchehab+huawei@kernel.org> <20210208072701.GI32460@paasikivi.fi.intel.com> <20210208083616.3iulzo56mhn4ymmq@uno.localdomain> <20210208084147.GN32460@paasikivi.fi.intel.com> <20210208100822.76ca0c2e@coco.lan> <20210208092424.GP32460@paasikivi.fi.intel.com> <20210208110723.4859ddda@coco.lan> <20210208114142.skwc22xps5xiqdyo@uno.localdomain> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org Em Mon, 8 Feb 2021 12:41:42 +0100 Jacopo Mondi escreveu: > > > If you do, instead: > > > > > > if VIDEO_V4L2 && I2C > > > config VIDEO_MAX9271_SERIALIZER > > > tristate > > > > > > config VIDEO_RDACM20 > > > select VIDEO_MAX9271_SERIALIZER > > > ... > > > > > > config VIDEO_RDACM21 > > > select VIDEO_MAX9271_SERIALIZER > > > ... > > > endif > > > > > > Then you also won't need: > > > depends on VIDEO_MAX9271_SERIALIZER || !VIDEO_MAX9271_SERIALIZER > > > > > > As select should do the right thing in this case, ensuring that MAX9271 > > > will be builtin either if RDACM20 or RDACM21 is builtin. > > > > I also vote for usage of "select". > > > > I would prefer that too, I was concerned about possible un-met > dependencies, as Sakari pointed out, but the current situation is no > better, as the only Kconfig symbols where those can be listed are the > camera modules one. Works for me. I'll make a patch for it. Thanks, Mauro