From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E0FBC433DB for ; Mon, 8 Feb 2021 13:32:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0FDD764E45 for ; Mon, 8 Feb 2021 13:32:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230315AbhBHNcq (ORCPT ); Mon, 8 Feb 2021 08:32:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:58028 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230319AbhBHNcg (ORCPT ); Mon, 8 Feb 2021 08:32:36 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 458E864E0B; Mon, 8 Feb 2021 13:31:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612791115; bh=moZgQWUiCxr56AnhmScE672QhGV4pXoRCpdw0dKkQZw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KVZbH8BNe7wC6coT4hVqbxaFy00Gm5+Ou6XzaX6+bvVXrTkgICc4KwgzZCMr7kWXA xTxQ3WMC7/P/92tSUGJCoQuaQrVC5kilaN2HQ2zsWJRsmuFVbog43L2u9TL+K23oLe Baq3sc6MG9TjvaI+fbjk5d0KRf/hW4IaNscp2WQGkB5GGSwr8vcyzrSgqD36FXBVSe AsbJRPaoGzQ7NZ+UP8vSxvHB0Eq3NffHzzlIMpyYcPItttoKfAGelxnBZ+eMRQjT/v EJ0pl5OHK0/Kdr6wqydWbDwWjBUqurJY4k67fXwVoCCbpUimuVCPV2cpfO5Qwv0bsk NpYtVaeOhNcMg== Date: Mon, 8 Feb 2021 14:31:50 +0100 From: Mauro Carvalho Chehab To: Jacopo Mondi Cc: Laurent Pinchart , Sakari Ailus , Linux Media Mailing List , Jacopo Mondi , Stephen Rothwell , linux-next@vger.kernel.org Subject: Re: [PATCH] media: i2c: fix max9271 build dependencies Message-ID: <20210208143150.03974bca@coco.lan> In-Reply-To: <20210208141102.3d5999dd@coco.lan> References: <20210208113208.35449879@canb.auug.org.au> <20210208065315.1914616-1-mchehab+huawei@kernel.org> <20210208072701.GI32460@paasikivi.fi.intel.com> <20210208083616.3iulzo56mhn4ymmq@uno.localdomain> <20210208084147.GN32460@paasikivi.fi.intel.com> <20210208100822.76ca0c2e@coco.lan> <20210208092424.GP32460@paasikivi.fi.intel.com> <20210208110723.4859ddda@coco.lan> <20210208114142.skwc22xps5xiqdyo@uno.localdomain> <20210208141102.3d5999dd@coco.lan> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org Em Mon, 8 Feb 2021 14:11:02 +0100 Mauro Carvalho Chehab escreveu: > Em Mon, 8 Feb 2021 12:41:42 +0100 > Jacopo Mondi escreveu: > > > > > If you do, instead: > > > > > > > > if VIDEO_V4L2 && I2C > > > > config VIDEO_MAX9271_SERIALIZER > > > > tristate > > > > > > > > config VIDEO_RDACM20 > > > > select VIDEO_MAX9271_SERIALIZER > > > > ... > > > > > > > > config VIDEO_RDACM21 > > > > select VIDEO_MAX9271_SERIALIZER > > > > ... > > > > endif > > > > > > > > Then you also won't need: > > > > depends on VIDEO_MAX9271_SERIALIZER || !VIDEO_MAX9271_SERIALIZER > > > > > > > > As select should do the right thing in this case, ensuring that MAX9271 > > > > will be builtin either if RDACM20 or RDACM21 is builtin. > > > > > > I also vote for usage of "select". > > > > > > > I would prefer that too, I was concerned about possible un-met > > dependencies, as Sakari pointed out, but the current situation is no > > better, as the only Kconfig symbols where those can be listed are the > > camera modules one. > > Works for me. I'll make a patch for it. Hmm... after taking a deeper look at the rcma20 drivers, and on its Kconfig help text: config VIDEO_RDACM20 tristate "IMI RDACM20 camera support" select V4L2_FWNODE select VIDEO_V4L2_SUBDEV_API select MEDIA_CONTROLLER help This driver supports the IMI RDACM20 GMSL camera, used in ADAS systems. This camera should be used in conjunction with a GMSL deserialiser such as the MAX9286. I'm starting to suspect that there's something very wrong here... The help text mentions the MAX9286 driver, which is a complete driver, and not MAX9271, which seems to implement a set of PHY functions needed by those drivers, and which lacks a proper I2C binding code on it. The I2C binding code is, instead, inside RDACM20 and RDACM21: static int rdacm21_initialize(struct rdacm21_device *dev) { int ret; /* Verify communication with the MAX9271: ping to wakeup. */ dev->serializer.client->addr = MAX9271_DEFAULT_ADDR; i2c_smbus_read_byte(dev->serializer.client); usleep_range(3000, 5000); /* Enable reverse channel and disable the serial link. */ ret = max9271_set_serial_link(&dev->serializer, false); if (ret) return ret; /* Configure I2C bus at 105Kbps speed and configure GMSL. */ ret = max9271_configure_i2c(&dev->serializer, MAX9271_I2CSLVSH_469NS_234NS | MAX9271_I2CSLVTO_1024US | MAX9271_I2CMSTBT_105KBPS); /* Several other max9271-specific init code */ ret = ov490_initialize(dev); if (ret) return ret; And, at max9271 "driver", there's just a bunch of exported functions. This is all wrong. I'm seriously considering to move all those 3 drivers to staging, while they're not fixed to use a proper I2C binding mechanism. Thanks, Mauro