linux-next: build failure after merge of the gpio-brgl tree

linux-next: build failure after merge of the gpio-brgl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 668 bytes --]

Hi all,

After merging the gpio-brgl tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/gpio/gpio-pcf857x.c: In function 'pcf857x_probe':
drivers/gpio/gpio-pcf857x.c:335:41: error: expected ';' before 'if'
  335 |  gpio->status = gpio->read(gpio->client)
      |                                         ^
      |                                         ;
......
  338 |  if (client->irq) {
      |  ~~                                      

Caused by commit

  ab94f4c529bc ("gpio: pcf857x: Fix missing first interrupt")

I have used the gpio-brgl tree from next-20210217 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the gpio-brgl tree

[Bartosz Golaszewski]

On Sun, 25 Feb 2024 at 02:58, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Bartosz,
>
> On Fri, 23 Feb 2024 08:51:10 +0100 Bartosz Golaszewski <bartosz.golaszewski@linaro.org> wrote:
> >
> > On Fri, 23 Feb 2024 at 04:33, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > After merging the gpio-brgl tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > >
> > > x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_write64':
> > > gpio-mmio.c:(.text+0x1489427): undefined reference to `iowrite64'
> > > x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_read64':
> > > gpio-mmio.c:(.text+0x14894a0): undefined reference to `ioread64'
> > > x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_write64be':
> > > gpio-mmio.c:(.text+0x1489527): undefined reference to `iowrite64be'
> > > x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_read64be':
> > > gpio-mmio.c:(.text+0x14895a0): undefined reference to `ioread64be'
> > >
> > > Caused by commit
> > >
> > >   36e44186e0ba ("gpio: mmio: Support 64-bit BE access")
> >
> > I'm not seeing this issue with allmodconfig on x86_64, could you give
> > me some more information on the build environment?
>
> These builds are cross builds using Debian's cross compilers on a ppc64le host.
>
> $ x86_64-linux-gnu-gcc --version
> x86_64-linux-gnu-gcc (Debian 13.2.0-7) 13.2.0
> $ x86_64-linux-gnu-ld --version
> GNU ld (GNU Binutils for Debian) 2.41
>
> --
> Cheers,
> Stephen Rothwell

I dropped the offending commit from my for-next branch. Let's revisit
it after the upcoming merge window.

Bart

Re: linux-next: build failure after merge of the gpio-brgl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1361 bytes --]

Hi Bartosz,

On Fri, 23 Feb 2024 08:51:10 +0100 Bartosz Golaszewski <bartosz.golaszewski@linaro.org> wrote:
>
> On Fri, 23 Feb 2024 at 04:33, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the gpio-brgl tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_write64':
> > gpio-mmio.c:(.text+0x1489427): undefined reference to `iowrite64'
> > x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_read64':
> > gpio-mmio.c:(.text+0x14894a0): undefined reference to `ioread64'
> > x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_write64be':
> > gpio-mmio.c:(.text+0x1489527): undefined reference to `iowrite64be'
> > x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_read64be':
> > gpio-mmio.c:(.text+0x14895a0): undefined reference to `ioread64be'
> >
> > Caused by commit
> >
> >   36e44186e0ba ("gpio: mmio: Support 64-bit BE access")
> 
> I'm not seeing this issue with allmodconfig on x86_64, could you give
> me some more information on the build environment?

These builds are cross builds using Debian's cross compilers on a ppc64le host.

$ x86_64-linux-gnu-gcc --version
x86_64-linux-gnu-gcc (Debian 13.2.0-7) 13.2.0
$ x86_64-linux-gnu-ld --version
GNU ld (GNU Binutils for Debian) 2.41

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the gpio-brgl tree

[Andy Shevchenko]

On Fri, Feb 23, 2024 at 9:51 AM Bartosz Golaszewski
<bartosz.golaszewski@linaro.org> wrote:
> On Fri, 23 Feb 2024 at 04:33, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> > After merging the gpio-brgl tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_write64':
> > gpio-mmio.c:(.text+0x1489427): undefined reference to `iowrite64'
> > x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_read64':
> > gpio-mmio.c:(.text+0x14894a0): undefined reference to `ioread64'
> > x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_write64be':
> > gpio-mmio.c:(.text+0x1489527): undefined reference to `iowrite64be'
> > x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_read64be':
> > gpio-mmio.c:(.text+0x14895a0): undefined reference to `ioread64be'
> >
> > Caused by commit
> >
> >   36e44186e0ba ("gpio: mmio: Support 64-bit BE access")
> >
> > I have used the gpio-brgl from next-20240222 for today.

> I'm not seeing this issue with allmodconfig on x86_64, could you give
> me some more information on the build environment?
>
> Andy: Could it be that the ifdefs you added should depend on
> CONFIG_64BIT and not only on the BITS_PER_LONG value?

If so, it will be the old issue as I just used what is currently done
for LE 64-bit accessors in the same file.
I think the problem here is different, i.e. io*64*() are not available
on all (64-bit) architectures in comparison to readq()/writeq().
I'll look at this later today.


-- 
With Best Regards,
Andy Shevchenko

Re: linux-next: build failure after merge of the gpio-brgl tree

[Bartosz Golaszewski]

On Fri, 23 Feb 2024 at 04:33, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the gpio-brgl tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_write64':
> gpio-mmio.c:(.text+0x1489427): undefined reference to `iowrite64'
> x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_read64':
> gpio-mmio.c:(.text+0x14894a0): undefined reference to `ioread64'
> x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_write64be':
> gpio-mmio.c:(.text+0x1489527): undefined reference to `iowrite64be'
> x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_read64be':
> gpio-mmio.c:(.text+0x14895a0): undefined reference to `ioread64be'
>
> Caused by commit
>
>   36e44186e0ba ("gpio: mmio: Support 64-bit BE access")
>
> I have used the gpio-brgl from next-20240222 for today.
>
> --
> Cheers,
> Stephen Rothwell

Hi Stephen,

I'm not seeing this issue with allmodconfig on x86_64, could you give
me some more information on the build environment?

Andy: Could it be that the ifdefs you added should depend on
CONFIG_64BIT and not only on the BITS_PER_LONG value?

Bartosz

linux-next: build failure after merge of the gpio-brgl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 806 bytes --]

Hi all,

After merging the gpio-brgl tree, today's linux-next build (x86_64
allmodconfig) failed like this:

x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_write64':
gpio-mmio.c:(.text+0x1489427): undefined reference to `iowrite64'
x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_read64':
gpio-mmio.c:(.text+0x14894a0): undefined reference to `ioread64'
x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_write64be':
gpio-mmio.c:(.text+0x1489527): undefined reference to `iowrite64be'
x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_read64be':
gpio-mmio.c:(.text+0x14895a0): undefined reference to `ioread64be'

Caused by commit

  36e44186e0ba ("gpio: mmio: Support 64-bit BE access")

I have used the gpio-brgl from next-20240222 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the gpio-brgl tree

[Bartosz Golaszewski]

On Fri, 13 Oct 2023 at 06:14, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the gpio-brgl tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/hte/hte-tegra194.c: In function 'tegra_hte_line_xlate':
> drivers/hte/hte-tegra194.c:424:48: error: implicit declaration of function 'gpio_device_get_base'; did you mean 'gpio_device_get_desc'? [-Werror=implicit-function-declaration]
>   424 |                 line_id = desc->attr.line_id - gpio_device_get_base(gs->gdev);
>       |                                                ^~~~~~~~~~~~~~~~~~~~
>       |                                                gpio_device_get_desc
> drivers/hte/hte-tegra194.c: In function 'tegra_hte_match_from_linedata':
> drivers/hte/hte-tegra194.c:652:33: error: implicit declaration of function 'gpiod_to_device'; did you mean 'gpio_to_desc'? [-Werror=implicit-function-declaration]
>   652 |                                 gpiod_to_device(hdesc->attr.line_data);
>       |                                 ^~~~~~~~~~~~~~~
>       |                                 gpio_to_desc
> drivers/hte/hte-tegra194.c:652:33: error: initialization of 'struct gpio_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
> cc1: all warnings being treated as errors
>
> Caused by commit
>
>   ebee532ff34b ("hte: tegra194: don't access struct gpio_chip")
>
> (Exposed by commit
>
>   63137bee5a7a ("hte: allow building modules with COMPILE_TEST enabled")
>
> from the hte tree.)
>
> I have used the gpio-brgl tree from next-20231012 for today.
>
> --
> Cheers,
> Stephen Rothwell

Gah, we have a couple reworks going on at the same time and I messed
up the order of applying the patches. And the name of
gpiod_to_device() was changed to gpiod_to_gpio_device() and no longer
increases the reference count of the device.

Dipen, I backed out the HTE patch, I will fix it up and resend it
making sure it builds correctly with my gpio/for-next branch.

Bartosz

linux-next: build failure after merge of the gpio-brgl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1539 bytes --]

Hi all,

After merging the gpio-brgl tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/hte/hte-tegra194.c: In function 'tegra_hte_line_xlate':
drivers/hte/hte-tegra194.c:424:48: error: implicit declaration of function 'gpio_device_get_base'; did you mean 'gpio_device_get_desc'? [-Werror=implicit-function-declaration]
  424 |                 line_id = desc->attr.line_id - gpio_device_get_base(gs->gdev);
      |                                                ^~~~~~~~~~~~~~~~~~~~
      |                                                gpio_device_get_desc
drivers/hte/hte-tegra194.c: In function 'tegra_hte_match_from_linedata':
drivers/hte/hte-tegra194.c:652:33: error: implicit declaration of function 'gpiod_to_device'; did you mean 'gpio_to_desc'? [-Werror=implicit-function-declaration]
  652 |                                 gpiod_to_device(hdesc->attr.line_data);
      |                                 ^~~~~~~~~~~~~~~
      |                                 gpio_to_desc
drivers/hte/hte-tegra194.c:652:33: error: initialization of 'struct gpio_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
cc1: all warnings being treated as errors

Caused by commit

  ebee532ff34b ("hte: tegra194: don't access struct gpio_chip")

(Exposed by commit

  63137bee5a7a ("hte: allow building modules with COMPILE_TEST enabled")

from the hte tree.)

I have used the gpio-brgl tree from next-20231012 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the gpio-brgl tree

[Bartosz Golaszewski]

On Thu, 23 Mar 2023 at 02:47, William Breathitt Gray
<william.gray@linaro.org> wrote:
>
> On Thu, Mar 23, 2023 at 12:29:13PM +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the gpio-brgl tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > drivers/gpio/gpio-pci-idio-16.c:32:30: error: field 'state' has incomplete type
> >    32 |         struct idio_16_state state;
> >       |                              ^~~~~
> > drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_gpio_get_direction':
> > drivers/gpio/gpio-pci-idio-16.c:39:13: error: implicit declaration of function 'idio_16_get_direction'; did you mean 'idio_16_gpio_get_direction'? [-Werror=implicit-function-declaration]
> >    39 |         if (idio_16_get_direction(offset))
> >       |             ^~~~~~~~~~~~~~~~~~~~~
> >       |             idio_16_gpio_get_direction
> > drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_gpio_get':
> > drivers/gpio/gpio-pci-idio-16.c:62:16: error: implicit declaration of function 'idio_16_get'; did you mean 'idio_16_gpio_get'? [-Werror=implicit-function-declaration]
> >    62 |         return idio_16_get(idio16gpio->reg, &idio16gpio->state, offset);
> >       |                ^~~~~~~~~~~
> >       |                idio_16_gpio_get
> > drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_gpio_get_multiple':
> > drivers/gpio/gpio-pci-idio-16.c:70:9: error: implicit declaration of function 'idio_16_get_multiple'; did you mean 'idio_16_gpio_get_multiple'? [-Werror=implicit-function-declaration]
> >    70 |         idio_16_get_multiple(idio16gpio->reg, &idio16gpio->state, mask, bits);
> >       |         ^~~~~~~~~~~~~~~~~~~~
> >       |         idio_16_gpio_get_multiple
> > drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_gpio_set':
> > drivers/gpio/gpio-pci-idio-16.c:79:9: error: implicit declaration of function 'idio_16_set'; did you mean 'idio_16_gpio_set'? [-Werror=implicit-function-declaration]
> >    79 |         idio_16_set(idio16gpio->reg, &idio16gpio->state, offset, value);
> >       |         ^~~~~~~~~~~
> >       |         idio_16_gpio_set
> > drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_gpio_set_multiple':
> > drivers/gpio/gpio-pci-idio-16.c:87:9: error: implicit declaration of function 'idio_16_set_multiple'; did you mean 'idio_16_gpio_set_multiple'? [-Werror=implicit-function-declaration]
> >    87 |         idio_16_set_multiple(idio16gpio->reg, &idio16gpio->state, mask, bits);
> >       |         ^~~~~~~~~~~~~~~~~~~~
> >       |         idio_16_gpio_set_multiple
> > drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_irq_mask':
> > drivers/gpio/gpio-pci-idio-16.c:106:45: error: invalid use of undefined type 'struct idio_16'
> >   106 |                 iowrite8(0, &idio16gpio->reg->irq_ctl);
> >       |                                             ^~
> > drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_irq_unmask':
> > drivers/gpio/gpio-pci-idio-16.c:129:41: error: invalid use of undefined type 'struct idio_16'
> >   129 |                 ioread8(&idio16gpio->reg->irq_ctl);
> >       |                                         ^~
> > drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_irq_handler':
> > drivers/gpio/gpio-pci-idio-16.c:164:46: error: invalid use of undefined type 'struct idio_16'
> >   164 |         irq_status = ioread8(&idio16gpio->reg->irq_status);
> >       |                                              ^~
> > drivers/gpio/gpio-pci-idio-16.c:178:37: error: invalid use of undefined type 'struct idio_16'
> >   178 |         iowrite8(0, &idio16gpio->reg->in0_7);
> >       |                                     ^~
> > drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_irq_init_hw':
> > drivers/gpio/gpio-pci-idio-16.c:198:37: error: invalid use of undefined type 'struct idio_16'
> >   198 |         iowrite8(0, &idio16gpio->reg->irq_ctl);
> >       |                                     ^~
> > drivers/gpio/gpio-pci-idio-16.c:199:37: error: invalid use of undefined type 'struct idio_16'
> >   199 |         iowrite8(0, &idio16gpio->reg->in0_7);
> >       |                                     ^~
> > drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_probe':
> > drivers/gpio/gpio-pci-idio-16.c:232:37: error: invalid use of undefined type 'struct idio_16'
> >   232 |         iowrite8(0, &idio16gpio->reg->filter_ctl);
> >       |                                     ^~
> > drivers/gpio/gpio-pci-idio-16.c:248:9: error: implicit declaration of function 'idio_16_state_init'; did you mean 'file_ra_state_init'? [-Werror=implicit-function-declaration]
> >   248 |         idio_16_state_init(&idio16gpio->state);
> >       |         ^~~~~~~~~~~~~~~~~~
> >       |         file_ra_state_init
> > drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_gpio_get':
> > drivers/gpio/gpio-pci-idio-16.c:63:1: error: control reaches end of non-void function [-Werror=return-type]
> >    63 | }
> >       | ^
> >
> > Caused by commit
> >
> >   473b79057bbd ("gpio: idio-16: Remove unused legacy interface")
> >
> > I have used the gpio-brgl tree from next-20230322 for today.
> >
> > --
> > Cheers,
> > Stephen Rothwell
>
> Commit 473b79057bbd shouldn't be merged until all of the IDIO-16 legacy
> interface is first removed.
>
> Bart, would you revert all of the "Migrate IDIO-16 GPIO drivers to
> regmap API" patches [0]? That patchset needs to be revised anyway to
> prevent conflicts with the handle_mask_sync() API change [1]; I'll
> submit a v3 later this week that resolves the incompatibilies and
> rebase on the latest gpio/for-next.
>
> William Breathitt Gray
>
> [0] https://lore.kernel.org/all/cover.1677515341.git.william.gray@linaro.org/
> [1] https://lore.kernel.org/all/cover.1679323449.git.william.gray@linaro.org/

Done, thanks!

Bart

linux-next: build failure after merge of the gpio-brgl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 4788 bytes --]

Hi all,

After merging the gpio-brgl tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpio/gpio-pci-idio-16.c:32:30: error: field 'state' has incomplete type
   32 |         struct idio_16_state state;
      |                              ^~~~~
drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_gpio_get_direction':
drivers/gpio/gpio-pci-idio-16.c:39:13: error: implicit declaration of function 'idio_16_get_direction'; did you mean 'idio_16_gpio_get_direction'? [-Werror=implicit-function-declaration]
   39 |         if (idio_16_get_direction(offset))
      |             ^~~~~~~~~~~~~~~~~~~~~
      |             idio_16_gpio_get_direction
drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_gpio_get':
drivers/gpio/gpio-pci-idio-16.c:62:16: error: implicit declaration of function 'idio_16_get'; did you mean 'idio_16_gpio_get'? [-Werror=implicit-function-declaration]
   62 |         return idio_16_get(idio16gpio->reg, &idio16gpio->state, offset);
      |                ^~~~~~~~~~~
      |                idio_16_gpio_get
drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_gpio_get_multiple':
drivers/gpio/gpio-pci-idio-16.c:70:9: error: implicit declaration of function 'idio_16_get_multiple'; did you mean 'idio_16_gpio_get_multiple'? [-Werror=implicit-function-declaration]
   70 |         idio_16_get_multiple(idio16gpio->reg, &idio16gpio->state, mask, bits);
      |         ^~~~~~~~~~~~~~~~~~~~
      |         idio_16_gpio_get_multiple
drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_gpio_set':
drivers/gpio/gpio-pci-idio-16.c:79:9: error: implicit declaration of function 'idio_16_set'; did you mean 'idio_16_gpio_set'? [-Werror=implicit-function-declaration]
   79 |         idio_16_set(idio16gpio->reg, &idio16gpio->state, offset, value);
      |         ^~~~~~~~~~~
      |         idio_16_gpio_set
drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_gpio_set_multiple':
drivers/gpio/gpio-pci-idio-16.c:87:9: error: implicit declaration of function 'idio_16_set_multiple'; did you mean 'idio_16_gpio_set_multiple'? [-Werror=implicit-function-declaration]
   87 |         idio_16_set_multiple(idio16gpio->reg, &idio16gpio->state, mask, bits);
      |         ^~~~~~~~~~~~~~~~~~~~
      |         idio_16_gpio_set_multiple
drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_irq_mask':
drivers/gpio/gpio-pci-idio-16.c:106:45: error: invalid use of undefined type 'struct idio_16'
  106 |                 iowrite8(0, &idio16gpio->reg->irq_ctl);
      |                                             ^~
drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_irq_unmask':
drivers/gpio/gpio-pci-idio-16.c:129:41: error: invalid use of undefined type 'struct idio_16'
  129 |                 ioread8(&idio16gpio->reg->irq_ctl);
      |                                         ^~
drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_irq_handler':
drivers/gpio/gpio-pci-idio-16.c:164:46: error: invalid use of undefined type 'struct idio_16'
  164 |         irq_status = ioread8(&idio16gpio->reg->irq_status);
      |                                              ^~
drivers/gpio/gpio-pci-idio-16.c:178:37: error: invalid use of undefined type 'struct idio_16'
  178 |         iowrite8(0, &idio16gpio->reg->in0_7);
      |                                     ^~
drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_irq_init_hw':
drivers/gpio/gpio-pci-idio-16.c:198:37: error: invalid use of undefined type 'struct idio_16'
  198 |         iowrite8(0, &idio16gpio->reg->irq_ctl);
      |                                     ^~
drivers/gpio/gpio-pci-idio-16.c:199:37: error: invalid use of undefined type 'struct idio_16'
  199 |         iowrite8(0, &idio16gpio->reg->in0_7);
      |                                     ^~
drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_probe':
drivers/gpio/gpio-pci-idio-16.c:232:37: error: invalid use of undefined type 'struct idio_16'
  232 |         iowrite8(0, &idio16gpio->reg->filter_ctl);
      |                                     ^~
drivers/gpio/gpio-pci-idio-16.c:248:9: error: implicit declaration of function 'idio_16_state_init'; did you mean 'file_ra_state_init'? [-Werror=implicit-function-declaration]
  248 |         idio_16_state_init(&idio16gpio->state);
      |         ^~~~~~~~~~~~~~~~~~
      |         file_ra_state_init
drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_gpio_get':
drivers/gpio/gpio-pci-idio-16.c:63:1: error: control reaches end of non-void function [-Werror=return-type]
   63 | }
      | ^

Caused by commit

  473b79057bbd ("gpio: idio-16: Remove unused legacy interface")

I have used the gpio-brgl tree from next-20230322 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the gpio-brgl tree

[William Breathitt Gray]

[-- Attachment #1: Type: text/plain, Size: 5611 bytes --]

On Thu, Mar 23, 2023 at 12:29:13PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the gpio-brgl tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/gpio/gpio-pci-idio-16.c:32:30: error: field 'state' has incomplete type
>    32 |         struct idio_16_state state;
>       |                              ^~~~~
> drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_gpio_get_direction':
> drivers/gpio/gpio-pci-idio-16.c:39:13: error: implicit declaration of function 'idio_16_get_direction'; did you mean 'idio_16_gpio_get_direction'? [-Werror=implicit-function-declaration]
>    39 |         if (idio_16_get_direction(offset))
>       |             ^~~~~~~~~~~~~~~~~~~~~
>       |             idio_16_gpio_get_direction
> drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_gpio_get':
> drivers/gpio/gpio-pci-idio-16.c:62:16: error: implicit declaration of function 'idio_16_get'; did you mean 'idio_16_gpio_get'? [-Werror=implicit-function-declaration]
>    62 |         return idio_16_get(idio16gpio->reg, &idio16gpio->state, offset);
>       |                ^~~~~~~~~~~
>       |                idio_16_gpio_get
> drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_gpio_get_multiple':
> drivers/gpio/gpio-pci-idio-16.c:70:9: error: implicit declaration of function 'idio_16_get_multiple'; did you mean 'idio_16_gpio_get_multiple'? [-Werror=implicit-function-declaration]
>    70 |         idio_16_get_multiple(idio16gpio->reg, &idio16gpio->state, mask, bits);
>       |         ^~~~~~~~~~~~~~~~~~~~
>       |         idio_16_gpio_get_multiple
> drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_gpio_set':
> drivers/gpio/gpio-pci-idio-16.c:79:9: error: implicit declaration of function 'idio_16_set'; did you mean 'idio_16_gpio_set'? [-Werror=implicit-function-declaration]
>    79 |         idio_16_set(idio16gpio->reg, &idio16gpio->state, offset, value);
>       |         ^~~~~~~~~~~
>       |         idio_16_gpio_set
> drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_gpio_set_multiple':
> drivers/gpio/gpio-pci-idio-16.c:87:9: error: implicit declaration of function 'idio_16_set_multiple'; did you mean 'idio_16_gpio_set_multiple'? [-Werror=implicit-function-declaration]
>    87 |         idio_16_set_multiple(idio16gpio->reg, &idio16gpio->state, mask, bits);
>       |         ^~~~~~~~~~~~~~~~~~~~
>       |         idio_16_gpio_set_multiple
> drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_irq_mask':
> drivers/gpio/gpio-pci-idio-16.c:106:45: error: invalid use of undefined type 'struct idio_16'
>   106 |                 iowrite8(0, &idio16gpio->reg->irq_ctl);
>       |                                             ^~
> drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_irq_unmask':
> drivers/gpio/gpio-pci-idio-16.c:129:41: error: invalid use of undefined type 'struct idio_16'
>   129 |                 ioread8(&idio16gpio->reg->irq_ctl);
>       |                                         ^~
> drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_irq_handler':
> drivers/gpio/gpio-pci-idio-16.c:164:46: error: invalid use of undefined type 'struct idio_16'
>   164 |         irq_status = ioread8(&idio16gpio->reg->irq_status);
>       |                                              ^~
> drivers/gpio/gpio-pci-idio-16.c:178:37: error: invalid use of undefined type 'struct idio_16'
>   178 |         iowrite8(0, &idio16gpio->reg->in0_7);
>       |                                     ^~
> drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_irq_init_hw':
> drivers/gpio/gpio-pci-idio-16.c:198:37: error: invalid use of undefined type 'struct idio_16'
>   198 |         iowrite8(0, &idio16gpio->reg->irq_ctl);
>       |                                     ^~
> drivers/gpio/gpio-pci-idio-16.c:199:37: error: invalid use of undefined type 'struct idio_16'
>   199 |         iowrite8(0, &idio16gpio->reg->in0_7);
>       |                                     ^~
> drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_probe':
> drivers/gpio/gpio-pci-idio-16.c:232:37: error: invalid use of undefined type 'struct idio_16'
>   232 |         iowrite8(0, &idio16gpio->reg->filter_ctl);
>       |                                     ^~
> drivers/gpio/gpio-pci-idio-16.c:248:9: error: implicit declaration of function 'idio_16_state_init'; did you mean 'file_ra_state_init'? [-Werror=implicit-function-declaration]
>   248 |         idio_16_state_init(&idio16gpio->state);
>       |         ^~~~~~~~~~~~~~~~~~
>       |         file_ra_state_init
> drivers/gpio/gpio-pci-idio-16.c: In function 'idio_16_gpio_get':
> drivers/gpio/gpio-pci-idio-16.c:63:1: error: control reaches end of non-void function [-Werror=return-type]
>    63 | }
>       | ^
> 
> Caused by commit
> 
>   473b79057bbd ("gpio: idio-16: Remove unused legacy interface")
> 
> I have used the gpio-brgl tree from next-20230322 for today.
> 
> -- 
> Cheers,
> Stephen Rothwell

Commit 473b79057bbd shouldn't be merged until all of the IDIO-16 legacy
interface is first removed.

Bart, would you revert all of the "Migrate IDIO-16 GPIO drivers to
regmap API" patches [0]? That patchset needs to be revised anyway to
prevent conflicts with the handle_mask_sync() API change [1]; I'll
submit a v3 later this week that resolves the incompatibilies and
rebase on the latest gpio/for-next.

William Breathitt Gray

[0] https://lore.kernel.org/all/cover.1677515341.git.william.gray@linaro.org/
[1] https://lore.kernel.org/all/cover.1679323449.git.william.gray@linaro.org/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: linux-next: build failure after merge of the gpio-brgl tree

[Andy Shevchenko]

On Mon, Dec 20, 2021 at 11:22 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the gpio-brgl tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/gpio/gpio-rda.c: In function 'rda_gpio_probe':
> drivers/gpio/gpio-rda.c:200:22: error: unused variable 'np' [-Werror=unused-variable]
>   200 |  struct device_node *np = pdev->dev.of_node;
>       |                      ^~
> cc1: all warnings being treated as errors
>
> Caused by commit
>
>   448cf90513d9 ("gpio: Get rid of duplicate of_node assignment in the drivers")
>
> I have used the gpio-brgl tree from next-20211217 (with the revert) for today.

My fault, sorry. Fix patch is on the way!




--
With Best Regards,
Andy Shevchenko

linux-next: build failure after merge of the gpio-brgl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 604 bytes --]

Hi all,

After merging the gpio-brgl tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpio/gpio-rda.c: In function 'rda_gpio_probe':
drivers/gpio/gpio-rda.c:200:22: error: unused variable 'np' [-Werror=unused-variable]
  200 |  struct device_node *np = pdev->dev.of_node;
      |                      ^~
cc1: all warnings being treated as errors

Caused by commit

  448cf90513d9 ("gpio: Get rid of duplicate of_node assignment in the drivers")

I have used the gpio-brgl tree from next-20211217 (with the revert) for today.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the gpio-brgl tree

[Bartosz Golaszewski]

On Fri, Dec 17, 2021 at 7:17 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> On Mon, 13 Dec 2021 19:12:05 -0800 Florian Fainelli <f.fainelli@gmail.com> wrote:
> >
> > On 12/13/2021 12:31 PM, broonie@kernel.org wrote:
> > > Hi all,
> > >
> > > After merging the gpio-brgl tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > >
> > > /tmp/next/build/drivers/gpio/gpio-bcm-kona.c:508:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
> > >    508 | static const struct of_device_id const bcm_kona_gpio_of_match[] = {
> > >        |                                  ^~~~~
> > > cc1: all warnings being treated as errors
> > >
> > > Caused by commit
> > >
> > >    19784a059cf47b ("gpio: bcm-kona: add const to of_device_id")
> > >
> > > I used the tree from yesterday instead.
> >
> > Doh! Should have double checked the code as the diff was not giving
> > enough context. This patch should simply be dropped, not even build
> > tested by Xiang it seems.
>
> Today, I have reverted that commit.  Please remove or revert it ASAP.
>
> --
> Cheers,
> Stephen Rothwell

Done, sorry for the delay.

Bartosz

Re: linux-next: build failure after merge of the gpio-brgl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]

Hi all,

On Mon, 13 Dec 2021 19:12:05 -0800 Florian Fainelli <f.fainelli@gmail.com> wrote:
>
> On 12/13/2021 12:31 PM, broonie@kernel.org wrote:
> > Hi all,
> > 
> > After merging the gpio-brgl tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > /tmp/next/build/drivers/gpio/gpio-bcm-kona.c:508:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
> >    508 | static const struct of_device_id const bcm_kona_gpio_of_match[] = {
> >        |                                  ^~~~~
> > cc1: all warnings being treated as errors
> > 
> > Caused by commit
> > 
> >    19784a059cf47b ("gpio: bcm-kona: add const to of_device_id")
> > 
> > I used the tree from yesterday instead.  
> 
> Doh! Should have double checked the code as the diff was not giving
> enough context. This patch should simply be dropped, not even build
> tested by Xiang it seems.

Today, I have reverted that commit.  Please remove or revert it ASAP.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the gpio-brgl tree

[Florian Fainelli]

On 12/13/2021 12:31 PM, broonie@kernel.org wrote:
> Hi all,
> 
> After merging the gpio-brgl tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> /tmp/next/build/drivers/gpio/gpio-bcm-kona.c:508:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
>    508 | static const struct of_device_id const bcm_kona_gpio_of_match[] = {
>        |                                  ^~~~~
> cc1: all warnings being treated as errors
> 
> Caused by commit
> 
>    19784a059cf47b ("gpio: bcm-kona: add const to of_device_id")
> 
> I used the tree from yesterday instead.

Doh! Should have double checked the code as the diff was not giving 
enough context. This patch should simply be dropped, not even build 
tested by Xiang it seems.
-- 
Florian

linux-next: build failure after merge of the gpio-brgl tree

[broonie]

Hi all,

After merging the gpio-brgl tree, today's linux-next build (x86_64
allmodconfig) failed like this:

/tmp/next/build/drivers/gpio/gpio-bcm-kona.c:508:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
  508 | static const struct of_device_id const bcm_kona_gpio_of_match[] = {
      |                                  ^~~~~
cc1: all warnings being treated as errors

Caused by commit

  19784a059cf47b ("gpio: bcm-kona: add const to of_device_id")

I used the tree from yesterday instead.

Re: linux-next: build failure after merge of the gpio-brgl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 930 bytes --]

Hi all,

On Tue, 23 Nov 2021 13:04:18 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Thu, 18 Nov 2021 11:29:51 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Tue, 16 Nov 2021 10:51:12 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:  
> > >
> > > After merging the gpio-brgl tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > > 
> > > drivers/gpio/gpio-xlp.c:300:16: error: 'GPIO_VARIANT_VULCAN' undeclared here (not in a function)
> > >   300 |  { "BRCM9006", GPIO_VARIANT_VULCAN },
> > >       |                ^~~~~~~~~~~~~~~~~~~
> > > 
> > > Caused by commit
> > > 
> > >   ea708ac5bf41 ("gpio: xlp: Remove Netlogic XLP variants")
> > > 
> > > I have used the gpio-bgrl tree from next-20211115 for today.    
> > 
> > I am still getting this failure :-(  
> 
> And still :-( :-(

Its still failing ...

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the gpio-brgl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 773 bytes --]

Hi all,

On Thu, 18 Nov 2021 11:29:51 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Tue, 16 Nov 2021 10:51:12 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the gpio-brgl tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > drivers/gpio/gpio-xlp.c:300:16: error: 'GPIO_VARIANT_VULCAN' undeclared here (not in a function)
> >   300 |  { "BRCM9006", GPIO_VARIANT_VULCAN },
> >       |                ^~~~~~~~~~~~~~~~~~~
> > 
> > Caused by commit
> > 
> >   ea708ac5bf41 ("gpio: xlp: Remove Netlogic XLP variants")
> > 
> > I have used the gpio-bgrl tree from next-20211115 for today.  
> 
> I am still getting this failure :-(

And still :-( :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the gpio-brgl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 632 bytes --]

Hi all,

On Tue, 16 Nov 2021 10:51:12 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the gpio-brgl tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/gpio/gpio-xlp.c:300:16: error: 'GPIO_VARIANT_VULCAN' undeclared here (not in a function)
>   300 |  { "BRCM9006", GPIO_VARIANT_VULCAN },
>       |                ^~~~~~~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   ea708ac5bf41 ("gpio: xlp: Remove Netlogic XLP variants")
> 
> I have used the gpio-bgrl tree from next-20211115 for today.

I am still getting this failure :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the gpio-brgl tree

[Rob Herring]

On Mon, Nov 15, 2021 at 5:51 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the gpio-brgl tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/gpio/gpio-xlp.c:300:16: error: 'GPIO_VARIANT_VULCAN' undeclared here (not in a function)
>   300 |  { "BRCM9006", GPIO_VARIANT_VULCAN },
>       |                ^~~~~~~~~~~~~~~~~~~
>
> Caused by commit
>
>   ea708ac5bf41 ("gpio: xlp: Remove Netlogic XLP variants")

Here's the fix needed. Bartosz, let me know if you want a proper patch.

diff --git a/drivers/gpio/gpio-xlp.c b/drivers/gpio/gpio-xlp.c
index 814cc34aef97..c15ca977016c 100644
--- a/drivers/gpio/gpio-xlp.c
+++ b/drivers/gpio/gpio-xlp.c
@@ -297,8 +297,8 @@ static int xlp_gpio_probe(struct platform_device *pdev)

 #ifdef CONFIG_ACPI
 static const struct acpi_device_id xlp_gpio_acpi_match[] = {
-       { "BRCM9006", GPIO_VARIANT_VULCAN },
-       { "CAV9006",  GPIO_VARIANT_VULCAN },
+       { "BRCM9006" },
+       { "CAV9006" },
        {},
 };
 MODULE_DEVICE_TABLE(acpi, xlp_gpio_acpi_match);

linux-next: build failure after merge of the gpio-brgl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

Hi all,

After merging the gpio-brgl tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpio/gpio-xlp.c:300:16: error: 'GPIO_VARIANT_VULCAN' undeclared here (not in a function)
  300 |  { "BRCM9006", GPIO_VARIANT_VULCAN },
      |                ^~~~~~~~~~~~~~~~~~~

Caused by commit

  ea708ac5bf41 ("gpio: xlp: Remove Netlogic XLP variants")

I have used the gpio-bgrl tree from next-20211115 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]