From: coverity-bot <keescook@chromium.org>
To: Namjae Jeon <namjae.jeon@samsung.com>
Cc: Steve French <stfrench@microsoft.com>,
Ronnie Sahlberg <lsahlber@redhat.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Hyunchul Lee <hyc.lee@gmail.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Coverity: parse_veto_list(): Resource leaks
Date: Wed, 31 Mar 2021 14:58:15 -0700 [thread overview]
Message-ID: <202103311458.59A15D3@keescook> (raw)
Hello!
This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20210331 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:
None
788b6f45c1d2 ("cifsd: add server-side procedures for SMB3")
Coverity reported the following:
*** CID 1503590: Resource leaks (RESOURCE_LEAK)
/fs/cifsd/mgmt/share_config.c: 101 in parse_veto_list()
95 p = kzalloc(sizeof(struct ksmbd_veto_pattern), GFP_KERNEL);
96 if (!p)
97 return -ENOMEM;
98
99 sz = strlen(veto_list);
100 if (!sz)
vvv CID 1503590: Resource leaks (RESOURCE_LEAK)
vvv Variable "p" going out of scope leaks the storage it points to.
101 break;
102
103 p->pattern = kstrdup(veto_list, GFP_KERNEL);
104 if (!p->pattern) {
105 ksmbd_free(p);
106 return -ENOMEM;
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1503590 ("Resource leaks")
Fixes: 788b6f45c1d2 ("cifsd: add server-side procedures for SMB3")
Thanks for your attention!
--
Coverity-bot
next reply other threads:[~2021-03-31 21:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210331215819epcas1p1a0658989d4f52e373f2fcc86f37821fd@epcas1p1.samsung.com>
2021-03-31 21:58 ` coverity-bot [this message]
2021-04-01 9:04 ` Coverity: parse_veto_list(): Resource leaks Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202103311458.59A15D3@keescook \
--to=keescook@chromium.org \
--cc=gustavo@embeddedor.com \
--cc=hyc.lee@gmail.com \
--cc=linux-next@vger.kernel.org \
--cc=lsahlber@redhat.com \
--cc=namjae.jeon@samsung.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=stfrench@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).