Linux-Next Archive on
 help / color / Atom feed
* Coverity: rx_ft_put(): Error handling issues
@ 2021-03-31 21:58 coverity-bot
  0 siblings, 0 replies; only message in thread
From: coverity-bot @ 2021-03-31 21:58 UTC (permalink / raw)
  To: Huy Nguyen
  Cc: Tariq Toukan, Saeed Mahameed, Boris Pismenny,
	Gustavo A. R. Silva, linux-next


This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20210331 as part of the linux-next scan project:

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:

    5e466345291a ("net/mlx5e: IPsec: Add IPsec steering in local NIC RX")

Coverity reported the following:

*** CID 1503588:  Error handling issues  (CHECKED_RETURN)
/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c: 323 in rx_ft_put()
317     	fs_prot = &accel_esp->fs_prot[type];
318     	mutex_lock(&fs_prot->prot_mutex);
319     	if (--fs_prot->refcnt)
320     		goto out;
322     	/* disconnect */
vvv     CID 1503588:  Error handling issues  (CHECKED_RETURN)
vvv     Calling "mlx5e_ttc_fwd_default_dest" without checking return value (as is done elsewhere 4 out of 5 times).
323     	mlx5e_ttc_fwd_default_dest(priv, fs_esp2tt(type));
325     	/* remove FT */
326     	rx_destroy(priv, type);
328     out:

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):

Reported-by: coverity-bot <>
Addresses-Coverity-ID: 1503588 ("Error handling issues")
Fixes: 5e466345291a ("net/mlx5e: IPsec: Add IPsec steering in local NIC RX")

Thanks for your attention!


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-31 21:58 Coverity: rx_ft_put(): Error handling issues coverity-bot

Linux-Next Archive on

Archives are clonable:
	git clone --mirror linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ \
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone