From: coverity-bot <keescook@chromium.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Vinod Koul <vkoul@kernel.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Coverity: qcom_swrm_irq_handler(): Control flow issues
Date: Wed, 31 Mar 2021 14:59:51 -0700 [thread overview]
Message-ID: <202103311459.82A93D8@keescook> (raw)
Hello!
This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20210331 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:
None
c7d49c76d1d5 ("soundwire: qcom: add support to new interrupts")
Coverity reported the following:
*** CID 1503584: Control flow issues (NO_EFFECT)
/drivers/soundwire/qcom.c: 446 in qcom_swrm_irq_handler()
440 if (!value)
441 continue;
442
443 switch (value) {
444 case SWRM_INTERRUPT_STATUS_SLAVE_PEND_IRQ:
445 devnum = qcom_swrm_get_alert_slave_dev_num(swrm);
vvv CID 1503584: Control flow issues (NO_EFFECT)
vvv This less-than-zero comparison of an unsigned value is never true. "devnum < 0".
446 if (devnum < 0) {
447 dev_err_ratelimited(swrm->dev,
448 "no slave alert found.spurious interrupt\n");
449 } else {
450 sdw_handle_slave_status(&swrm->bus, swrm->status);
451 }
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1503584 ("Control flow issues")
Fixes: c7d49c76d1d5 ("soundwire: qcom: add support to new interrupts")
Thanks for your attention!
--
Coverity-bot
reply other threads:[~2021-03-31 22:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202103311459.82A93D8@keescook \
--to=keescook@chromium.org \
--cc=gustavo@embeddedor.com \
--cc=linux-next@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).