From: coverity-bot <keescook@chromium.org>
To: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.de>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Coverity: snd_ctl_disconnect_layer(): Possible Control flow issues
Date: Wed, 31 Mar 2021 15:03:54 -0700 [thread overview]
Message-ID: <202103311503.E6CA7884@keescook> (raw)
Hello!
This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20210331 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:
None
3f0638a0333b ("ALSA: control - add layer registration routines")
Coverity reported the following:
*** CID 1503580: Possible Control flow issues (DEADCODE)
/sound/core/control.c: 2082 in snd_ctl_disconnect_layer()
2076 down_write(&snd_ctl_layer_rwsem);
2077 for (lops2 = snd_ctl_layer, prev_lops2 = NULL; lops2; lops2 = lops2->next)
2078 if (lops2 == lops) {
2079 if (!prev_lops2)
2080 snd_ctl_layer = lops->next;
2081 else
vvv CID 1503580: Possible Control flow issues (DEADCODE)
vvv Execution cannot reach this statement: "prev_lops2->next = lops->next;".
2082 prev_lops2->next = lops->next;
2083 break;
2084 }
2085 up_write(&snd_ctl_layer_rwsem);
2086 }
2087 EXPORT_SYMBOL_GPL(snd_ctl_disconnect_layer);
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1503580 ("Possible Control flow issues")
Fixes: 3f0638a0333b ("ALSA: control - add layer registration routines")
Thanks for your attention!
--
Coverity-bot
reply other threads:[~2021-03-31 22:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202103311503.E6CA7884@keescook \
--to=keescook@chromium.org \
--cc=gustavo@embeddedor.com \
--cc=linux-next@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).