Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* Coverity: snd_ctl_disconnect_layer(): Possible Control flow issues
@ 2021-03-31 22:03 coverity-bot
  0 siblings, 0 replies; only message in thread
From: coverity-bot @ 2021-03-31 22:03 UTC (permalink / raw)
  To: Jaroslav Kysela; +Cc: Takashi Iwai, Gustavo A. R. Silva, linux-next

Hello!

This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20210331 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:

  None
    3f0638a0333b ("ALSA: control - add layer registration routines")

Coverity reported the following:

*** CID 1503580:  Possible Control flow issues  (DEADCODE)
/sound/core/control.c: 2082 in snd_ctl_disconnect_layer()
2076     	down_write(&snd_ctl_layer_rwsem);
2077     	for (lops2 = snd_ctl_layer, prev_lops2 = NULL; lops2; lops2 = lops2->next)
2078     		if (lops2 == lops) {
2079     			if (!prev_lops2)
2080     				snd_ctl_layer = lops->next;
2081     			else
vvv     CID 1503580:  Possible Control flow issues  (DEADCODE)
vvv     Execution cannot reach this statement: "prev_lops2->next = lops->next;".
2082     				prev_lops2->next = lops->next;
2083     			break;
2084     		}
2085     	up_write(&snd_ctl_layer_rwsem);
2086     }
2087     EXPORT_SYMBOL_GPL(snd_ctl_disconnect_layer);

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):

Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1503580 ("Possible Control flow issues")
Fixes: 3f0638a0333b ("ALSA: control - add layer registration routines")

Thanks for your attention!

-- 
Coverity-bot

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-31 22:03 Coverity: snd_ctl_disconnect_layer(): Possible Control flow issues coverity-bot

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git