Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: Fixes tag needs some work in the soundwire tree
@ 2021-04-01  8:48 Stephen Rothwell
  0 siblings, 0 replies; 5+ messages in thread
From: Stephen Rothwell @ 2021-04-01  8:48 UTC (permalink / raw)
  To: Vinod Koul
  Cc: Rander Wang, Linux Kernel Mailing List, Linux Next Mailing List


[-- Attachment #1: Type: text/plain, Size: 545 bytes --]

Hi all,

In commit

  187c59cdcfe9 ("soundwire: stream: fix memory leak in stream config error path")

Fixes tag

  Fixes: bbe7379d8040a ("soundwire: Add support for SoundWire stream management")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Did you mean

Fixes: bbe7379d8040 ("soundwire: Add support for port management")

or

Fixes: 89e590535f32 ("soundwire: Add support for SoundWire stream management")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: linux-next: Fixes tag needs some work in the soundwire tree
  2021-05-11 21:50 Stephen Rothwell
@ 2021-05-11 21:51 ` Stephen Rothwell
  0 siblings, 0 replies; 5+ messages in thread
From: Stephen Rothwell @ 2021-05-11 21:51 UTC (permalink / raw)
  To: Vinod Koul
  Cc: Srinivas Kandagatla, Linux Kernel Mailing List, Linux Next Mailing List


[-- Attachment #1: Type: text/plain, Size: 544 bytes --]

Hi all,

On Wed, 12 May 2021 07:50:55 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> In commit
> 
>   f136f3279d85 ("soundwire: qcom: fix handling of qcom,ports-block-pack-mode")
> 
> Fixes tag
> 
>   Fixes: 5943e4fb14e3 ("soundwire: qcom: check of_property_read status")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: a5943e4fb14e ("soundwire: qcom: check of_property_read status")

Actually this is in the soundwire-fixes tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* linux-next: Fixes tag needs some work in the soundwire tree
@ 2021-05-11 21:50 Stephen Rothwell
  2021-05-11 21:51 ` Stephen Rothwell
  0 siblings, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2021-05-11 21:50 UTC (permalink / raw)
  To: Vinod Koul
  Cc: Srinivas Kandagatla, Linux Kernel Mailing List, Linux Next Mailing List


[-- Attachment #1: Type: text/plain, Size: 379 bytes --]

Hi all,

In commit

  f136f3279d85 ("soundwire: qcom: fix handling of qcom,ports-block-pack-mode")

Fixes tag

  Fixes: 5943e4fb14e3 ("soundwire: qcom: check of_property_read status")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: a5943e4fb14e ("soundwire: qcom: check of_property_read status")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: linux-next: Fixes tag needs some work in the soundwire tree
  2021-02-07 10:59 Stephen Rothwell
@ 2021-02-07 12:20 ` Vinod Koul
  0 siblings, 0 replies; 5+ messages in thread
From: Vinod Koul @ 2021-02-07 12:20 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Bard Liao, Linux Kernel Mailing List, Linux Next Mailing List

On 07-02-21, 21:59, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   531f45f2bdf6 ("soundwire: export sdw_write/read_no_pm functions")
> 
> Fixes tag
> 
>   Fixes: 60ee9be25571 ('soundwire: bus: add PM/no-PM versions of
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
> 
> Please do not split Fixes tags over more than one line.

Thanks for spotting it, fixed it up now

-- 
~Vinod

^ permalink raw reply	[flat|nested] 5+ messages in thread

* linux-next: Fixes tag needs some work in the soundwire tree
@ 2021-02-07 10:59 Stephen Rothwell
  2021-02-07 12:20 ` Vinod Koul
  0 siblings, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2021-02-07 10:59 UTC (permalink / raw)
  To: Vinod Koul; +Cc: Bard Liao, Linux Kernel Mailing List, Linux Next Mailing List


[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

Hi all,

In commit

  531f45f2bdf6 ("soundwire: export sdw_write/read_no_pm functions")

Fixes tag

  Fixes: 60ee9be25571 ('soundwire: bus: add PM/no-PM versions of

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-01  8:48 linux-next: Fixes tag needs some work in the soundwire tree Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2021-05-11 21:50 Stephen Rothwell
2021-05-11 21:51 ` Stephen Rothwell
2021-02-07 10:59 Stephen Rothwell
2021-02-07 12:20 ` Vinod Koul

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git