Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: build warning after merge of the drm-intel-fixes tree
@ 2021-03-26  8:58 Stephen Rothwell
  2021-03-28 22:01 ` Stephen Rothwell
  0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2021-03-26  8:58 UTC (permalink / raw)
  To: Daniel Vetter, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi,
	Intel Graphics, DRI
  Cc: Imre Deak, Linux Kernel Mailing List, Linux Next Mailing List


[-- Attachment #1: Type: text/plain, Size: 379 bytes --]

Hi all,

After merging the drm-intel-fixes tree, today's linux-next build
(htmldocs) produced this warning:

Documentation/gpu/i915:22: /drivers/gpu/drm/i915/intel_runtime_pm.c:423: WARNING: Inline strong start-string without end-string.

Introduced by commit

  8840e3bd981f ("drm/i915: Fix the GT fence revocation runtime PM logic")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: linux-next: build warning after merge of the drm-intel-fixes tree
  2021-03-26  8:58 linux-next: build warning after merge of the drm-intel-fixes tree Stephen Rothwell
@ 2021-03-28 22:01 ` Stephen Rothwell
  2021-03-29 18:23   ` Imre Deak
  0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2021-03-28 22:01 UTC (permalink / raw)
  To: Daniel Vetter, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi,
	Intel Graphics, DRI
  Cc: Imre Deak, Linux Kernel Mailing List, Linux Next Mailing List


[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

Hi all,

On Fri, 26 Mar 2021 19:58:38 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the drm-intel-fixes tree, today's linux-next build
> (htmldocs) produced this warning:
> 
> Documentation/gpu/i915:22: /drivers/gpu/drm/i915/intel_runtime_pm.c:423: WARNING: Inline strong start-string without end-string.
> 
> Introduced by commit
> 
>   8840e3bd981f ("drm/i915: Fix the GT fence revocation runtime PM logic")

This warning now exists in Linus' tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: linux-next: build warning after merge of the drm-intel-fixes tree
  2021-03-28 22:01 ` Stephen Rothwell
@ 2021-03-29 18:23   ` Imre Deak
  2021-04-08 10:38     ` Daniel Vetter
  0 siblings, 1 reply; 7+ messages in thread
From: Imre Deak @ 2021-03-29 18:23 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Daniel Vetter, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi,
	Intel Graphics, DRI, Linux Kernel Mailing List,
	Linux Next Mailing List

Hi Stephen,

thanks for the report.

On Mon, Mar 29, 2021 at 09:01:17AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> On Fri, 26 Mar 2021 19:58:38 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the drm-intel-fixes tree, today's linux-next build
> > (htmldocs) produced this warning:
> > 
> > Documentation/gpu/i915:22: /drivers/gpu/drm/i915/intel_runtime_pm.c:423: WARNING: Inline strong start-string without end-string.

The problem seems to be the

	@ignore_usecount=true

part in __intel_runtime_pm_get_if_active()'s docbook documentation. I
can't see the problem with it, it was meant as a reference to the
function parameter, granted I'm not sure what's the proper markup syntax
for this.

I will follow up with the following change which suppresses the warning
and renders the html as expected unless someone can suggest a better
way:

- * If @ignore_usecount=true, a reference will be acquired even if there is no
+ * If @ignore_usecount is true, a reference will be acquired even if there is no

--Imre

> > 
> > Introduced by commit
> > 
> >   8840e3bd981f ("drm/i915: Fix the GT fence revocation runtime PM logic")
> 
> This warning now exists in Linus' tree.
> 
> -- 
> Cheers,
> Stephen Rothwell



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: linux-next: build warning after merge of the drm-intel-fixes tree
  2021-03-29 18:23   ` Imre Deak
@ 2021-04-08 10:38     ` Daniel Vetter
  2021-04-08 15:20       ` Imre Deak
  0 siblings, 1 reply; 7+ messages in thread
From: Daniel Vetter @ 2021-04-08 10:38 UTC (permalink / raw)
  To: Imre Deak
  Cc: Stephen Rothwell, Daniel Vetter, Jani Nikula, Joonas Lahtinen,
	Rodrigo Vivi, Intel Graphics, DRI, Linux Kernel Mailing List,
	Linux Next Mailing List

On Mon, Mar 29, 2021 at 09:23:35PM +0300, Imre Deak wrote:
> Hi Stephen,
> 
> thanks for the report.
> 
> On Mon, Mar 29, 2021 at 09:01:17AM +1100, Stephen Rothwell wrote:
> > Hi all,
> > 
> > On Fri, 26 Mar 2021 19:58:38 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > After merging the drm-intel-fixes tree, today's linux-next build
> > > (htmldocs) produced this warning:
> > > 
> > > Documentation/gpu/i915:22: /drivers/gpu/drm/i915/intel_runtime_pm.c:423: WARNING: Inline strong start-string without end-string.
> 
> The problem seems to be the
> 
> 	@ignore_usecount=true
> 
> part in __intel_runtime_pm_get_if_active()'s docbook documentation. I
> can't see the problem with it, it was meant as a reference to the
> function parameter, granted I'm not sure what's the proper markup syntax
> for this.
> 
> I will follow up with the following change which suppresses the warning
> and renders the html as expected unless someone can suggest a better
> way:
> 
> - * If @ignore_usecount=true, a reference will be acquired even if there is no
> + * If @ignore_usecount is true, a reference will be acquired even if there is no

Yeah you can't just use most pseudo-code in kerneldoc because it's
interpreted as raw .rst. So would need some .rst quoting of some sorts to
make it render correctly.

Usually for pseudo-code I go with blockquotes (started with :: at the end
of the previous line, plus indenting), that gives you also a nice
fixed-width font and everything.

Aside from the hyperlink stuff plain English works best in the text parts.
-Daniel

> 
> --Imre
> 
> > > 
> > > Introduced by commit
> > > 
> > >   8840e3bd981f ("drm/i915: Fix the GT fence revocation runtime PM logic")
> > 
> > This warning now exists in Linus' tree.
> > 
> > -- 
> > Cheers,
> > Stephen Rothwell
> 
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: linux-next: build warning after merge of the drm-intel-fixes tree
  2021-04-08 10:38     ` Daniel Vetter
@ 2021-04-08 15:20       ` Imre Deak
  0 siblings, 0 replies; 7+ messages in thread
From: Imre Deak @ 2021-04-08 15:20 UTC (permalink / raw)
  To: Stephen Rothwell, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi,
	Intel Graphics, DRI, Linux Kernel Mailing List,
	Linux Next Mailing List

On Thu, Apr 08, 2021 at 12:38:52PM +0200, Daniel Vetter wrote:
> On Mon, Mar 29, 2021 at 09:23:35PM +0300, Imre Deak wrote:
> > Hi Stephen,
> > 
> > thanks for the report.
> > 
> > On Mon, Mar 29, 2021 at 09:01:17AM +1100, Stephen Rothwell wrote:
> > > Hi all,
> > > 
> > > On Fri, 26 Mar 2021 19:58:38 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > >
> > > > After merging the drm-intel-fixes tree, today's linux-next build
> > > > (htmldocs) produced this warning:
> > > > 
> > > > Documentation/gpu/i915:22: /drivers/gpu/drm/i915/intel_runtime_pm.c:423: WARNING: Inline strong start-string without end-string.
> > 
> > The problem seems to be the
> > 
> > 	@ignore_usecount=true
> > 
> > part in __intel_runtime_pm_get_if_active()'s docbook documentation. I
> > can't see the problem with it, it was meant as a reference to the
> > function parameter, granted I'm not sure what's the proper markup syntax
> > for this.
> > 
> > I will follow up with the following change which suppresses the warning
> > and renders the html as expected unless someone can suggest a better
> > way:
> > 
> > - * If @ignore_usecount=true, a reference will be acquired even if there is no
> > + * If @ignore_usecount is true, a reference will be acquired even if there is no
> 
> Yeah you can't just use most pseudo-code in kerneldoc because it's
> interpreted as raw .rst. So would need some .rst quoting of some sorts to
> make it render correctly.
> 
> Usually for pseudo-code I go with blockquotes (started with :: at the end
> of the previous line, plus indenting), that gives you also a nice
> fixed-width font and everything.

Thanks for the info, will read up on the .rst docs and will try to check
make htmldocs before sending patches.

> Aside from the hyperlink stuff plain English works best in the text parts.
> -Daniel
> 
> > 
> > --Imre
> > 
> > > > 
> > > > Introduced by commit
> > > > 
> > > >   8840e3bd981f ("drm/i915: Fix the GT fence revocation runtime PM logic")
> > > 
> > > This warning now exists in Linus' tree.
> > > 
> > > -- 
> > > Cheers,
> > > Stephen Rothwell
> > 
> > 
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 7+ messages in thread

* linux-next: build warning after merge of the drm-intel-fixes tree
@ 2021-03-24 22:24 Stephen Rothwell
  0 siblings, 0 replies; 7+ messages in thread
From: Stephen Rothwell @ 2021-03-24 22:24 UTC (permalink / raw)
  To: Daniel Vetter, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi,
	Intel Graphics, DRI
  Cc: Imre Deak, Linux Kernel Mailing List, Linux Next Mailing List


[-- Attachment #1: Type: text/plain, Size: 398 bytes --]

Hi all,

After merging the drm-intel-fixes tree, today's linux-next build
(htmldocs) produced this warning:

Documentation/gpu/i915:22: /home/sfr/next/next/drivers/gpu/drm/i915/intel_runtime_pm.c:423: WARNING: Inline strong start-string without end-string.

Introduced by commit

  8840e3bd981f ("drm/i915: Fix the GT fence revocation runtime PM logic")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* linux-next: build warning after merge of the drm-intel-fixes tree
@ 2017-06-08  0:20 Stephen Rothwell
  0 siblings, 0 replies; 7+ messages in thread
From: Stephen Rothwell @ 2017-06-08  0:20 UTC (permalink / raw)
  To: Daniel Vetter, Intel Graphics, DRI
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Chris Wilson,
	Jani Nikula

Hi all,

After merging the drm-misc-fixes tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/gpu/drm/i915/intel_engine_cs.c: In function 'intel_engine_is_idle':
drivers/gpu/drm/i915/intel_engine_cs.c:1103:27: warning: unused variable 'dev_priv' [-Wunused-variable]
  struct drm_i915_private *dev_priv = engine->i915;
                           ^

Introduced by commit

  d9533f19d840 ("drm/i915: Hold a wakeref for probing the ring registers")

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, back to index

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-26  8:58 linux-next: build warning after merge of the drm-intel-fixes tree Stephen Rothwell
2021-03-28 22:01 ` Stephen Rothwell
2021-03-29 18:23   ` Imre Deak
2021-04-08 10:38     ` Daniel Vetter
2021-04-08 15:20       ` Imre Deak
  -- strict thread matches above, loose matches on Subject: below --
2021-03-24 22:24 Stephen Rothwell
2017-06-08  0:20 Stephen Rothwell

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git