archive mirror
 help / color / mirror / Atom feed
From: coverity-bot <>
To: Aditya Pakki <>
Cc: Santosh Shilimkar <>,
	"David S. Miller" <>,
	"Gustavo A. R. Silva" <>,
Subject: Coverity: rds_send_remove_from_sock(): Null pointer dereferences
Date: Thu, 8 Apr 2021 16:40:39 -0700	[thread overview]
Message-ID: <202104081640.1A09A99900@keescook> (raw)


This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20210408 as part of the linux-next scan project:

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:

  Wed Apr 7 14:01:24 2021 -0700
    0c85a7e87465 ("net/rds: Avoid potential use after free in rds_send_remove_from_sock")

Coverity reported the following:

*** CID 1503716:  Null pointer dereferences  (REVERSE_INULL)
/net/rds/send.c: 668 in rds_send_remove_from_sock()
662     		}
663     		spin_unlock(&rs->rs_lock);
665     unlock_and_drop:
666     		spin_unlock_irqrestore(&rm->m_rs_lock, flags);
667     		rds_message_put(rm);
vvv     CID 1503716:  Null pointer dereferences  (REVERSE_INULL)
vvv     Null-checking "rm" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
668     		if (was_on_sock && rm)
669     			rds_message_put(rm);
670     	}
672     	if (rs) {
673     		rds_wake_sk_sleep(rs);

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):

Reported-by: coverity-bot <>
Addresses-Coverity-ID: 1503716 ("Null pointer dereferences")
Fixes: 0c85a7e87465 ("net/rds: Avoid potential use after free in rds_send_remove_from_sock")

Thanks for your attention!


                 reply	other threads:[~2021-04-08 23:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202104081640.1A09A99900@keescook \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).