From: coverity-bot <keescook@chromium.org>
To: Gao Xiang <hsiangkao@redhat.com>
Cc: Chao Yu <yuchao0@huawei.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Coverity: erofs_get_pcpubuf(): Program hangs
Date: Thu, 8 Apr 2021 17:09:53 -0700 [thread overview]
Message-ID: <202104081709.48778B3@keescook> (raw)
Hello!
This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20210408 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:
Wed Apr 7 12:41:22 2021 +0800
91a196935395 ("erofs: introduce multipage per-CPU buffers")
Coverity reported the following:
*** CID 1503700: Program hangs (LOCK)
/fs/erofs/pcpubuf.c: 31 in erofs_get_pcpubuf()
25 raw_spin_lock(&pcb->lock);
26 if (requiredpages > pcb->nrpages) {
27 raw_spin_unlock(&pcb->lock);
28 put_cpu_var(erofs_pcb);
29 return NULL;
30 }
vvv CID 1503700: Program hangs (LOCK)
vvv Returning without unlocking "pcb->lock".
31 return pcb->ptr;
32 }
33
34 void erofs_put_pcpubuf(void *ptr)
35 {
36 struct erofs_pcpubuf *pcb = &per_cpu(erofs_pcb, smp_processor_id());
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1503700 ("Program hangs")
Fixes: 91a196935395 ("erofs: introduce multipage per-CPU buffers")
Thanks for your attention!
--
Coverity-bot
next reply other threads:[~2021-04-09 0:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 0:09 coverity-bot [this message]
2021-04-09 1:06 ` Coverity: erofs_get_pcpubuf(): Program hangs Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202104081709.48778B3@keescook \
--to=keescook@chromium.org \
--cc=gustavo@embeddedor.com \
--cc=hsiangkao@redhat.com \
--cc=linux-next@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).