* Coverity: rcar_pcie_resume(): Error handling issues
@ 2021-04-09 0:10 coverity-bot
0 siblings, 0 replies; only message in thread
From: coverity-bot @ 2021-04-09 0:10 UTC (permalink / raw)
To: Marc Zyngier
Cc: Marek Vasut, Bjorn Helgaas, Lorenzo Pieralisi,
Gustavo A. R. Silva, linux-next
Hello!
This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20210408 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:
Thu Apr 1 12:16:18 2021 +0100
516286287d71 ("PCI: rcar: Convert to MSI domains")
Coverity reported the following:
*** CID 1503693: Error handling issues (CHECKED_RETURN)
/drivers/pci/controller/pcie-rcar-host.c: 992 in rcar_pcie_resume()
986
987 /* Enable MSI */
988 if (IS_ENABLED(CONFIG_PCI_MSI)) {
989 struct resource res;
990 u32 val;
991
vvv CID 1503693: Error handling issues (CHECKED_RETURN)
vvv Calling "of_address_to_resource" without checking return value (as is done elsewhere 98 out of 104 times).
992 of_address_to_resource(dev->of_node, 0, &res);
993 rcar_pci_write_reg(pcie, upper_32_bits(res.start), PCIEMSIAUR);
994 rcar_pci_write_reg(pcie, lower_32_bits(res.start) | MSIFE, PCIEMSIALR);
995
996 bitmap_to_arr32(&val, host->msi.used, INT_PCI_MSI_NR);
997 rcar_pci_write_reg(pcie, val, PCIEMSIIER);
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1503693 ("Error handling issues")
Fixes: 516286287d71 ("PCI: rcar: Convert to MSI domains")
Thanks for your attention!
--
Coverity-bot
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-04-09 0:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09 0:10 Coverity: rcar_pcie_resume(): Error handling issues coverity-bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).