* Coverity: z_erofs_handle_inplace_io(): Uninitialized variables
@ 2021-04-09 0:09 coverity-bot
2021-04-09 1:01 ` Gao Xiang
0 siblings, 1 reply; 3+ messages in thread
From: coverity-bot @ 2021-04-09 0:09 UTC (permalink / raw)
To: Gao Xiang; +Cc: Chao Yu, Gustavo A. R. Silva, linux-next
Hello!
This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20210408 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:
Wed Apr 7 13:17:55 2021 +0800
c660a3a86e7e ("erofs: support decompress big pcluster for lz4 backend")
Coverity reported the following:
*** CID 1503704: Uninitialized variables (UNINIT)
/fs/erofs/decompressor.c: 160 in z_erofs_handle_inplace_io()
154 }
155 kunmap_atomic(inpage);
156 might_sleep();
157 while (1) {
158 src = vm_map_ram(rq->in, nrpages_in, -1);
159 /* retry two more times (totally 3 times) */
vvv CID 1503704: Uninitialized variables (UNINIT)
vvv Using uninitialized value "i".
160 if (src || ++i >= 3)
161 break;
162 vm_unmap_aliases();
163 }
164 *maptype = 1;
165 return src;
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1503704 ("Uninitialized variables")
Fixes: c660a3a86e7e ("erofs: support decompress big pcluster for lz4 backend")
Thanks for your attention!
--
Coverity-bot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Coverity: z_erofs_handle_inplace_io(): Uninitialized variables
2021-04-09 0:09 Coverity: z_erofs_handle_inplace_io(): Uninitialized variables coverity-bot
@ 2021-04-09 1:01 ` Gao Xiang
2021-04-09 3:02 ` Kees Cook
0 siblings, 1 reply; 3+ messages in thread
From: Gao Xiang @ 2021-04-09 1:01 UTC (permalink / raw)
To: coverity-bot; +Cc: Chao Yu, Gustavo A. R. Silva, linux-next
Hi,
On Thu, Apr 08, 2021 at 05:09:14PM -0700, coverity-bot wrote:
> Hello!
>
> This is an experimental semi-automated report about issues detected by
> Coverity from a scan of next-20210408 as part of the linux-next scan project:
> https://scan.coverity.com/projects/linux-next-weekly-scan
>
> You're getting this email because you were associated with the identified
> lines of code (noted below) that were touched by commits:
>
> Wed Apr 7 13:17:55 2021 +0800
> c660a3a86e7e ("erofs: support decompress big pcluster for lz4 backend")
>
> Coverity reported the following:
>
> *** CID 1503704: Uninitialized variables (UNINIT)
> /fs/erofs/decompressor.c: 160 in z_erofs_handle_inplace_io()
> 154 }
> 155 kunmap_atomic(inpage);
> 156 might_sleep();
> 157 while (1) {
> 158 src = vm_map_ram(rq->in, nrpages_in, -1);
> 159 /* retry two more times (totally 3 times) */
> vvv CID 1503704: Uninitialized variables (UNINIT)
> vvv Using uninitialized value "i".
> 160 if (src || ++i >= 3)
> 161 break;
> 162 vm_unmap_aliases();
> 163 }
> 164 *maptype = 1;
> 165 return src;
Thanks for the report!
This bug was reported by Colin King before (next-20210407), and has already
been fixed in (next-20210408), see:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/fs/erofs/decompressor.c?h=next-20210408#n157
and
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/fs/erofs/internal.h?h=next-20210408#n405
Thanks,
Gao Xiang
>
> If this is a false positive, please let us know so we can mark it as
> such, or teach the Coverity rules to be smarter. If not, please make
> sure fixes get into linux-next. :) For patches fixing this, please
> include these lines (but double-check the "Fixes" first):
>
> Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
> Addresses-Coverity-ID: 1503704 ("Uninitialized variables")
> Fixes: c660a3a86e7e ("erofs: support decompress big pcluster for lz4 backend")
>
> Thanks for your attention!
>
> --
> Coverity-bot
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Coverity: z_erofs_handle_inplace_io(): Uninitialized variables
2021-04-09 1:01 ` Gao Xiang
@ 2021-04-09 3:02 ` Kees Cook
0 siblings, 0 replies; 3+ messages in thread
From: Kees Cook @ 2021-04-09 3:02 UTC (permalink / raw)
To: Gao Xiang; +Cc: Chao Yu, Gustavo A. R. Silva, linux-next
On Fri, Apr 09, 2021 at 09:01:46AM +0800, Gao Xiang wrote:
> Hi,
>
> On Thu, Apr 08, 2021 at 05:09:14PM -0700, coverity-bot wrote:
> > Hello!
> >
> > This is an experimental semi-automated report about issues detected by
> > Coverity from a scan of next-20210408 as part of the linux-next scan project:
> > https://scan.coverity.com/projects/linux-next-weekly-scan
> >
> > You're getting this email because you were associated with the identified
> > lines of code (noted below) that were touched by commits:
> >
> > Wed Apr 7 13:17:55 2021 +0800
> > c660a3a86e7e ("erofs: support decompress big pcluster for lz4 backend")
> >
> > Coverity reported the following:
> >
> > *** CID 1503704: Uninitialized variables (UNINIT)
> > /fs/erofs/decompressor.c: 160 in z_erofs_handle_inplace_io()
> > 154 }
> > 155 kunmap_atomic(inpage);
> > 156 might_sleep();
> > 157 while (1) {
> > 158 src = vm_map_ram(rq->in, nrpages_in, -1);
> > 159 /* retry two more times (totally 3 times) */
> > vvv CID 1503704: Uninitialized variables (UNINIT)
> > vvv Using uninitialized value "i".
> > 160 if (src || ++i >= 3)
> > 161 break;
> > 162 vm_unmap_aliases();
> > 163 }
> > 164 *maptype = 1;
> > 165 return src;
>
> Thanks for the report!
>
> This bug was reported by Colin King before (next-20210407), and has already
> been fixed in (next-20210408), see:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/fs/erofs/decompressor.c?h=next-20210408#n157
> and
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/fs/erofs/internal.h?h=next-20210408#n405
Ah-ha, thank you! Colin is fast. :)
--
Kees Cook
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-09 3:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09 0:09 Coverity: z_erofs_handle_inplace_io(): Uninitialized variables coverity-bot
2021-04-09 1:01 ` Gao Xiang
2021-04-09 3:02 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).