linux-next: Fixes tag needs some work in the ext4 tree

linux-next: Fixes tag needs some work in the ext4 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

Hi all,

In commit

  a149d2a5cabb ("ext4: fix check to prevent false positive report of incorrect used inodes")

Fixes tag

  Fixes: 50122847007 ("ext4: fix check to prevent initializing reserved inodes")

has these problem(s):

  - SHA1 should be at least 12 digits long

This is probably not worth rebasing to fix, but can be avoided in future
commits by setting core.abbrev to 12 (or more) or (for git v2.11 or later)
just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the ext4 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 530 bytes --]

Hi all,

In commit

  ebf6cb7c6e12 ("ext4: no need to generate from free list in mballoc")

Fixes tag

  Fixes: 7a2fcbf7f85('ext4: don't use blocks freed but not yet committed in buddy cache init')

has these problem(s):

  - missing space between the SHA1 and the subject
  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the ext4 tree

[Ojaswin Mujoo]

On Fri, Jul 14, 2023 at 08:43:34AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   7c79210b15ef ("ext4: fix off by one issue in ext4_mb_choose_next_group_best_avail()")
> 
> Fixes tag
> 
>   Fixes: 331122aa930 ("ext4: Add allocation criteria 1.5 (CR1_5)")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     This can be fixed for the future by setting core.abbrev to 12 (or
>     more) or (for git v2.11 or later) just making sure it is not set
>     (or set to "auto").
Hi Stephen,

Will keep this in mind.

Thank you,
ojaswin
> 
> -- 
> Cheers,
> Stephen Rothwell

linux-next: Fixes tag needs some work in the ext4 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 467 bytes --]

Hi all,

In commit

  7c79210b15ef ("ext4: fix off by one issue in ext4_mb_choose_next_group_best_avail()")

Fixes tag

  Fixes: 331122aa930 ("ext4: Add allocation criteria 1.5 (CR1_5)")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the ext4 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 457 bytes --]

Hi all,

In commit

  077d0c2c78df ("ext4: make mb_optimize_scan performance mount option work with extents")

Fixes tag

  Fixes: 196e402 (ext4: improve cr 0 / cr 1 group scanning)

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed for the future by setting core.abbrev to 12 (or more)
    or (for git v2.11 or later) just making sure it is not set (or set
    to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the ext4 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 501 bytes --]

Hi all,

In commit

  b7ff91fd030d ("ext4: find old entry again if failed to rename whiteout")

Fixes tag

  Fixes: 6b4b8e6b4ad ("ext4: fix bug for rename with RENAME_WHITEOUT")

has these problem(s):

  - SHA1 should be at least 12 digits long

I don't think that this is worth rebasing to fix, but it can be avoided
in the future by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the ext4 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 427 bytes --]

Hi all,

In commit

  0e6895ba00b7 ("ext4: implement swap_activate aops using iomap")

Fixes tag

  Fixes: ac58e4fb03f ("ext4: move ext4 bmap to use iomap infrastructure")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the ext4 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 427 bytes --]

Hi all,

In commit

  424de74af0d0 ("ext4: implement swap_activate aops using iomap")

Fixes tag

  Fixes: ac58e4fb03f ("ext4: move ext4 bmap to use iomap infrastructure")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the ext4 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 414 bytes --]

Hi all,

In commit

  811985365378 ("ext4: mballoc: Use this_cpu_read instead of this_cpu_ptr")

Fixes tag

  Fixes: 42f56b7a4a7d ("ext4: mballoc: introduce pcpu seqcnt for freeing PA

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the ext4 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

Hi all,

In commit

  8c380ab4b7b5 ("ext4: avoid drop reference to iloc.bh twice")

Fixes tag

  Fixes: fb265c9cb49e("ext4: add ext4_sb_bread() to disambiguate ENOMEM cases")

has these problem(s):

  - missing space between the SHA1 and the subject.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]