Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: Fixes tag needs some work in the spi tree
@ 2021-04-11 22:37 Stephen Rothwell
  0 siblings, 0 replies; 5+ messages in thread
From: Stephen Rothwell @ 2021-04-11 22:37 UTC (permalink / raw)
  To: Mark Brown
  Cc: Muhammad Usama Anjum, Linux Kernel Mailing List, Linux Next Mailing List


[-- Attachment #1: Type: text/plain, Size: 497 bytes --]

Hi all,

In commit

  e980048263ba ("spi: orion: set devdata properly as it is being used later")

Fixes tag

  Fixes: 0e6521f13c2 ("spi: orion: Use device_get_match_data() helper")

has these problem(s):

  - SHA1 should be at least 12 digits long

Probably not worth rebasing to fix, but this can be avoided in future
commits by setting core.abbrev to 12 (or more) or (for git v2.11 or later)
just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: linux-next: Fixes tag needs some work in the spi tree
  2021-01-11 20:58 ` Pratyush Yadav
@ 2021-01-11 23:00   ` Mark Brown
  0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2021-01-11 23:00 UTC (permalink / raw)
  To: Pratyush Yadav
  Cc: Stephen Rothwell, Linux Kernel Mailing List,
	Linux Next Mailing List, Andy Whitcroft, Joe Perches


[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

On Tue, Jan 12, 2021 at 02:28:12AM +0530, Pratyush Yadav wrote:

> I meant this one. My mistake. Copied the wrong hash. Any way to fix this 
> now?

Not without rebasing which I generally avoid.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: linux-next: Fixes tag needs some work in the spi tree
  2021-01-11 20:36 Stephen Rothwell
@ 2021-01-11 20:58 ` Pratyush Yadav
  2021-01-11 23:00   ` Mark Brown
  0 siblings, 1 reply; 5+ messages in thread
From: Pratyush Yadav @ 2021-01-11 20:58 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Mark Brown, Linux Kernel Mailing List, Linux Next Mailing List,
	Andy Whitcroft, Joe Perches

+Cc checkpatch.pl maintainers.

On 12/01/21 07:36AM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   2ef0170e9039 ("spi: cadence-quadspi: Fix build warning on 32-bit platforms")
> 
> Fixes tag
> 
>   Fixes: f453f293979f ("spi: cadence-quadspi: Wait at least 500 ms for direct reads")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'
> 
> Did yu mean
> 
> Fixes: f453f293979f ("spi: cadence-quadspi: Add DTR support")
> 
> or
> 
> Fixes: 0920a32cf6f2 ("spi: cadence-quadspi: Wait at least 500 ms for direct reads")

I meant this one. My mistake. Copied the wrong hash. Any way to fix this 
now?

This check should probably be added in checkpatch.pl so mistakes like 
this can be avoided in the future.

-- 
Regards,
Pratyush Yadav
Texas Instruments India

^ permalink raw reply	[flat|nested] 5+ messages in thread

* linux-next: Fixes tag needs some work in the spi tree
@ 2021-01-11 20:36 Stephen Rothwell
  2021-01-11 20:58 ` Pratyush Yadav
  0 siblings, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2021-01-11 20:36 UTC (permalink / raw)
  To: Mark Brown
  Cc: Pratyush Yadav, Linux Kernel Mailing List, Linux Next Mailing List


[-- Attachment #1: Type: text/plain, Size: 545 bytes --]

Hi all,

In commit

  2ef0170e9039 ("spi: cadence-quadspi: Fix build warning on 32-bit platforms")

Fixes tag

  Fixes: f453f293979f ("spi: cadence-quadspi: Wait at least 500 ms for direct reads")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Did yu mean

Fixes: f453f293979f ("spi: cadence-quadspi: Add DTR support")

or

Fixes: 0920a32cf6f2 ("spi: cadence-quadspi: Wait at least 500 ms for direct reads")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* linux-next: Fixes tag needs some work in the spi tree
@ 2019-04-01 18:12 Stephen Rothwell
  0 siblings, 0 replies; 5+ messages in thread
From: Stephen Rothwell @ 2019-04-01 18:12 UTC (permalink / raw)
  To: Mark Brown
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Sowjanya Komatineni


[-- Attachment #1: Type: text/plain, Size: 266 bytes --]

Hi Mark,

In commit

  fc9ba6e3e28a ("spi: tegra114: use packed mode for 32 bits per word")

Fixes tag

  Fixes: Use packed mode for 32 bits per word transfers to increase

has these problem(s):

  - No SHA1 recognised

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-11 22:37 linux-next: Fixes tag needs some work in the spi tree Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2021-01-11 20:36 Stephen Rothwell
2021-01-11 20:58 ` Pratyush Yadav
2021-01-11 23:00   ` Mark Brown
2019-04-01 18:12 Stephen Rothwell

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git