From: coverity-bot <keescook@chromium.org>
To: Florian Westphal <fw@strlen.de>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Coverity: nf_tables_addchain(): Memory - corruptions
Date: Tue, 8 Jun 2021 10:47:17 -0700 [thread overview]
Message-ID: <202106081047.A1AA0551EB@keescook> (raw)
Hello!
This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20210608 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:
Mon Jun 7 12:23:38 2021 +0200
7b4b2fa37587 ("netfilter: annotate nf_tables base hook ops")
Coverity reported the following:
*** CID 1505166: Memory - corruptions (UNINIT)
/net/netfilter/nf_tables_api.c: 2188 in nf_tables_addchain()
2182 err = PTR_ERR(trans);
2183 goto err_unregister_hook;
2184 }
2185
2186 nft_trans_chain_policy(trans) = NFT_CHAIN_POLICY_UNSET;
2187 if (nft_is_base_chain(chain)) {
vvv CID 1505166: Memory - corruptions (UNINIT)
vvv Using uninitialized value "basechain".
2188 basechain->ops.hook_ops_type = NF_HOOK_OP_NF_TABLES;
2189 nft_trans_chain_policy(trans) = policy;
2190 }
2191
2192 err = nft_chain_add(table, chain);
2193 if (err < 0) {
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1505166 ("Memory - corruptions")
Fixes: 7b4b2fa37587 ("netfilter: annotate nf_tables base hook ops")
Thanks for your attention!
--
Coverity-bot
next reply other threads:[~2021-06-08 17:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 17:47 coverity-bot [this message]
2021-06-08 20:13 ` Coverity: nf_tables_addchain(): Memory - corruptions Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202106081047.A1AA0551EB@keescook \
--to=keescook@chromium.org \
--cc=fw@strlen.de \
--cc=gustavo@embeddedor.com \
--cc=linux-next@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).