From: Petr Mladek <pmladek@suse.com>
To: Chris Down <chris@chrisdown.name>
Cc: Naresh Kamboju <naresh.kamboju@linaro.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the printk tree
Date: Wed, 21 Jul 2021 10:57:05 +0200 [thread overview]
Message-ID: <20210721085705.fy6hrc5n3qtlwehq@pathway.suse.cz> (raw)
In-Reply-To: <YPbBfdz9srIpI+bb@chrisdown.name>
On Tue 2021-07-20 13:28:45, Chris Down wrote:
> Hey folks,
>
> Naresh Kamboju writes:
> > On Tue, 20 Jul 2021 at 13:13, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > Hi all,
> > >
> > > After merging the printk tree, today's linux-next build (mips allnoconfig)
> > > failed like this:
> > >
> > > arch/mips/kernel/genex.o: In function `handle_mcheck_int':
> > > (.text+0x190c): undefined reference to `printk'
> > > arch/mips/kernel/genex.o: In function `handle_reserved_int':
> > > (.text+0x1c8c): undefined reference to `printk'
> > >
> > > Caused by commit
> > >
> > > 337015573718 ("printk: Userspace format indexing support")
> >
> > Following MIPS builds failed at our end due the reported problem.
>
> Thanks: missed this as I made sure to change all .S files to use _printk,
> but this is in a .h file included in a .S file.
>
> Here's what's needed. :-)
>
> diff --git arch/mips/include/asm/asm.h arch/mips/include/asm/asm.h
> index ea4b62ece336..2f8ce94ebaaf 100644
> --- arch/mips/include/asm/asm.h
> +++ arch/mips/include/asm/asm.h
> @@ -114,7 +114,7 @@ symbol = value
> .set push; \
> .set reorder; \
> PTR_LA a0, 8f; \
> - jal printk; \
> + jal _printk; \
> .set pop; \
> TEXT(string)
> #else
Chris, could you please send it as a proper patch?
Best Regards,
Petr
next prev parent reply other threads:[~2021-07-21 9:21 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 7:43 linux-next: build failure after merge of the printk tree Stephen Rothwell
2021-07-20 8:17 ` Naresh Kamboju
2021-07-20 12:28 ` Chris Down
2021-07-21 8:57 ` Petr Mladek [this message]
2021-07-21 11:22 ` Chris Down
2021-07-21 12:49 ` Petr Mladek
2021-07-22 23:01 ` Stephen Rothwell
2021-07-23 11:14 ` Petr Mladek
2021-07-23 12:14 ` Chris Down
-- strict thread matches above, loose matches on Subject: below --
2023-01-15 23:23 Stephen Rothwell
2023-01-16 15:54 ` Petr Mladek
2022-11-21 0:00 Stephen Rothwell
2022-11-21 13:42 ` Petr Mladek
2020-07-29 11:03 Stephen Rothwell
2020-07-29 11:47 ` Herbert Xu
2020-07-28 1:49 Stephen Rothwell
2020-07-28 1:51 ` Herbert Xu
2020-07-28 2:21 ` Stephen Rothwell
2020-07-28 1:54 ` Sergey Senozhatsky
2020-07-28 2:24 ` Stephen Rothwell
2020-06-21 3:15 Stephen Rothwell
2020-06-21 3:26 ` Herbert Xu
2020-06-23 0:26 ` Stephen Rothwell
2020-06-23 12:16 ` Petr Mladek
2020-06-23 12:19 ` Herbert Xu
2020-06-23 14:28 ` Petr Mladek
2020-06-23 15:17 ` Peter Zijlstra
2020-06-24 8:22 ` Petr Mladek
2020-06-24 0:20 ` Herbert Xu
2020-06-24 8:19 ` Petr Mladek
2020-06-24 8:21 ` Herbert Xu
2019-12-05 22:25 Stephen Rothwell
2019-12-06 10:03 ` Petr Mladek
2018-03-02 5:07 Stephen Rothwell
2018-03-02 15:54 ` Petr Mladek
2018-03-03 2:43 ` Stephen Rothwell
2018-03-03 14:47 ` Sergey Senozhatsky
2018-03-05 3:20 ` Dave Young
2018-03-05 5:27 ` Greentime Hu
2018-03-05 5:41 ` Sergey Senozhatsky
2018-03-05 12:25 ` Petr Mladek
2017-12-07 0:37 Stephen Rothwell
2017-12-07 1:26 ` Sergey Senozhatsky
2017-12-07 13:12 ` Petr Mladek
2017-12-06 3:23 Stephen Rothwell
2017-12-06 4:28 ` Sergey Senozhatsky
2017-12-06 10:17 ` Petr Mladek
2017-12-06 10:39 ` Sergey Senozhatsky
2017-12-07 1:24 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210721085705.fy6hrc5n3qtlwehq@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=chris@chrisdown.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).