linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: Alex Deucher <alexander.deucher@amd.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Eric Huang <JinhuiEric.Huang@amd.com>
Subject: linux-next: manual merge of the amdgpu tree with Linus' tree
Date: Mon,  2 Aug 2021 16:10:53 +0100	[thread overview]
Message-ID: <20210802151053.14982-1-broonie@kernel.org> (raw)

Hi all,

Today's linux-next merge of the amdgpu tree got a conflict in:

  drivers/gpu/drm/amd/amdkfd/kfd_chardev.c

between commits:

  f5cc09acece4 ("Revert "drm/amdkfd: Add memory sync before TLB flush on unmap"")
  c37387c354c8 ("Revert "drm/amdkfd: Make TLB flush conditional on mapping"")
  5adcd7458a78 ("Revert "drm/amdkfd: Add heavy-weight TLB flush after unmapping"")

from Linus' tree and commits:

  b928ecfbe369 ("Revert "Revert "drm/amdkfd: Add memory sync before TLB flush on unmap""")
  b0228fa4868b ("drm/amdkfd: Only apply heavy-weight TLB flush on Aldebaran")

from the amdgpu tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

diff --cc drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
index e48acdd03c1a,86afd37b098d..000000000000
--- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
@@@ -1565,10 -1568,29 +1565,33 @@@ static int kfd_ioctl_unmap_memory_from_
  		}
  		args->n_success = i+1;
  	}
++
+ 	mutex_unlock(&p->mutex);
+ 
+ 	if (dev->device_info->asic_family == CHIP_ALDEBARAN) {
+ 		err = amdgpu_amdkfd_gpuvm_sync_memory(dev->kgd,
+ 				(struct kgd_mem *) mem, true);
+ 		if (err) {
+ 			pr_debug("Sync memory failed, wait interrupted by user signal\n");
+ 			goto sync_memory_failed;
+ 		}
+ 
+ 		/* Flush TLBs after waiting for the page table updates to complete */
+ 		for (i = 0; i < args->n_devices; i++) {
+ 			peer = kfd_device_by_id(devices_arr[i]);
+ 			if (WARN_ON_ONCE(!peer))
+ 				continue;
+ 			peer_pdd = kfd_get_process_device_data(peer, p);
+ 			if (WARN_ON_ONCE(!peer_pdd))
+ 				continue;
+ 			kfd_flush_tlb(peer_pdd, TLB_FLUSH_HEAVYWEIGHT);
+ 		}
+ 	}
++
  	kfree(devices_arr);
  
 +	mutex_unlock(&p->mutex);
 +
  	return 0;
  
  bind_process_to_device_failed:

             reply	other threads:[~2021-08-02 15:11 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02 15:10 Mark Brown [this message]
2021-08-02 15:48 ` linux-next: manual merge of the amdgpu tree with Linus' tree Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2023-11-05 22:48 Stephen Rothwell
2023-11-06 23:49 ` Stephen Rothwell
2023-07-24  1:14 Stephen Rothwell
2023-05-12  0:38 Stephen Rothwell
2022-07-19  2:00 Stephen Rothwell
2022-01-26 23:32 Stephen Rothwell
2022-01-26 23:29 Stephen Rothwell
2022-01-11 23:09 Stephen Rothwell
2021-09-02  1:22 Stephen Rothwell
2021-09-10  1:16 ` Stephen Rothwell
2021-07-06  0:52 Stephen Rothwell
2021-01-15  0:53 Stephen Rothwell
2021-01-08  1:04 Stephen Rothwell
2020-11-03  3:10 Stephen Rothwell
2020-10-27  0:48 Stephen Rothwell
2020-10-16  1:48 Stephen Rothwell
2020-08-25  1:35 Stephen Rothwell
2020-07-22  4:34 Stephen Rothwell
2020-07-23  8:01 ` Daniel Vetter
2020-07-23 13:34   ` Alex Deucher
2019-12-12  0:03 Stephen Rothwell
2019-12-12  0:11 ` Stephen Rothwell
2019-12-12  0:16 ` Timothy Pearson
2019-12-11 23:37 Stephen Rothwell
2019-12-12  0:10 ` Stephen Rothwell
2019-10-28  1:11 Stephen Rothwell
2019-10-28  1:03 Stephen Rothwell
2019-10-28  0:57 Stephen Rothwell
2019-10-28  1:13 ` Masahiro Yamada
2019-10-03  0:19 Stephen Rothwell
2019-06-17  3:12 Stephen Rothwell
2019-03-18 23:55 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210802151053.14982-1-broonie@kernel.org \
    --to=broonie@kernel.org \
    --cc=JinhuiEric.Huang@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=alexdeucher@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).