* linux-next: Fixes tag needs some work in the ntfs3 tree
@ 2021-09-20 22:31 Stephen Rothwell
2021-09-21 13:50 ` Konstantin Komarov
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2021-09-20 22:31 UTC (permalink / raw)
To: Konstantin Komarov
Cc: Kari Argillander, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 367 bytes --]
Hi all,
In commit
0412016e4807 ("fs/ntfs3: Fix wrong error message $Logfile -> $UpCase")
Fixes tag
Fixes: 203c2b3a406a ("fs/ntfs3: Add initialization of super block")
has these problem(s):
- Target SHA1 does not exist
Maybe you meant
Fixes: 82cae269cfa9 ("fs/ntfs3: Add initialization of super block")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Fixes tag needs some work in the ntfs3 tree
2021-09-20 22:31 linux-next: Fixes tag needs some work in the ntfs3 tree Stephen Rothwell
@ 2021-09-21 13:50 ` Konstantin Komarov
2021-09-21 14:29 ` Kari Argillander
2021-09-26 21:47 ` Kari Argillander
0 siblings, 2 replies; 6+ messages in thread
From: Konstantin Komarov @ 2021-09-21 13:50 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Kari Argillander, Linux Kernel Mailing List, Linux Next Mailing List
On 21.09.2021 01:31, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 0412016e4807 ("fs/ntfs3: Fix wrong error message $Logfile -> $UpCase")
>
> Fixes tag
>
> Fixes: 203c2b3a406a ("fs/ntfs3: Add initialization of super block")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: 82cae269cfa9 ("fs/ntfs3: Add initialization of super block")
>
Hello.
You are right, correct SHA is 82cae269cfa9.
Sorry, I've missed this while applying patch.
As far as I know there is no way to fix this now -
commit is already in linux-next.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Fixes tag needs some work in the ntfs3 tree
2021-09-21 13:50 ` Konstantin Komarov
@ 2021-09-21 14:29 ` Kari Argillander
2021-09-26 21:47 ` Kari Argillander
1 sibling, 0 replies; 6+ messages in thread
From: Kari Argillander @ 2021-09-21 14:29 UTC (permalink / raw)
To: Konstantin Komarov
Cc: Stephen Rothwell, Linux Kernel Mailing List, Linux Next Mailing List
On Tue, Sep 21, 2021 at 04:50:02PM +0300, Konstantin Komarov wrote:
>
>
> On 21.09.2021 01:31, Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> > 0412016e4807 ("fs/ntfs3: Fix wrong error message $Logfile -> $UpCase")
> >
> > Fixes tag
> >
> > Fixes: 203c2b3a406a ("fs/ntfs3: Add initialization of super block")
> >
> > has these problem(s):
> >
> > - Target SHA1 does not exist
> >
> > Maybe you meant
> >
> > Fixes: 82cae269cfa9 ("fs/ntfs3: Add initialization of super block")
> >
>
> Hello.
>
> You are right, correct SHA is 82cae269cfa9.
> Sorry, I've missed this while applying patch.
Sorry also from my part.
> As far as I know there is no way to fix this now -
> commit is already in linux-next.
But these things needs fixing. Rebase is needed.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Fixes tag needs some work in the ntfs3 tree
2021-09-21 13:50 ` Konstantin Komarov
2021-09-21 14:29 ` Kari Argillander
@ 2021-09-26 21:47 ` Kari Argillander
2021-09-26 22:02 ` Stephen Rothwell
1 sibling, 1 reply; 6+ messages in thread
From: Kari Argillander @ 2021-09-26 21:47 UTC (permalink / raw)
To: Konstantin Komarov
Cc: Stephen Rothwell, Linux Kernel Mailing List, Linux Next Mailing List
On Tue, Sep 21, 2021 at 04:50:02PM +0300, Konstantin Komarov wrote:
>
>
> On 21.09.2021 01:31, Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> > 0412016e4807 ("fs/ntfs3: Fix wrong error message $Logfile -> $UpCase")
> >
> > Fixes tag
> >
> > Fixes: 203c2b3a406a ("fs/ntfs3: Add initialization of super block")
> >
> > has these problem(s):
> >
> > - Target SHA1 does not exist
> >
> > Maybe you meant
> >
> > Fixes: 82cae269cfa9 ("fs/ntfs3: Add initialization of super block")
> >
>
> Hello.
>
> You are right, correct SHA is 82cae269cfa9.
> Sorry, I've missed this while applying patch.
>
> As far as I know there is no way to fix this now -
> commit is already in linux-next.
This still is not fixed. Can you Stephen verify that rebase is ok in
situatian like this? Also now we have situation that this thing is 6 day
old already. I actually also do not know if it is ok to rebase anymore,
but, probably is. I have checked every follow up patches which has been
applied after this and they are not affected if we rebase.
Argillander
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Fixes tag needs some work in the ntfs3 tree
2021-09-26 21:47 ` Kari Argillander
@ 2021-09-26 22:02 ` Stephen Rothwell
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2021-09-26 22:02 UTC (permalink / raw)
To: Kari Argillander
Cc: Konstantin Komarov, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 1461 bytes --]
Hi Kari,
On Mon, 27 Sep 2021 00:47:00 +0300 Kari Argillander <kari.argillander@gmail.com> wrote:
>
> On Tue, Sep 21, 2021 at 04:50:02PM +0300, Konstantin Komarov wrote:
> >
> > On 21.09.2021 01:31, Stephen Rothwell wrote:
> > >
> > > In commit
> > >
> > > 0412016e4807 ("fs/ntfs3: Fix wrong error message $Logfile -> $UpCase")
> > >
> > > Fixes tag
> > >
> > > Fixes: 203c2b3a406a ("fs/ntfs3: Add initialization of super block")
> > >
> > > has these problem(s):
> > >
> > > - Target SHA1 does not exist
> > >
> > > Maybe you meant
> > >
> > > Fixes: 82cae269cfa9 ("fs/ntfs3: Add initialization of super block")
> > >
> >
> > Hello.
> >
> > You are right, correct SHA is 82cae269cfa9.
> > Sorry, I've missed this while applying patch.
> >
> > As far as I know there is no way to fix this now -
> > commit is already in linux-next.
>
> This still is not fixed. Can you Stephen verify that rebase is ok in
> situatian like this? Also now we have situation that this thing is 6 day
> old already. I actually also do not know if it is ok to rebase anymore,
> but, probably is. I have checked every follow up patches which has been
> applied after this and they are not affected if we rebase.
A rebase is probably not necessary, as the commit is easy to find using
its subject line (as I did). However, it would be better to avoid such
situations in the future.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* linux-next: Fixes tag needs some work in the ntfs3 tree
@ 2022-11-13 9:49 Stephen Rothwell
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2022-11-13 9:49 UTC (permalink / raw)
To: Konstantin Komarov
Cc: Linux Kernel Mailing List, Linux Next Mailing List, Abdun Nihaal
[-- Attachment #1: Type: text/plain, Size: 319 bytes --]
Hi all,
In commit
019d22eb0eb7 ("fs/ntfs3: Validate attribute data and valid sizes")
Fixes tag
Fixes: (82cae269cfa95) fs/ntfs3: Add initialization of super block
has these problem(s):
- No SHA1 recognised
Just use
git log -1 --format='Fixes: %h ("%s")'
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-11-13 10:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-20 22:31 linux-next: Fixes tag needs some work in the ntfs3 tree Stephen Rothwell
2021-09-21 13:50 ` Konstantin Komarov
2021-09-21 14:29 ` Kari Argillander
2021-09-26 21:47 ` Kari Argillander
2021-09-26 22:02 ` Stephen Rothwell
2022-11-13 9:49 Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).