linux-next: Fixes tag needs some work in the kvm-fixes tree

linux-next: Fixes tag needs some work in the kvm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 349 bytes --]

Hi all,

In commit

  773e89ab0056 ("ptp: Fix ptp_kvm_getcrosststamp issue for x86 ptp_kvm")

Fixes tag

  Fixes: 95a3d4454bb1 ("Switch kvmclock data to a PER_CPU variable")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the kvm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

Hi all,

In commit

  e45964771007 ("x86/coco: Define cc_vendor without CONFIG_ARCH_HAS_CC_PLATFORM")

Fixes tag

  Fixes: a9ef277488cf ("x86/kvm: Fix SEV check in sev_map_percpu_data()", 2024-01-31)

has these problem(s):

  - Subject has leading but no trailing quotes
  - Subject does not match target commit subject
    Just use
        git log -1 --format='Fixes: %h ("%s")'

The date adds nothing to the Fixes tags.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the kvm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

Hi all,

In commit

  50aa870ba2f7 ("selftests: kvm: move declaration at the beginning of main()")

Fixes tag

  Fixes: a79b53aaaab5 ("KVM: x86: fix deadlock for KVM_XEN_EVTCHN_RESET", 2022-12-28)

has these problem(s):

  - Subject has leading but no trailing quotes
    Just use
	git log -1 --format='Fixes: %h ("%s")'

The date at the end does not add anything.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the kvm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 475 bytes --]

Hi all,

In commit

  23e60258aeaf ("KVM: x86/xen: Fix lockdep warning on "recursive" gpc locking")

Fixes tag

  Fixes: 5ec3289b31 ("KVM: x86/xen: Compatibility fixes for shared runstate area")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the kvm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 459 bytes --]

Hi all,

In commit

  c000a2607145 ("KVM: arm64: vgic: Fix exit condition in scan_its_table()")

Fixes tag

  Fixes: 920a7a8fa92a ("KVM: arm64: vgic-its: Add infrastructure for tableookup")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Thus:

Fixes: 920a7a8fa92a ("KVM: arm64: vgic-its: Add infrastructure for table lookup")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the kvm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

Hi all,

Commit

  42dcbe7d8bac ("KVM: x86: hyper-v: Avoid writing to TSC page without an active vCPU")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the kvm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 407 bytes --]

Hi all,

n commit

  c1be1ef1b4a7 ("Documentation: kvm: Add missing line break in api.rst")

Fixes tag

  Fixes: da40d85805937d (RISC-V: KVM: Document RISC-V specific parts of KVM API, 2021-09-27)

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

The date does not add anything.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the kvm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 606 bytes --]

Hi Wei,

On Fri, 21 Jan 2022 01:42:50 +0000 "Wang, Wei W" <wei.w.wang@intel.com> wrote:
>
> On Friday, January 21, 2022 5:15 AM, Stephen Rothwell wrote:
> > 
> > In commit
> > 
> >   1a1d1dbce6d5 ("kvm: selftests: conditionally build vm_xsave_req_perm()")
> > 
> > Fixes tag
> > 
> >   Fixes: 415a3c33e8 ("kvm: selftests: Add support for KVM_CAP_XSAVE2")  
> 
> OK, for 12 digits, it should be: 415a3c33e847
> 
> Paolo, would you like to change it directly or need me to resend the patch?

I probably doesn't need updating, just remember for next time.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: linux-next: Fixes tag needs some work in the kvm-fixes tree

[Wang, Wei W]

On Friday, January 21, 2022 5:15 AM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   1a1d1dbce6d5 ("kvm: selftests: conditionally build vm_xsave_req_perm()")
> 
> Fixes tag
> 
>   Fixes: 415a3c33e8 ("kvm: selftests: Add support for KVM_CAP_XSAVE2")

OK, for 12 digits, it should be: 415a3c33e847

Paolo, would you like to change it directly or need me to resend the patch?

Thanks,
Wei

linux-next: Fixes tag needs some work in the kvm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 452 bytes --]

Hi all,

In commit

  1a1d1dbce6d5 ("kvm: selftests: conditionally build vm_xsave_req_perm()")

Fixes tag

  Fixes: 415a3c33e8 ("kvm: selftests: Add support for KVM_CAP_XSAVE2")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed in the future by setting core.abbrev to 12 (or more) or
    (for git v2.11 or later) just making sure it is not set (or set to
    "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 484 bytes --]

linux-next: Fixes tag needs some work in the kvm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

Hi all,

In commit

  ef8b4b720368 ("KVM: ensure APICv is considered inactive if there is no APIC")

Fixes tag

  Fixes: ee49a8932971 ("KVM: x86: Move SVM's APICv sanity check to common x86", 2021-10-22)

has these problem(s):

  - Subject has leading but no trailing quotes
  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Adding the date to Fixes tags adds nothing.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the kvm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

Hi all,

In commit

  a31a01172ebf ("cpuid: kvm_find_kvm_cpuid_features() should be declared 'static'")

Fixes tag

  Fixes: 17cd23d68fdf ("KVM: x86: Make sure KVM_CPUID_FEATURES really are KVM_CPUID_FEATURES")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 760849b1476c ("KVM: x86: Make sure KVM_CPUID_FEATURES really are KVM_CPUID_FEATURES")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the kvm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 733 bytes --]

Hi all,

In commit

  5b92b6ca92b6 ("KVM: SEV: Allow some commands for mirror VM")

Fixes tag

  Fixes: 54526d1fd593 ("KVM: x86: Support KVM VMs sharing SEV context", 2021-04-21)

has these problem(s):

  - Subject has leading but no trailing quotes
    Just use
	git log -1 --format='Fixes: %h ("%s")'

In commit

  f43c887cb7cb ("KVM: SEV: Update svm_vm_copy_asid_from for SEV-ES")

Fixes tag

  Fixes: 54526d1fd593 ("KVM: x86: Support KVM VMs sharing SEV context", 2021-04-21)

has these problem(s):

  - Subject has leading but no trailing quotes
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Do not include the date part in a fixes tag.  It adds nothing.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the kvm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 522 bytes --]

Hi all,

In commit

  23fa2e46a555 ("KVM: mmio: Fix use-after-free Read in kvm_vm_ioctl_unregister_coalesced_mmio")

Fixes tag

  Fixes: 5d3c4c79384a ("KVM: Stop looking for coalesced MMIO zones if the bus is destroyed", 2021-04-20)

has these problem(s):

  - Subject has leading but no trailing quotes
  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

The date does not add any useful information to the Fixes tag.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the kvm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 523 bytes --]

Hi all,

In commit

  1c017567ae24 ("KVM: X86: hyper-v: Task srcu lock when accessing kvm_memslots()")

Fixes tag

  Fixes: e880c6ea5 (KVM: x86: hyper-v: Prevent using not-yet-updated TSC page by secondary CPUs)

has these problem(s):

  - SHA1 should be at least 12 digits long

Probably not worth rebasing to fix, but this can be avoided in the
future by setting core.abbrev to 12 (or more) or (for git v2.11 or later)
just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the kvm-fixes tree

[Maxim Levitsky]

On Mon, 2020-11-09 at 08:14 +1100, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   cc4cb017678a ("KVM: x86: use positive error values for msr emulation that causes #GP")
> 
> Fixes tag
> 
>   Fixes: 291f35fb2c1d1 ("KVM: x86: report negative values from wrmsr emulation to userspace")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: 7dffecaf4eab ("KVM: x86: report negative values from wrmsr emulation to userspace")
> 

This is true. Looks like one of my local commits slipped though.
Next time I'll check this more carefully.

Can this be fixed or is it too late?

Best regards,
	Maxim Levitsky

linux-next: Fixes tag needs some work in the kvm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

Hi all,

In commit

  cc4cb017678a ("KVM: x86: use positive error values for msr emulation that causes #GP")

Fixes tag

  Fixes: 291f35fb2c1d1 ("KVM: x86: report negative values from wrmsr emulation to userspace")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 7dffecaf4eab ("KVM: x86: report negative values from wrmsr emulation to userspace")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the kvm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 427 bytes --]

Hi all,

In commit

  c6b177a3beb9 ("KVM: nVMX: Fix the update value of nested load IA32_PERF_GLOBAL_CTRL control")

Fixes tag

  Fixes: 03a8871add95 ("KVM: nVMX: Expose load IA32_PERF_GLOBAL_CTRL

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the kvm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 435 bytes --]

Hi all,

In commit

  f4cfcd2d5aea ("KVM: x86: don't expose MSR_IA32_UMWAIT_CONTROL unconditionally")

Fixes tag

  Fixes: 6e3ba4abce ("KVM: vmx: Emulate MSR IA32_UMWAIT_CONTROL")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the kvm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 502 bytes --]

Hi all,

In commit

  637543a8d61c ("KVM: x86: Fixes posted interrupt check for IRQs delivery modes")

Fixes tag

  Fixes: (fdcf75621375 'KVM: x86: Disable posted interrupts for non-standard IRQs delivery modes')

has these problem(s):

  - No SHA1 recognised

It should just be

Fixes: fdcf75621375 ("KVM: x86: Disable posted interrupts for non-standard IRQs delivery modes")

as generated by

git log -1 --format='Fixes: %h ("%s")' fdcf75621375

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the kvm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

Hi all,

In commit

  d012a06ab1d2 ("Revert "KVM: x86/mmu: Zap only the relevant pages when removing a memslot"")

Fixes tag

  Fixes: 4e103134b862 ("KVM: x86/mmu: Zap only the relevant pages when removing a memslot", 2019-02-05)

has these problem(s):

  - The trailing date is unexpected
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the kvm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 402 bytes --]

Hi all,

In commit

  e8ab8d24b488 ("KVM: nVMX: Fix size checks in vmx_set_nested_state")

Fixes tag

  Fixes: 8fcc4b5923af5de58b80b53a069453b135693304

has these problem(s):

  - missing subject

Did you mean

Fixes: 8fcc4b5923af ("kvm: nVMX: Introduce KVM_CAP_NESTED_STATE")

You can just use:

  git log -1 --format='Fixes: %h ("%s")' <commit>

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the kvm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

Hi all,

In commit

  76d58e0f07ec ("KVM: fix KVM_CLEAR_DIRTY_LOG for memory slots of unaligned size")

Fixes tag

  Fixes: 98938aa8edd6 ("KVM: validate userspace input in kvm_clear_dirty_log_protect()", 2019-01-02)

has these problem(s):

  - The trailing date ine the fixes tag is unexpected
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the kvm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

Hi all,

In commit

  345077c8e172 ("KVM: PPC: Book3S: Protect memslots while validating user address")

Fixes tag

  Fixes: 42de7b9e2167 ("KVM: PPC: Validate TCEs against preregistered memory page sizes", 2018-09-10)

has these problem(s):

  - the ", 2018-09-10" is unexpected in a Fixes tag
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]