linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
	Jackie Liu <liu.yun@linux.dev>
Subject: Re: linux-next: Tree for Oct 5 (warnings: a. trace; b. mm/migrate)
Date: Wed, 6 Oct 2021 21:10:00 -0400	[thread overview]
Message-ID: <20211006211000.16b2284b@rorschach.local.home> (raw)
In-Reply-To: <6d8f22a1-5f54-aa2a-7628-1d98a7f0fb95@infradead.org>

On Wed, 6 Oct 2021 14:32:21 -0700
Randy Dunlap <rdunlap@infradead.org> wrote:

> On 10/6/21 2:22 PM, Steven Rostedt wrote:
> > On Tue, 5 Oct 2021 13:46:52 -0700
> > Randy Dunlap <rdunlap@infradead.org> wrote:
> >   
> >> a. randconfig: KCONFIG_SEED=0xBFBEA13C
> >> ../kernel/trace/trace.c:1712:13: error: 'trace_create_maxlat_file' defined but not used [-Werror=unused-function]
> >>    static void trace_create_maxlat_file(struct trace_array *tr,  
> > 
> > Does this fix it?
> > 
> > -- Steve  
> 
> Yes, thanks.
> 
> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

Plumbers followed by Open Source Summit totally blew my brain cache. I
have a fix for this in my queue from Jackie Liu that I haven't
processed yet (just going through my queue now when I noticed it).

Can you test this patch instead?

   https://lore.kernel.org/r/20210922025122.3268022-1-liu.yun@linux.dev

Thanks!

-- Steve


> 
> 
> > 
> > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> > index 7896d30d90f7..4520cbab0da5 100644
> > --- a/kernel/trace/trace.c
> > +++ b/kernel/trace/trace.c
> > @@ -1744,16 +1744,15 @@ void latency_fsnotify(struct trace_array *tr)
> >   	irq_work_queue(&tr->fsnotify_irqwork);
> >   }
> >   
> > -/*
> > - * (defined(CONFIG_TRACER_MAX_TRACE) || defined(CONFIG_HWLAT_TRACER)) && \
> > - *  defined(CONFIG_FSNOTIFY)
> > - */
> > -#else
> > +/* CONFIG_FSNOTIFY else */
> > +#elif CREATE_MAX_TRACE_FILE
> >   
> >   #define trace_create_maxlat_file(tr, d_tracer)				\
> >   	trace_create_file("tracing_max_latency", 0644, d_tracer,	\
> >   			  &tr->max_latency, &tracing_max_lat_fops)
> >   
> > +#else
> > +#define trace_create_maxlat_file(tr, d_tracer) do { } while (0)
> >   #endif
> >   
> >   #ifdef CONFIG_TRACER_MAX_TRACE
> > @@ -9473,9 +9472,7 @@ init_tracer_tracefs(struct trace_array *tr, struct dentry *d_tracer)
> >   
> >   	create_trace_options_dir(tr);
> >   
> > -#if defined(CONFIG_TRACER_MAX_TRACE) || defined(CONFIG_HWLAT_TRACER)
> >   	trace_create_maxlat_file(tr, d_tracer);
> > -#endif
> >   
> >   	if (ftrace_create_function_files(tr, d_tracer))
> >   		MEM_FAIL(1, "Could not allocate function filter files");
> > diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h
> > index b7c0f8e160fb..680935949aef 100644
> > --- a/kernel/trace/trace.h
> > +++ b/kernel/trace/trace.h
> > @@ -679,8 +679,11 @@ void update_max_tr_single(struct trace_array *tr,
> >   #endif /* CONFIG_TRACER_MAX_TRACE */
> >   
> >   #if (defined(CONFIG_TRACER_MAX_TRACE) || defined(CONFIG_HWLAT_TRACER) \
> > -	|| defined(CONFIG_OSNOISE_TRACER)) && defined(CONFIG_FSNOTIFY)
> > -#define LATENCY_FS_NOTIFY
> > +	|| defined(CONFIG_OSNOISE_TRACER))
> > +# define CREATE_MAX_TRACE_FILE
> > +# ifdef CONFIG_FSNOTIFY
> > +#  define LATENCY_FS_NOTIFY
> > +# endif
> >   #endif
> >   
> >   #ifdef LATENCY_FS_NOTIFY
> >   
> 
> 


  parent reply	other threads:[~2021-10-07  1:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-05  8:06 linux-next: Tree for Oct 5 Stephen Rothwell
2021-10-05 20:46 ` linux-next: Tree for Oct 5 (warnings: a. trace; b. mm/migrate) Randy Dunlap
2021-10-06 14:52   ` Dave Hansen
2021-10-06 14:56     ` Steven Rostedt
2021-10-06 16:39       ` Randy Dunlap
2021-10-06 18:16         ` Dave Hansen
2021-10-06 16:33     ` Randy Dunlap
2021-10-06 21:22   ` Steven Rostedt
2021-10-06 21:32     ` Randy Dunlap
2021-10-06 22:06       ` Steven Rostedt
2021-10-07  1:10       ` Steven Rostedt [this message]
2021-10-07  3:13         ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211006211000.16b2284b@rorschach.local.home \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-next@vger.kernel.org \
    --cc=liu.yun@linux.dev \
    --cc=rdunlap@infradead.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).