From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CF27C433F5 for ; Thu, 28 Oct 2021 09:24:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 06EE9610FC for ; Thu, 28 Oct 2021 09:24:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230071AbhJ1J0v (ORCPT ); Thu, 28 Oct 2021 05:26:51 -0400 Received: from elvis.franken.de ([193.175.24.41]:45139 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229626AbhJ1J0v (ORCPT ); Thu, 28 Oct 2021 05:26:51 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1mg1dv-0002j1-00; Thu, 28 Oct 2021 11:24:15 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id ED26FC2770; Thu, 28 Oct 2021 11:23:18 +0200 (CEST) Date: Thu, 28 Oct 2021 11:23:18 +0200 From: Thomas Bogendoerfer To: Sergio Paracuellos Cc: Yanteng Si , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, Yanteng Si , Stephen Rothwell , Lorenzo Pieralisi , Rob Herring , kw@linux.com, Bjorn Helgaas , Matthias Brugger , Philipp Zabel , linux-pci , linux-arm-kernel@lists.infradead.org, "moderated list:ARM/Mediatek SoC support" , "open list:MIPS" , chenhuacai@kernel.org, sterlingteng@gmail.com, Linux Next Mailing List Subject: Re: [PATCH v2 2/3] MIPS: cm/cpc: export some missing symbols to be able to use them from driver code Message-ID: <20211028092318.GA6574@alpha.franken.de> References: <112fea0c8c1b65a762ac98412216239160721263.1635390750.git.siyanteng@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Thu, Oct 28, 2021 at 06:11:18AM +0200, Sergio Paracuellos wrote: > On Thu, Oct 28, 2021 at 6:05 AM Yanteng Si wrote: > > > > Since commit 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver") > > the MT7621 PCIe host controller driver is built as a module but modpost complains once these > > drivers become modules. > > > > ERROR: modpost: "mips_cm_unlock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > ERROR: modpost: "mips_cpc_base" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > ERROR: modpost: "mips_cm_lock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > ERROR: modpost: "mips_cm_is64" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > ERROR: modpost: "mips_gcr_base" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > > > Let's just export them. > > > > Signed-off-by: Yanteng Si > > --- > > arch/mips/kernel/mips-cm.c | 5 +++++ > > arch/mips/kernel/mips-cpc.c | 1 + > > 2 files changed, 6 insertions(+) > > > > Reviewed-by: Sergio Paracuellos could we instead make the pcie-mt761 driver non modular ? Exporting all MIPS specific stuff for just making an essential driver modular doesn't IMHO make much sense. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]