Hi, On Tue, Nov 23, 2021 at 10:27:17AM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the sunxi tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/clk/sunxi-ng/ccu-suniv-f1c100s.c: In function 'suniv_f1c100s_ccu_setup': > drivers/clk/sunxi-ng/ccu-suniv-f1c100s.c:532:39: error: 'pdev' undeclared (first use in this function) > 532 | reg = devm_platform_ioremap_resource(pdev, 0); > | ^~~~ > drivers/clk/sunxi-ng/ccu-suniv-f1c100s.c:532:39: note: each undeclared identifier is reported only once for each function it appears in > drivers/clk/sunxi-ng/ccu-suniv-f1c100s.c:534:10: error: 'return' with a value, in function returning void [-Werror=return-type] > 534 | return PTR_ERR(reg); > | ^~~~~~~~~~~~ > drivers/clk/sunxi-ng/ccu-suniv-f1c100s.c:526:20: note: declared here > 526 | static void __init suniv_f1c100s_ccu_setup(struct device_node *node) > | ^~~~~~~~~~~~~~~~~~~~~~~ > drivers/clk/sunxi-ng/ccu-suniv-f1c100s.c:543:10: error: 'return' with a value, in function returning void [-Werror=return-type] > 543 | return ret; > | ^~~ > drivers/clk/sunxi-ng/ccu-suniv-f1c100s.c:526:20: note: declared here > 526 | static void __init suniv_f1c100s_ccu_setup(struct device_node *node) > | ^~~~~~~~~~~~~~~~~~~~~~~ > drivers/clk/sunxi-ng/ccu-suniv-f1c100s.c:552:9: error: 'return' with a value, in function returning void [-Werror=return-type] > 552 | return 0; > | ^ > drivers/clk/sunxi-ng/ccu-suniv-f1c100s.c:526:20: note: declared here > 526 | static void __init suniv_f1c100s_ccu_setup(struct device_node *node) > | ^~~~~~~~~~~~~~~~~~~~~~~ > drivers/clk/sunxi-ng/ccu-suniv-f1c100s.c: At top level: > drivers/clk/sunxi-ng/ccu-suniv-f1c100s.c:561:11: error: 'suniv_f1c100s_ccu_probe' undeclared here (not in a function); did you mean 'suniv_f1c100s_ccu_driver'? > 561 | .probe = suniv_f1c100s_ccu_probe, > | ^~~~~~~~~~~~~~~~~~~~~~~ > | suniv_f1c100s_ccu_driver > drivers/clk/sunxi-ng/ccu-suniv-f1c100s.c:526:20: error: 'suniv_f1c100s_ccu_setup' defined but not used [-Werror=unused-function] > 526 | static void __init suniv_f1c100s_ccu_setup(struct device_node *node) > | ^~~~~~~~~~~~~~~~~~~~~~~ > > Caused by commit > > 72dc8e122383 ("clk: sunxi-ng: Convert early providers to platform drivers") > > I have used the sunxi tree from next-20211118 for today. I fixed it and pushed to the sunxi tree, it should be good tomorrow Thanks! Maxime