From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ACADC433F5 for ; Mon, 31 Jan 2022 21:06:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344277AbiAaVGI (ORCPT ); Mon, 31 Jan 2022 16:06:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343693AbiAaVGI (ORCPT ); Mon, 31 Jan 2022 16:06:08 -0500 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57381C061714 for ; Mon, 31 Jan 2022 13:06:08 -0800 (PST) Received: by mail-pj1-x102f.google.com with SMTP id qe6-20020a17090b4f8600b001b7aaad65b9so355895pjb.2 for ; Mon, 31 Jan 2022 13:06:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=SU2C5Ut+6pVhWNusD7rQJSCoDPKXcj6KPViieB+X2lo=; b=hoQPs3vvKd7f1xYDysO+MqUCq4Iv27DRIoE1LCB2rYcxtJxZsOpFbFs/dzUF4N+KB7 YOvrYpJQ6TEndtT426TWvnQaEdc8kuPAvKL1ohdSugHUSz5qDExR/NXy0vXMuNI258E+ TfjMsP0xEQN9+BRl5R2eCk8q0PFJoH0jSWOzU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=SU2C5Ut+6pVhWNusD7rQJSCoDPKXcj6KPViieB+X2lo=; b=1jAeOgB1ffRZRJh5mMSIJdEptNBS635Lppw9t8iepCdmrOkN7PtYVd/U93tUZRq5VQ WEXNggAecz+P8sne/+StO/+vHHiTh6irafvfx4fMSoHiQYYWAbiCvh0kw706SKbKNGud BYrCyvYccqRqzvKIb8V9Xp4I/vKGLnHjUB4q2pKAUqzNXEJZZ23hl7NFrn55eIY6aIfb nA8AwmpITQduiDE+IkdmS2ECK8mriLQeehdioDVq5fRzYvdxtLOYWiQs9f0O8YwF+Igx VpJitn/PNuq/BM+u0Amj4HKFgsQ3y1g7PkGM5GalSnfwedhShNJCuLFendJ+xocTVGoC 5ong== X-Gm-Message-State: AOAM530X/huF1hWua3R96ofxEpjI05kzJJqz7DCghVSoXgVJUPrvAvlz VNFNC6drTtgrQkVcoWk52aia7A== X-Google-Smtp-Source: ABdhPJw3mk7g/0+d8ppkglsn7LnLQZW0nlmnZxQQxVqkVpoCYTS2/ssuThB0561M1pMoYV+W9kT4YA== X-Received: by 2002:a17:902:c215:: with SMTP id 21mr21063159pll.134.1643663167174; Mon, 31 Jan 2022 13:06:07 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id z6sm5913634pfb.171.2022.01.31.13.06.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 13:06:06 -0800 (PST) Date: Mon, 31 Jan 2022 13:06:06 -0800 From: Kees Cook To: Saeed Mahameed Cc: Stephen Rothwell , "David S. Miller" , Leon Romanovsky , Linux Kernel Mailing List , Linux Next Mailing List , Jakub Kicinski Subject: Re: linux-next: build failure after merge of the kspp tree Message-ID: <202201311300.39BE058A1@keescook> References: <20220131100954.74a2034f@canb.auug.org.au> <202201302002.41A8DDA2@keescook> <20220131155932.3f88ec71@canb.auug.org.au> <202201302216.97F2691@keescook> <20220131191019.fpa5sn5u4kuov5ub@sx1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220131191019.fpa5sn5u4kuov5ub@sx1> Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Mon, Jan 31, 2022 at 11:10:19AM -0800, Saeed Mahameed wrote: > On 30 Jan 22:19, Kees Cook wrote: > > On Mon, Jan 31, 2022 at 03:59:32PM +1100, Stephen Rothwell wrote: > > > On Sun, 30 Jan 2022 20:04:00 -0800 Kees Cook wrote: > > > > https://lore.kernel.org/linux-hardening/20220124172242.2410996-1-keescook@chromium.org/ Fixes: 34802a42b352 ("net/mlx5e: Do not modify the TX SKB") > > > > https://lore.kernel.org/linux-hardening/20220124172028.2410761-1-keescook@chromium.org/ Fixes: b5503b994ed5 ("net/mlx5e: XDP TX forwarding support") > > > yeah, neither has made it yet. However, it would not have helped as I > > > am merging the kspp tree very early so that new bugs get fixed in the > > > trees that introduce them. These 2 are in Linus tree (for a long time) > > > and so it would be better if these fixes went int the net tree and then > > > Linus' tree as bug fixes. > > I need proper fixes tags to submit to net, can you provide ? Sure! See above. > another option is to use a shared branch with those fixes and pull it to > both net-next and kspp. It's just a handful left now, so I think we'll avoid this for now. Thanks! -- Kees Cook