linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the vhost tree
Date: Mon, 7 Mar 2022 04:17:39 -0500	[thread overview]
Message-ID: <20220307040734-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1646635600.9436276-1-xuanzhuo@linux.alibaba.com>

On Mon, Mar 07, 2022 at 02:46:40PM +0800, Xuan Zhuo wrote:
> On Mon, 7 Mar 2022 15:40:11 +1100, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > Hi all,
> >
> > After merging the vhost tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> >
> > drivers/net/virtio_net.c: In function 'virtnet_rx_vq_reset':
> > drivers/net/virtio_net.c:1823:63: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'int' [-Wformat=]
> >  1823 |                    "reset rx reset vq fail: rx queue index: %ld err: %d\n",
> >       |                                                             ~~^
> >       |                                                               |
> >       |                                                               long int
> >       |                                                             %d
> >  1824 |                    rq - vi->rq, err);
> >       |                    ~~~~~~~~~~~
> >       |                       |
> >       |                       int
> > drivers/net/virtio_net.c: In function 'virtnet_tx_vq_reset':
> > drivers/net/virtio_net.c:1873:63: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'int' [-Wformat=]
> >  1873 |                    "reset tx reset vq fail: tx queue index: %ld err: %d\n",
> >       |                                                             ~~^
> >       |                                                               |
> >       |                                                               long int
> >       |                                                             %d
> >  1874 |                    sq - vi->sq, err);
> >       |                    ~~~~~~~~~~~
> >       |                       |
> >       |                       int
> >
> > Introduced by commit
> >
> >   920ee0c540a2 ("virtio_net: support rx/tx queue reset")
> >
> 
> 
> Can you help me test this patch? I don't have an arm environment around me.
> 
> Thanks


You should at least use
https://mirrors.edge.kernel.org/pub/tools/crosstool/
to test-build + test on x86.

> 
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 1fa2d632a994..4d629d1ea894 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -1820,7 +1820,7 @@ static int virtnet_rx_vq_reset(struct virtnet_info *vi,
> 
>  err:
>         netdev_err(vi->dev,
> -                  "reset rx reset vq fail: rx queue index: %ld err: %d\n",
> +                  "reset rx reset vq fail: rx queue index: %td err: %d\n",
>                    rq - vi->rq, err);
>         virtnet_napi_enable(rq->vq, &rq->napi);
>         return err;
> @@ -1870,7 +1870,7 @@ static int virtnet_tx_vq_reset(struct virtnet_info *vi,
> 
>  err:
>         netdev_err(vi->dev,
> -                  "reset tx reset vq fail: tx queue index: %ld err: %d\n",
> +                  "reset tx reset vq fail: tx queue index: %td err: %d\n",
>                    sq - vi->sq, err);
>         virtnet_napi_tx_enable(vi, sq->vq, &sq->napi);
>         return err;
> 
> > --
> > Cheers,
> > Stephen Rothwell
> >


  reply	other threads:[~2022-03-07  9:17 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-07  4:40 linux-next: build warning after merge of the vhost tree Stephen Rothwell
2022-03-07  6:46 ` Xuan Zhuo
2022-03-07  9:17   ` Michael S. Tsirkin [this message]
2022-03-07  9:41     ` Xuan Zhuo
2022-03-07 10:12   ` Stephen Rothwell
2022-03-07 11:00     ` Michael S. Tsirkin
2022-03-09  6:13       ` Stephen Rothwell
2022-03-09  6:15         ` Xuan Zhuo
2022-03-09  6:30           ` Xuan Zhuo
  -- strict thread matches above, loose matches on Subject: below --
2024-02-23  4:10 Stephen Rothwell
2023-03-22  1:32 Stephen Rothwell
2023-03-22  2:24 ` Michael S. Tsirkin
2022-12-19 23:59 Stephen Rothwell
2022-12-20  6:01 ` Michael S. Tsirkin
2022-12-20  7:04   ` Ricardo Cañuelo
2022-08-11  1:59 Stephen Rothwell
2022-08-11  6:45 ` Ricardo Cañuelo
2021-07-06  2:37 Stephen Rothwell
2020-06-09  3:25 Stephen Rothwell
2019-12-16  3:49 Stephen Rothwell
2019-11-15  4:36 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220307040734-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).