Hi Maciej, On Thu, 21 Apr 2022 15:21:25 +0200 Maciej Fijalkowski wrote: > > Intel drivers translate actions returned from XDP programs to their own > return codes that have the following mapping: > > XDP_REDIRECT -> IXGBE_XDP_{REDIR,CONSUMED} > XDP_TX -> IXGBE_XDP_{TX,CONSUMED} > XDP_DROP -> IXGBE_XDP_CONSUMED > XDP_ABORTED -> IXGBE_XDP_CONSUMED > XDP_PASS -> IXGBE_XDP_PASS > > Commit c7dd09fd4628 ("ixgbe, xsk: Terminate Rx side of NAPI when XSK Rx > queue gets full") introduced new translation > > XDP_REDIRECT -> IXGBE_XDP_EXIT > > which is set when XSK RQ gets full and to indicate that driver should > stop further Rx processing. This happens for unsuccessful > xdp_do_redirect() so it is valuable to call trace_xdp_exception() for > this case. In order to avoid IXGBE_XDP_EXIT -> IXGBE_XDP_CONSUMED > overwrite, XDP_DROP case was moved above which in turn made the > 'fallthrough' that is in XDP_ABORTED useless as it became the last label > in the switch statement. > > Simply drop this leftover. > > Fixes: c7dd09fd4628 ("ixgbe, xsk: Terminate Rx side of NAPI when XSK Rx queue gets full") > Signed-off-by: Maciej Fijalkowski Reported-by ? -- Cheers, Stephen Rothwell