From: Fabien Parent <fparent@baylibre.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the input tree
Date: Wed, 27 Apr 2022 09:41:34 +0200 [thread overview]
Message-ID: <20220427074134.loyovm6xpbfw6y7d@radium> (raw)
In-Reply-To: <YmjyPSliv+WncweU@google.com>
[-- Attachment #1: Type: text/plain, Size: 2287 bytes --]
On Wed, Apr 27, 2022 at 08:35:25AM +0100, Lee Jones wrote:
> On Wed, 27 Apr 2022, Fabien Parent wrote:
>
> > Hi,
> >
> > On Wed, Apr 27, 2022 at 10:48:25AM +1000, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > After merging the input tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > >
> > > drivers/input/keyboard/mtk-pmic-keys.c:93:36: error: 'MT6359_TOPSTATUS' undeclared here (not in a function); did you mean 'MT6358_TOPSTATUS'?
> > > 93 | MTK_PMIC_KEYS_REGS(MT6359_TOPSTATUS,
> > > | ^~~~~~~~~~~~~~~~
> > > drivers/input/keyboard/mtk-pmic-keys.c:48:35: note: in definition of macro 'MTK_PMIC_KEYS_REGS'
> > > 48 | .deb_reg = _deb_reg, \
> > > | ^~~~~~~~
> > > drivers/input/keyboard/mtk-pmic-keys.c:98:25: error: 'MT6359_TOP_RST_MISC' undeclared here (not in a function); did you mean 'MT6358_TOP_RST_MISC'?
> > > 98 | .pmic_rst_reg = MT6359_TOP_RST_MISC,
> > > | ^~~~~~~~~~~~~~~~~~~
> > > | MT6358_TOP_RST_MISC
> > >
> > > Caused by commit
> > >
> > > 0f97adf64314 ("Input: mtk-pmic-keys - add support for MT6359")
> > >
> > > I have used the input tree from next-20220426 for today.
> >
> > The commit is depending on another commit from the same patch serie: [0]. That
> > patch has been merged in the tree of the MFD maintainer: [1].
> >
> > [0] https://lore.kernel.org/all/20220426135313.245466-3-fparent@baylibre.com/
> > [1] https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/log/?h=for-mfd-next
>
> Looks like you only sent me 2 of the 8 patches in the set.
>
> In future, if there are dependencies between patches, you must send
> all of the patches to everyone. That way, we can organise a merge
> strategy that does not break -next, or worse Mainline during the
> merge-window.
Understood. Thanks for the info, I will make sure next time to include
everyone in such situation.
>
> --
> Lee Jones [李琼斯]
> Principal Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-04-27 7:41 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 0:48 linux-next: build failure after merge of the input tree Stephen Rothwell
2022-04-27 6:53 ` Fabien Parent
2022-04-27 7:35 ` Lee Jones
2022-04-27 7:41 ` Fabien Parent [this message]
2022-05-02 2:17 ` Stephen Rothwell
2022-05-06 0:25 ` Dmitry Torokhov
2022-05-31 10:13 ` Fabien Parent
-- strict thread matches above, loose matches on Subject: below --
2022-10-24 23:00 Stephen Rothwell
2022-10-25 5:02 ` Dmitry Torokhov
2022-08-17 0:00 Stephen Rothwell
2022-08-17 0:07 ` Stephen Rothwell
2022-08-17 4:43 ` Uwe Kleine-König
2022-08-01 21:44 broonie
2022-08-04 12:33 ` Mark Brown
2022-08-04 23:36 ` Jiri Kosina
2020-03-25 7:16 Stephen Rothwell
2020-03-31 21:06 ` Stephen Rothwell
2015-10-16 2:19 Stephen Rothwell
2015-10-16 7:37 ` Hans de Goede
2015-10-17 16:39 ` Dmitry Torokhov
2015-07-24 1:49 Stephen Rothwell
2015-07-24 2:33 ` Dmitry Torokhov
2012-10-05 1:47 Stephen Rothwell
2012-10-05 6:12 ` Dmitry Torokhov
2012-01-24 3:25 Stephen Rothwell
2012-01-24 6:59 ` Dmitry Torokhov
2012-01-24 23:16 ` John Stultz
2010-08-19 1:35 Stephen Rothwell
2010-08-19 5:19 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220427074134.loyovm6xpbfw6y7d@radium \
--to=fparent@baylibre.com \
--cc=dmitry.torokhov@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).