From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F6FEC433F5 for ; Fri, 6 May 2022 01:05:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236922AbiEFBJW (ORCPT ); Thu, 5 May 2022 21:09:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232783AbiEFBJV (ORCPT ); Thu, 5 May 2022 21:09:21 -0400 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26EA825C61; Thu, 5 May 2022 18:05:39 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4KvXS13JQfz4x7V; Fri, 6 May 2022 11:05:37 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canb.auug.org.au; s=201702; t=1651799137; bh=wJ89nCnpERmW1YfiR7PVKkGj17pYMLzirbJ4W1FJCms=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rNt4YQRS+bCh1NzVaXqmi6FO4RnswoXhM2yza9WfSbxj3fv5pBaAg0gOsOP98wCk+ UCX5iWF/NH61mEHFhoV3Xndidbz4HmwuyJRXqqc8hDpbescj5S/EapslRhb4rTDsob V0xrFjKrI4L06/yQb7Ko7Pi1AlGKd0E5gLYU88EG+2W7JxVRGXQtUh/uhujRQcgK0R DDeYf/ulALqfLEHi8C6gT6rkkTUPZGEH9UB/O2KY5XHda8sLwi0x9durlnErI6H/gy 1gzMHac2zd+NgsQyhshhaxhYW5TKgq9Ho7yc+H/ID0O4XpXmShcsWTECI97vdba8DQ UpWKe1liLZDmA== Date: Fri, 6 May 2022 11:05:36 +1000 From: Stephen Rothwell To: Alex Deucher Cc: Nathan Chancellor , Jack Xiao , Linux Kernel Mailing List , Linux Next Mailing List Subject: Re: linux-next: build failure after merge of the amdgpu tree Message-ID: <20220506110536.2dd76d22@canb.auug.org.au> In-Reply-To: References: <20220505194717.065db7ab@canb.auug.org.au> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/C19o9.xD7PvLJX+FrXQ8RY3"; protocol="application/pgp-signature"; micalg=pgp-sha256 Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org --Sig_/C19o9.xD7PvLJX+FrXQ8RY3 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi all, On Thu, 5 May 2022 14:46:25 -0400 Alex Deucher wrot= e: > > On Thu, May 5, 2022 at 2:12 PM Nathan Chancellor wrot= e: > > > > This fixup makes CONFIG_DRM_AMDGPU unselectable on any architecture that > > does not have CONFIG_CPU_LITTLE_ENDIAN, such as x86_64. I was rather > > surprised when my AMD test system did not reach the login screen and > > there were no error messages in dmesg, only to find that > > CONFIG_DRM_AMDGPU had disappeared from my build. > > > > If this is not fixed by the time you do next-20220506, would you > > consider swapping the logic like so? This should allow all implicitly > > little endian architectures to work (at least, I tested it with x86_64), > > while preventing errors for CONFIG_CPU_BIG_ENDIAN configurations. =20 >=20 > This is fixed. Will push out a new branch shortly. >=20 > > > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > > index 2aaa9ef1168d..a57843733a96 100644 > > --- a/drivers/gpu/drm/Kconfig > > +++ b/drivers/gpu/drm/Kconfig > > @@ -244,7 +244,7 @@ source "drivers/gpu/drm/radeon/Kconfig" > > config DRM_AMDGPU > > tristate "AMD GPU" > > depends on DRM && PCI && MMU > > - depends on CPU_LITTLE_ENDIAN > > + depends on !CPU_BIG_ENDIAN > > select FW_LOADER > > select DRM_DISPLAY_DP_HELPER > > select DRM_DISPLAY_HDMI_HELPER =20 Since today's amdgpu tree is broken, I have used the above with yesterday's tree. --=20 Cheers, Stephen Rothwell --Sig_/C19o9.xD7PvLJX+FrXQ8RY3 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmJ0dGAACgkQAVBC80lX 0GyOygf/YwfXGwiME67/MLQ0YPLb3ZLCFTmpFyycG3L75rf5C4wW8OcJ5ZZ5hrY7 5mtieIOQaGVW8Oepi7VY5UJZIGqmIII3vmFXDGVnd6tJJVAXdeYJCQixWizuv4Pf y4pKZgh/wQot2fnigge/GkvHm2Q0/x4lANe8YPF1t5QojULi7hDpjirKDvSjlf8P SbqajUKBM+IIGl8JCEvnLcCFY7Kps4nSoIWF3cv2E8RGHqjqCzjWSe6ejcxKoD6V josGqGiW9QuqO7RhK5nxh3s4b8lJUdN4GgQyOIygWVauMUfYFFVyjjB98CBO9GJM P4N3xz0i1trQQXhp2d0VqAGJ6kLQpQ== =AOtX -----END PGP SIGNATURE----- --Sig_/C19o9.xD7PvLJX+FrXQ8RY3--