linux-next: Fixes tag needs some work in the tip tree

linux-next: Fixes tag needs some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 450 bytes --]

Hi all,

In commit

  9c2136be0878 ("sched/tracing: Append prev_state to tp args instead")

Fixes tag

  Fixes: fa2c3254d7cf (sched/tracing: Don't re-read p->state when emitting sched_switch event, 2022-01-20)

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Please do not include the date part.  I doesn't add anything.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the tip tree

[Thomas Gleixner]

On Fri, Mar 15 2024 at 08:09, Stephen Rothwell wrote:
>   4ce937160ba0 ("irqchip/riscv-intc: Fix use of AIA interrupts 32-63 on riscv32")
>
> Fixes tags
>
>   Fixes: bb7921cdea12 ("irqchip/riscv-intc: Add support for RISC-V AIA")
>   Fixes: e6bd9b966dc8 ("irqchip/riscv-intc: Fix low-level interrupt handler setup for AIA")
>
> have this problem:
>
>   - Target SHA1s do not exist
>
> Maybe you meant
>
> Fixes: 3c46fc5b5507 ("irqchip/riscv-intc: Add support for RISC-V AIA")
> Fixes: 678c607ecf8a ("irqchip/riscv-intc: Fix low-level interrupt handler setup for AIA")

Indeed. Fixed now.

Thanks

        tglx

linux-next: Fixes tag needs some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 563 bytes --]

Hi all,

In commit

  4ce937160ba0 ("irqchip/riscv-intc: Fix use of AIA interrupts 32-63 on riscv32")

Fixes tags

  Fixes: bb7921cdea12 ("irqchip/riscv-intc: Add support for RISC-V AIA")
  Fixes: e6bd9b966dc8 ("irqchip/riscv-intc: Fix low-level interrupt handler setup for AIA")

have this problem:

  - Target SHA1s do not exist

Maybe you meant

Fixes: 3c46fc5b5507 ("irqchip/riscv-intc: Add support for RISC-V AIA")
Fixes: 678c607ecf8a ("irqchip/riscv-intc: Fix low-level interrupt handler setup for AIA")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

Hi all,

In commit

  1abea7339b40 ("irqchip/riscv-intc: Fix low-level interrupt handler setup for AIA")

Fixes tag

  Fixes: c1be2ae5987a ("irqchip/riscv-intc: Add support for RISC-V AIA")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 3c46fc5b5507 ("irqchip/riscv-intc: Add support for RISC-V AIA")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 487 bytes --]

Hi all,

In commit

  991d8d8142ca ("topology: Remove unused cpu_cluster_mask()")

Fixes tag

  Fixes: 778c558f49a2c ("sched: Add cluster scheduler level in core and

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.  Also, please keep
all the commit message tags together at the end of the commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

Hi all,

In commit

  59b18a1e65b7 ("x86/msi: Fix msi message data shadow struct")

Fixes tag

  Fixes: 6285aa50736 ("x86/msi: Provide msi message shadow structs")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 347 bytes --]

Hi all,

In commit

  83dbf898a2d4 ("PCI/MSI: Mask MSI-X vectors only on success")

Fixes tag

  Fixes: aa8092c1d1f1 ("PCI/MSI: Mask all unused MSI-X entries")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 7d5ec3d36123 ("PCI/MSI: Mask all unused MSI-X entries")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

Hi all,

In commit

  6b2ecb61bb10 ("x86/csum: Fix compilation error for UM")

Fixes tag

  Fixes: df4554cebdaa ("x86/csum: Rewrite/optimize csum_partial()")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: d31c3c683ee6 ("x86/csum: Rewrite/optimize csum_partial()")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 692 bytes --]

Hi all,

In commit

  d7d607096ae6 ("sched/rt: Fix Deadline utilization tracking during policy change")

Fixes tag

  Fixes: 3727e0e ("sched/dl: Add dl_rq utilization tracking")

has these problem(s):

  - SHA1 should be at least 12 digits long

In commit

  fecfcbc288e9 ("sched/rt: Fix RT utilization tracking during policy change")

Fixes tag

  Fixes: 371bf427 ("sched/rt: Add rt_rq utilization tracking")

has these problem(s):

  - SHA1 should be at least 12 digits long

This can be fixed for the future by setting core.abbrev to 12 (or more)
or (for git v2.11 or later) just making sure it is not set (or set to
"auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

Hi all,

In commit

  488e13a489e9 ("perf/x86/lbr: Remove cpuc->lbr_xsave allocation from atomic context")

Fixes tag

  Fixes: c085fb8774 ("perf/x86/intel/lbr: Support XSAVES for arch LBR read")

has these problem(s):

  - SHA1 should be at least 12 digits long

Probably not worth rebasing to fix, but for the future this can be
fixed by setting core.abbrev to 12 (or more) or (for git v2.11 or later)
just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: linux-next: Fixes tag needs some work in the tip tree

[Song Bao Hua (Barry Song)]

> -----Original Message-----
> From: Stephen Rothwell [mailto:sfr@canb.auug.org.au]
> Sent: Saturday, May 8, 2021 2:18 PM
> To: Thomas Gleixner <tglx@linutronix.de>; Ingo Molnar <mingo@elte.hu>; H. Peter
> Anvin <hpa@zytor.com>; Peter Zijlstra <peterz@infradead.org>
> Cc: Song Bao Hua (Barry Song) <song.bao.hua@hisilicon.com>; Linux Kernel Mailing
> List <linux-kernel@vger.kernel.org>; Linux Next Mailing List
> <linux-next@vger.kernel.org>
> Subject: linux-next: Fixes tag needs some work in the tip tree
> 
> Hi all,
> 
> In commit
> 
>   19987fdad506 ("sched,doc: sched_debug_verbose cmdline should be
> sched_verbose")
> 
> Fixes tag
> 
>   Fixes: 9406415f46 ("sched/debug: Rename the sched_debug parameter to
> sched_verbose")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").
> 

Sorry, my bad. Will keep it in mind.

> --
> Cheers,
> Stephen Rothwell

Thanks
Barry

linux-next: Fixes tag needs some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 456 bytes --]

Hi all,

In commit

  19987fdad506 ("sched,doc: sched_debug_verbose cmdline should be sched_verbose")

Fixes tag

  Fixes: 9406415f46 ("sched/debug: Rename the sched_debug parameter to sched_verbose")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the tip tree

[Masami Hiramatsu]

On Mon, 29 Mar 2021 08:30:37 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> In commit
> 
>   2f706e0e5e26 ("x86/kprobes: Fix to identify indirect jmp and others using range case")
> 
> Fixes tag
> 
>   Fixes: 6256e668b7 ("x86/kprobes: Use int3 instead of debug trap for single-step")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
> 
> I don't think this is worth rebasing to fix, but it can be avoided in
> the future by setting core.abbrev to 12 (or more) or (for git v2.11 or
> later) just making sure it is not set (or set to "auto").

Sorry, it was my mistake. this is the correct tag.

Fixes: 6256e668b7af ("x86/kprobes: Use int3 instead of debug trap for single-step")

Thanks, 

> 
> -- 
> Cheers,
> Stephen Rothwell


-- 
Masami Hiramatsu <mhiramat@kernel.org>

linux-next: Fixes tag needs some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 523 bytes --]

Hi all,

In commit

  2f706e0e5e26 ("x86/kprobes: Fix to identify indirect jmp and others using range case")

Fixes tag

  Fixes: 6256e668b7 ("x86/kprobes: Use int3 instead of debug trap for single-step")

has these problem(s):

  - SHA1 should be at least 12 digits long

I don't think this is worth rebasing to fix, but it can be avoided in
the future by setting core.abbrev to 12 (or more) or (for git v2.11 or
later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

Hi all,

In commit

  05f7fcc675f5 ("hrtimer: Update softirq_expires_next correctly after __hrtimer_get_next_event()")

Fixes tag

  Fixes: da70160462e ("hrtimer: Implement support for softirq based hrtimers")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 5da70160462e ("hrtimer: Implement support for softirq based hrtimers")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

Hi all,

In commit

  d1adcfbb520c ("iommu/amd: Fix IOMMU interrupt generation in X2APIC mode")

Fixes tag

  Fixes: 47bea873cf80 "x86/msi: Only use high bits of MSI address for DMAR unit")

has these problem(s):

  - Subject has trailing but no trailing parenthesis.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 745 bytes --]

Hi all,

In commit

  f36a74b9345a ("x86/ioapic: Use I/O-APIC ID for finding irqdomain, not index")

Fixes tag

  Fixes: b643128b917 ("x86/ioapic: Use irq_find_matching_fwspec() to find remapping irqdomain")

has these problem(s):

  - SHA1 should be at least 12 digits long

In commit

  26573a97746c ("x86/apic: Fix x2apic enablement without interrupt remapping")

Fixes tag

  Fixes: ce69a784504 ("x86/apic: Enable x2APIC without interrupt remapping under KVM")

has these problem(s):

  - SHA1 should be at least 12 digits long

This can be fxed in the future by setting core.abbrev to 12 (or more)
or (for git v2.11 or later) just making sure it is not set (or set to
"auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 414 bytes --]

Hi all,

In commit

  f8e48a3dca06 ("lockdep: Fix preemption WARN for spurious IRQ-enable")

Fixes tag

  Fixes: 4d004099a6 ("lockdep: Fix lockdep recursion")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

Hi all,

In commit

  df3cb4ea1fb6 ("sched/fair: Fix wrong cpu selecting from isolated domain")

Fixes tag

  Fixes: 10e2f1acd010 ("sched/core: Rewrite and improve select_idle_siblings())

has these problem(s):

  - Subject has leading but no trailing quotes

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 497 bytes --]

Hi all,

In commit

  233e7aca4c8a ("sched/fair: Use dst group while checking imbalance for NUMA balancer")

Fixes tag

  Fixes: fb86f5b211 ("sched/numa: Use similar logic to the load balancer for moving between domains with spare capacity")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the tip tree

[Borislav Petkov]

On Thu, Aug 20, 2020 at 11:22:21AM +0200, David Sterba wrote:
> (Dunno why not an alias but it works the same way.)

I have this alias:

	one = show -s --pretty='format:%h (\"%s\")'

and so I do

$ git one <sha1>

and then paste it after Fixes:

I have it this way because quoting commits is kinda very frequent
operation, not only for Fixes: tags.

:-)

-- 
Regards/Gruss,
    Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg

Re: linux-next: Fixes tag needs some work in the tip tree

[David Sterba]

On Thu, Aug 20, 2020 at 07:15:02PM +1000, Stephen Rothwell wrote:
> On Thu, 20 Aug 2020 10:21:49 +0200 Borislav Petkov <bp@suse.de> wrote:
> >
> > On Thu, Aug 20, 2020 at 04:12:39PM +1000, Stephen Rothwell wrote:
> > > 
> > > Fixes tag
> > > 
> > >   Fixes: 9554bfe403nd ("x86/mce: Convert the CEC to use the MCE notifier")  
> > 
> > Hmm, this came from the original patch submission:
> > 
> > https://lkml.kernel.org/r/20200805095708.83939-1-luca.stefani.ge1@gmail.com
> > 
> > the 'n' is already there.
> 
> yeah, I wish people would just generate these lines:
> 
> git log -1 --format='Fixes: %h ("%s")' <commit-id>

FWIW, I'm using a script 'git-fixesline' that git also understands as a
subcommand 'git fixesline' with:

git --no-pager show -s --abbrev-commit --abbrev=12 --pretty=format:"Fixes: %h (\"%s\")%n" "$@"

(Dunno why not an alias but it works the same way.)

Re: linux-next: Fixes tag needs some work in the tip tree

[Borislav Petkov]

Hey Stephen,

On Thu, Aug 20, 2020 at 07:15:02PM +1000, Stephen Rothwell wrote:
> yeah, I wish people would just generate these lines:
> 
> git log -1 --format='Fixes: %h ("%s")' <commit-id>

Yap, but that "add invalid char" thing can happen when pasting the mail
in the mail client, etc. I've even seen maintainers botch tags...

> Is a shell script OK?

Nah, my script is in python. But no worries, I'll add that to it now,
since I even have an actual example to test it on.

Thx for catching this!

-- 
Regards/Gruss,
    Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg

Re: linux-next: Fixes tag needs some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 832 bytes --]

Hi Borislav,

On Thu, 20 Aug 2020 10:21:49 +0200 Borislav Petkov <bp@suse.de> wrote:
>
> On Thu, Aug 20, 2020 at 04:12:39PM +1000, Stephen Rothwell wrote:
> > 
> > Fixes tag
> > 
> >   Fixes: 9554bfe403nd ("x86/mce: Convert the CEC to use the MCE notifier")  
> 
> Hmm, this came from the original patch submission:
> 
> https://lkml.kernel.org/r/20200805095708.83939-1-luca.stefani.ge1@gmail.com
> 
> the 'n' is already there.

yeah, I wish people would just generate these lines:

git log -1 --format='Fixes: %h ("%s")' <commit-id>

> > has these problem(s):
> > 
> >   - The SHA1 is not all hex  
> 
> If your script which verifies that is in python, per chance, you could
> give it to me so that I can add it to my patch massaging script. :-)

Is a shell script OK?

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the tip tree

[Borislav Petkov]

On Thu, Aug 20, 2020 at 04:12:39PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   71aefb9a89d4 ("RAS/CEC: Fix cec_init() prototype")
> 
> Fixes tag
> 
>   Fixes: 9554bfe403nd ("x86/mce: Convert the CEC to use the MCE notifier")

Hmm, this came from the original patch submission:

https://lkml.kernel.org/r/20200805095708.83939-1-luca.stefani.ge1@gmail.com

the 'n' is already there.

> has these problem(s):
> 
>   - The SHA1 is not all hex

If your script which verifies that is in python, per chance, you could
give it to me so that I can add it to my patch massaging script. :-)

I have no Fixes: tags sanity checks so far and have never considered
that they could possibly be wrong but this here is a case-in-point
example.

I guess I'd need also an "is the commit ID an actual upstream commit ID"
check, while at it.

> Presumably
> 
> Fixes: 9554bfe403bd ("x86/mce: Convert the CEC to use the MCE notifier")

Fixing...

Thx.

-- 
Regards/Gruss,
    Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg

linux-next: Fixes tag needs some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 349 bytes --]

Hi all,

In commit

  71aefb9a89d4 ("RAS/CEC: Fix cec_init() prototype")

Fixes tag

  Fixes: 9554bfe403nd ("x86/mce: Convert the CEC to use the MCE notifier")

has these problem(s):

  - The SHA1 is not all hex

Presumably

Fixes: 9554bfe403bd ("x86/mce: Convert the CEC to use the MCE notifier")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 361 bytes --]

Hi all,

In commit

  d8a738689794 ("x86/optprobe: Fix OPTPROBE vs UACCESS")

Fixes tag

  Fixes: ca0bbc70f147 ("sched/x86_64: Don't save flags on context switch")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 64604d54d311 ("sched/x86_64: Don't save flags on context switch")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1816 bytes --]

Hi Bandan,

On Thu, 29 Aug 2019 04:26:33 -0400 Bandan Das <bsd@redhat.com> wrote:
>
> Stephen Rothwell <sfr@canb.auug.org.au> writes:
> 
> > In commit
> >
> >   bae3a8d3308e ("x86/apic: Do not initialize LDR and DFR for bigsmp")
> >
> > Fixes tag
> >
> >   Fixes: db7b9e9f26b8 ("[PATCH] Clustered APIC setup for >8 CPU systems")
> >
> > has these problem(s):
> >
> >   - Target SHA1 does not exist
> >  
> 
> I tried to dig this up and I believe that this is from pre-git.
> I went back as far as commit 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2
> Author: Linus Torvalds <torvalds@ppc970.osdl.org>
> Date:   Sat Apr 16 15:20:36 2005 -0700
> 
>     Linux-2.6.12-rc2
>     
>     Initial git repository build. I'm not bothering with the full history,
>     even though we have it. We can create a separate "historical" git
>     archive of that later if we want to, and in the meantime it's about
>     3.2GB when imported into git - space that would just make the early
>     git days unnecessarily complicated, when we don't have a lot of good
>     infrastructure for it.
>     
>     Let it rip!
> 
> which adds init_apic_ldr() in include/asm-i386/mach-bigsmp/mach_apic.h with
> the following:
> 
> +static inline void init_apic_ldr(void)
> +{
> +       unsigned long val;
> +
> +       apic_write_around(APIC_DFR, APIC_DFR_VALUE);
> +       val = apic_read(APIC_LDR) & ~APIC_LDR_MASK;
> +       val = calculate_ldr(val);
> +       apic_write_around(APIC_LDR, val);
> +}
> ...
> 
> 
> So, the bug seems to be present here as well...

Ah ha!

commit db7b9e9f26b8 ("[PATCH] Clustered APIC setup for >8 CPU systems")
is from Thomas' history git tree ...  I should have read more of the
commit message :-(  Sorry for the noise.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the tip tree

[Bandan Das]

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> Hi all,
>
> In commit
>
>   bae3a8d3308e ("x86/apic: Do not initialize LDR and DFR for bigsmp")
>
> Fixes tag
>
>   Fixes: db7b9e9f26b8 ("[PATCH] Clustered APIC setup for >8 CPU systems")
>
> has these problem(s):
>
>   - Target SHA1 does not exist
>

I tried to dig this up and I believe that this is from pre-git.
I went back as far as commit 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2
Author: Linus Torvalds <torvalds@ppc970.osdl.org>
Date:   Sat Apr 16 15:20:36 2005 -0700

    Linux-2.6.12-rc2
    
    Initial git repository build. I'm not bothering with the full history,
    even though we have it. We can create a separate "historical" git
    archive of that later if we want to, and in the meantime it's about
    3.2GB when imported into git - space that would just make the early
    git days unnecessarily complicated, when we don't have a lot of good
    infrastructure for it.
    
    Let it rip!

which adds init_apic_ldr() in include/asm-i386/mach-bigsmp/mach_apic.h with
the following:

+static inline void init_apic_ldr(void)
+{
+       unsigned long val;
+
+       apic_write_around(APIC_DFR, APIC_DFR_VALUE);
+       val = apic_read(APIC_LDR) & ~APIC_LDR_MASK;
+       val = calculate_ldr(val);
+       apic_write_around(APIC_LDR, val);
+}
...


So, the bug seems to be present here as well...

Bandan

> I could not quickly find an obvious match.

linux-next: Fixes tag needs some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

Hi all,

In commit

  bae3a8d3308e ("x86/apic: Do not initialize LDR and DFR for bigsmp")

Fixes tag

  Fixes: db7b9e9f26b8 ("[PATCH] Clustered APIC setup for >8 CPU systems")

has these problem(s):

  - Target SHA1 does not exist

I could not quickly find an obvious match.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

Hi all,

In commit

  b63f20a778c8 ("x86/retpoline: Don't clobber RFLAGS during CALL_NOSPEC on i386")

Fixes tag

  Fixes: 776b043848fd2 ("x86/retpoline: Add initial retpoline support")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: 76b043848fd2 ("x86/retpoline: Add initial retpoline support")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 711 bytes --]

Hi all,

In commit

  5f4318c1b1d2 ("perf/x86: Add Intel Ice Lake NNPI uncore support")

Fixes tag

  Fixes: e39875d15ad6 ("perf/x86: add Intel Icelake uncore support")

has these problem(s):

  - Target SHA1 does not exist.

Did you mean

Fixes: 6e394376ee89 ("perf/x86/intel/uncore: Add Intel Icelake uncore support")

In commit

  36edfb940195 ("perf data: Fix perf.data documentation for HEADER_CPU_TOPOLOGY")

Fixes tag

  Fixes: c9cb12c5ba08 ("perf header: Add die information in CPU topology")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: acae8b36cded ("perf header: Add die information in CPU topology")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

Hi all,

In commit

  2e712675ffd1 ("perf bpf: Return value with unlocking in perf_env__find_btf()")

Fixes tag

  Fixes: 2db7b1e0bd49d: (perf bpf: Return NULL when RB tree lookup fails in perf_env__find_btf())

has these problem(s):

  - the colon after the SHA1 is unexpected
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 462 bytes --]

Hi all,

In commit

  a65c88e16f32 ("x86/mm: Remove in_nmi() warning from 64-bit implementation of vmalloc_fault()")

Fixes tag

  Fixes: 6863ea0cda8 ("x86/mm: Remove in_nmi() warning from vmalloc_fault()")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the tip tree

[Ingo Molnar]

* Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> In commit
> 
>   f6783319737f ("sched/fair: Fix insertion in rq->leaf_cfs_rq_list")
> 
> Fixes tag
> 
>   Fixes: 9c2791f936ef ("Fix hierarchical order in rq->leaf_cfs_rq_list")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject

It's still a unique substring of the original subject, so not a big deal 
IMO.

Thanks,

	Ingo

linux-next: Fixes tag needs some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 294 bytes --]

Hi all,

In commit

  f6783319737f ("sched/fair: Fix insertion in rq->leaf_cfs_rq_list")

Fixes tag

  Fixes: 9c2791f936ef ("Fix hierarchical order in rq->leaf_cfs_rq_list")

has these problem(s):

  - Subject does not match target commit subject

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the tip tree

[Joe Perches]

On Fri, 2019-01-18 at 11:32 +1100, Stephen Rothwell wrote:
> Hi Thomas,
> 
> On Fri, 18 Jan 2019 00:45:44 +0100 (CET) Thomas Gleixner <tglx@linutronix.de> wrote:
> > On Fri, 18 Jan 2019, Stephen Rothwell wrote:
> > > Commit
> > > 
> > >   a31e184e4f69 ("x86/pkeys: Properly copy pkey state at fork()")
> > > 
> > > Fixes tag
> > > 
> > >   Fixes: e8c24d3a23a ("x86/pkeys: Allocation/free syscalls")
> > > 
> > > has these problems:
> > > 
> > >   - SHA1 should be at least 12 digits long  
> > 
> > Sigh. I'll add that to my sanity checks, but this one has to be as is as
> > it's in the middle of a series of fixes pending for linus tree.
> 
> That's OK, more of a reminder ... the abbreviated SHA1 is unique now,
> but may not be in the future - of course 12 digits does not guarantee
> that either.  I am told we already have some clashes using 11 digits :-(

Ævar Arnfjörð Bjarmason sent a [atch to
	Documentation/process/submitting-patches.rst
for that .gitconfig default length problem last month.

https://lore.kernel.org/patchwork/patch/1026639/

Perhaps something will come of that one day.

It does seem that of the 30K or so commits with "Fixes:" that
the style has standardized on the typical form below where
12 ("") is a 12 char SHA1 and ("") is the commit description

  21911 Fixes: 12 ("")
   1151 Fixes: 13 ("")
   1053 Fixes: 12 (')
    541 Fixes: 16 ("")
    325 Fixes: 10 ("")
    323 Fixes: 40
    274 Fixes:
    272 Fixes: 12 ""
    256 Fixes: 11 ("")
    217 Fixes: 14 ("")
    188 Fixes: commit 12 ("")
    181 Fixes: 8 ("")
    178 Fixes: 7 ("")
    163 Fixes: 9 ("")
     94 Fixes: 15 ("")
     51 Fixes: 12("")
     48 Fixes: 13 (')
     38 Fixes: 12
     35 Fixes: 12(')
     34 Fixes: 40 ("")
     30 Fixes: 12 (""
     28 Fixes: 17 ("")
     24 Fixes: Commit 12 ("")

So for checkpatch, maybe something like the below
would help standardize the Fixes line:
---
 scripts/checkpatch.pl | 29 ++++++++++++++++++-----------
 1 file changed, 18 insertions(+), 11 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 155fa9305166..a1aa3787d0b0 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2730,10 +2730,11 @@ sub process {
 		    $line !~ /^This reverts commit [0-9a-f]{7,40}/ &&
 		    ($line =~ /\bcommit\s+[0-9a-f]{5,}\b/i ||
 		     ($line =~ /(?:\s|^)[0-9a-f]{12,40}(?:[\s"'\(\[]|$)/i &&
-		      $line !~ /[\<\[][0-9a-f]{12,40}[\>\]]/i &&
-		      $line !~ /\bfixes:\s*[0-9a-f]{12,40}/i))) {
+		      $line !~ /[\<\[][0-9a-f]{12,40}[\>\]]/i))) {
 			my $init_char = "c";
 			my $orig_commit = "";
+			my $prefix = "commit";
+			my $prefix_case = "[Cc]ommit";
 			my $short = 1;
 			my $long = 0;
 			my $case = 1;
@@ -2744,18 +2745,24 @@ sub process {
 			my $orig_desc = "commit description";
 			my $description = "";
 
-			if ($line =~ /\b(c)ommit\s+([0-9a-f]{5,})\b/i) {
+			if ($line =~ /\b(f)ixes:\s+([0-9a-f]{5,})\b/i) {
+				$init_char = $1;
+				$orig_commit = lc($2);
+				$prefix = "Fixes:";
+				$prefix_case = "Fixes:";
+				$init_char = "F";
+			} elsif ($line =~ /\b(c)ommit\s+([0-9a-f]{5,})\b/i) {
 				$init_char = $1;
 				$orig_commit = lc($2);
 			} elsif ($line =~ /\b([0-9a-f]{12,40})\b/i) {
 				$orig_commit = lc($1);
 			}
 
-			$short = 0 if ($line =~ /\bcommit\s+[0-9a-f]{12,40}/i);
-			$long = 1 if ($line =~ /\bcommit\s+[0-9a-f]{41,}/i);
-			$space = 0 if ($line =~ /\bcommit [0-9a-f]/i);
-			$case = 0 if ($line =~ /\b[Cc]ommit\s+[0-9a-f]{5,40}[^A-F]/);
-			if ($line =~ /\bcommit\s+[0-9a-f]{5,}\s+\("([^"]+)"\)/i) {
+			$short = 0 if ($line =~ /\b$prefix\s+[0-9a-f]{12,40}/i);
+			$long = 1 if ($line =~ /\b$prefix\s+[0-9a-f]{41,}/i);
+			$space = 0 if ($line =~ /\b$prefix [0-9a-f]/i);
+			$case = 0 if ($line =~ /\b$prefix_case\s+[0-9a-f]{5,40}[^A-F]/);
+			if ($line =~ /\b$prefix\s+[0-9a-f]{5,}\s+\("([^"]+)"\)/i) {
 				$orig_desc = $1;
 				$hasparens = 1;
 			} elsif ($line =~ /\bcommit\s+[0-9a-f]{5,}\s*$/i &&
@@ -2763,10 +2770,10 @@ sub process {
 				 $rawlines[$linenr] =~ /^\s*\("([^"]+)"\)/) {
 				$orig_desc = $1;
 				$hasparens = 1;
-			} elsif ($line =~ /\bcommit\s+[0-9a-f]{5,}\s+\("[^"]+$/i &&
+			} elsif ($line =~ /\b$prefix\s+[0-9a-f]{5,}\s+\("[^"]+$/i &&
 				 defined $rawlines[$linenr] &&
 				 $rawlines[$linenr] =~ /^\s*[^"]+"\)/) {
-				$line =~ /\bcommit\s+[0-9a-f]{5,}\s+\("([^"]+)$/i;
+				$line =~ /\b$prefix\s+[0-9a-f]{5,}\s+\("([^"]+)$/i;
 				$orig_desc = $1;
 				$rawlines[$linenr] =~ /^\s*([^"]+)"\)/;
 				$orig_desc .= " " . $1;
@@ -2779,7 +2786,7 @@ sub process {
 			if (defined($id) &&
 			   ($short || $long || $space || $case || ($orig_desc ne $description) || !$hasparens)) {
 				ERROR("GIT_COMMIT_ID",
-				      "Please use git commit description style 'commit <12+ chars of sha1> (\"<title line>\")' - ie: '${init_char}ommit $id (\"$description\")'\n" . $herecurr);
+				      "Please use git commit description style '$prefix <12+ chars of sha1> (\"<title line>\")' - ie: '${init_char}" . substr($prefix, 1) . " $id (\"$description\")'\n" . $herecurr);
 			}
 		}
 

Re: linux-next: Fixes tag needs some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 818 bytes --]

Hi Thomas,

On Fri, 18 Jan 2019 00:45:44 +0100 (CET) Thomas Gleixner <tglx@linutronix.de> wrote:
>
> On Fri, 18 Jan 2019, Stephen Rothwell wrote:
> > Commit
> > 
> >   a31e184e4f69 ("x86/pkeys: Properly copy pkey state at fork()")
> > 
> > Fixes tag
> > 
> >   Fixes: e8c24d3a23a ("x86/pkeys: Allocation/free syscalls")
> > 
> > has these problems:
> > 
> >   - SHA1 should be at least 12 digits long  
> 
> Sigh. I'll add that to my sanity checks, but this one has to be as is as
> it's in the middle of a series of fixes pending for linus tree.

That's OK, more of a reminder ... the abbreviated SHA1 is unique now,
but may not be in the future - of course 12 digits does not guarantee
that either.  I am told we already have some clashes using 11 digits :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the tip tree

[Thomas Gleixner]

On Fri, 18 Jan 2019, Stephen Rothwell wrote:
> Commit
> 
>   a31e184e4f69 ("x86/pkeys: Properly copy pkey state at fork()")
> 
> Fixes tag
> 
>   Fixes: e8c24d3a23a ("x86/pkeys: Allocation/free syscalls")
> 
> has these problems:
> 
>   - SHA1 should be at least 12 digits long

Sigh. I'll add that to my sanity checks, but this one has to be as is as
it's in the middle of a series of fixes pending for linus tree.

Thanks,

	tglx

Re: linux-next: Fixes tag needs some work in the tip tree

[Thomas Gleixner]

Steven,

On Fri, 18 Jan 2019, Stephen Rothwell wrote:
> Commit
> 
>   f0ca26ca4f36 ("genirq: Fix the kerneldoc comment for struct irq_affinity_desc")
> 
> Fixes tag
> 
>   Fixes: Commit c410abbbacb9 ("genirq/affinity: Add is_managed to struct irq_affinity_desc")
> 
> has these problems:
> 
>   - No SHA1 recognised
> 
> The word "Commit" is unexpected in the Fixes tag line.

Ooops. Missed that one. Fixed now.

Thanks,

	tglx

linux-next: Fixes tag needs some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

Hi all,

Commit

  f0ca26ca4f36 ("genirq: Fix the kerneldoc comment for struct irq_affinity_desc")

Fixes tag

  Fixes: Commit c410abbbacb9 ("genirq/affinity: Add is_managed to struct irq_affinity_desc")

has these problems:

  - No SHA1 recognised

The word "Commit" is unexpected in the Fixes tag line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 267 bytes --]

Hi all,

Commit

  a31e184e4f69 ("x86/pkeys: Properly copy pkey state at fork()")

Fixes tag

  Fixes: e8c24d3a23a ("x86/pkeys: Allocation/free syscalls")

has these problems:

  - SHA1 should be at least 12 digits long

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]