From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 317EFC433FE for ; Thu, 10 Nov 2022 16:50:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232635AbiKJQum (ORCPT ); Thu, 10 Nov 2022 11:50:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232738AbiKJQuN (ORCPT ); Thu, 10 Nov 2022 11:50:13 -0500 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 579E013E82 for ; Thu, 10 Nov 2022 08:50:06 -0800 (PST) Received: by mail-pj1-x102a.google.com with SMTP id c15-20020a17090a1d0f00b0021365864446so2027595pjd.4 for ; Thu, 10 Nov 2022 08:50:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-disposition:mime-version:message-id:subject:cc:to:date:from :from:to:cc:subject:date:message-id:reply-to; bh=ZVqd+PvgZXEgpR5oiDP8I3WYALDkF1kwCNnCVwq1mpo=; b=KOrM7nTAXpp3ofHwJJRvDPycbrxwy/BUtfmO83XndSZ41PtDxOacBE0DrQFpxytI1Q JJCh2k1V7GgfY+6JXBzLBO19fnq0I4c2Jxvx68eO/LtakOsggQNrDZKf2M8qFcI91F9P 1JIEUsrASBrRow9EergEBIaIRb3VyJeJht5a0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZVqd+PvgZXEgpR5oiDP8I3WYALDkF1kwCNnCVwq1mpo=; b=j3bXJMMMtK2CWUXJcenSFXIz4pHLtqQa+IPMaLGOaLH9vML1106N6bBMj9cJltAMnc 77+VBbHEizDHWvEgGSL1qWTNRuxa16y0bzVOc0738DXEvEhlisbwmiyMnQkXlcPtpzZo NC4wkEU/jwdWaz3xfqFFBd3yitksUHvEFWiW3NheIQFzYA3qQ4tT45DHp9cNst/wHhwX iZ8vbRKfxrdQ257QL2mb/3apAUuYNvFV+JA8NE6KwWIEFjM7qbXUrW87Hpc8l/JvN3WV QPOqUjfNuy0qshve/MaYKFLfNGFUq77J9PpgnxykyEJaJ7/XuqR7eMT/J5b3Sqov1XKd wdqw== X-Gm-Message-State: ACrzQf2xRMgjHEr2726lCkApL51W3PwV5IS+slgwQOmw5Mkl2VuInHLJ l8lg3nEkO1jwY/cFzpwjkhx79g== X-Google-Smtp-Source: AMsMyM68qD69p1bOkhPUXlhFPk3ZndMHRyb1mJfNywAclXB2dk8dtu5d1uueCVKTxNOxV0ehqJ3EmA== X-Received: by 2002:a17:90b:4d91:b0:213:f1b:dab5 with SMTP id oj17-20020a17090b4d9100b002130f1bdab5mr65253209pjb.95.1668099005884; Thu, 10 Nov 2022 08:50:05 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id y23-20020a17090264d700b0017f92246e4dsm11375728pli.181.2022.11.10.08.50.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 08:50:05 -0800 (PST) From: coverity-bot X-Google-Original-From: coverity-bot Date: Thu, 10 Nov 2022 08:50:04 -0800 To: Lyude Paul Cc: Thomas Zimmermann , linux-kernel@vger.kernel.org, Ilia Mirkin , Daniel Vetter , Karol Herbst , Ben Skeggs , David Airlie , "Nathan E. Egge" , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, Jani Nikula , Dave Airlie , "Gustavo A. R. Silva" , linux-next@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Coverity: nouveau_dp_irq(): Null pointer dereferences Message-ID: <202211100850.7A8DD75@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org Hello! This is an experimental semi-automated report about issues detected by Coverity from a scan of next-20221110 as part of the linux-next scan project: https://scan.coverity.com/projects/linux-next-weekly-scan You're getting this email because you were associated with the identified lines of code (noted below) that were touched by commits: Mon Aug 31 19:10:08 2020 -0400 a0922278f83e ("drm/nouveau/kms/nv50-: Refactor and cleanup DP HPD handling") Coverity reported the following: *** CID 1527266: Null pointer dereferences (REVERSE_INULL) drivers/gpu/drm/nouveau/nouveau_dp.c:237 in nouveau_dp_irq() 231 struct nouveau_encoder *outp = find_encoder(connector, DCB_OUTPUT_DP); 232 struct nouveau_drm *drm = nouveau_drm(outp->base.base.dev); 233 struct nv50_mstm *mstm; 234 u64 hpd = 0; 235 int ret; 236 vvv CID 1527266: Null pointer dereferences (REVERSE_INULL) vvv Null-checking "outp" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 237 if (!outp) 238 return; 239 240 mstm = outp->dp.mstm; 241 NV_DEBUG(drm, "service %s\n", connector->name); 242 If this is a false positive, please let us know so we can mark it as such, or teach the Coverity rules to be smarter. If not, please make sure fixes get into linux-next. :) For patches fixing this, please include these lines (but double-check the "Fixes" first): Reported-by: coverity-bot Addresses-Coverity-ID: 1527266 ("Null pointer dereferences") Fixes: a0922278f83e ("drm/nouveau/kms/nv50-: Refactor and cleanup DP HPD handling") Thanks for your attention! -- Coverity-bot