linux-next: manual merge of the modules tree with the net-next tree

linux-next: manual merge of the modules tree with the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1431 bytes --]

Hi all,

Today's linux-next merge of the modules tree got a conflict in:

  kernel/trace/ftrace.c

between commit:

  3640bf8584f4 ("ftrace: Add support to resolve module symbols in ftrace_lookup_symbols")

from the net-next tree and commit:

  477f7e48d4f4 ("kallsyms: Delete an unused parameter related to kallsyms_on_each_symbol()")

from the modules tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc kernel/trace/ftrace.c
index 705b990d264d,7a06991624d4..000000000000
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@@ -8257,12 -8257,7 +8257,11 @@@ struct kallsyms_data 
  	size_t found;
  };
  
 +/* This function gets called for all kernel and module symbols
 + * and returns 1 in case we resolved all the requested symbols,
 + * 0 otherwise.
 + */
- static int kallsyms_callback(void *data, const char *name,
- 			     struct module *mod, unsigned long addr)
+ static int kallsyms_callback(void *data, const char *name, unsigned long addr)
  {
  	struct kallsyms_data *args = data;
  	const char **sym;

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: manual merge of the modules tree with the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2371 bytes --]

Hi all,

Today's linux-next merge of the modules tree got conflicts in:

  include/linux/module.h
  kernel/module/kallsyms.c

between commit:

  73feb8d5fa3b ("kallsyms: Make module_kallsyms_on_each_symbol generally available")

from the net-next tree and commit:

  90de88426f3c ("livepatch: Improve the search performance of module_kallsyms_on_each_symbol()")

from the modules tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc include/linux/module.h
index 35876e89eb93,3b312a1fcf59..000000000000
--- a/include/linux/module.h
+++ b/include/linux/module.h
@@@ -879,17 -878,8 +878,17 @@@ static inline bool module_sig_ok(struc
  }
  #endif	/* CONFIG_MODULE_SIG */
  
 +#if defined(CONFIG_MODULES) && defined(CONFIG_KALLSYMS)
- int module_kallsyms_on_each_symbol(int (*fn)(void *, const char *,
- 					     struct module *, unsigned long),
+ int module_kallsyms_on_each_symbol(const char *modname,
+ 				   int (*fn)(void *, const char *, unsigned long),
  				   void *data);
 +#else
- static inline int module_kallsyms_on_each_symbol(int (*fn)(void *, const char *,
- 						 struct module *, unsigned long),
- 						 void *data)
++static inline int module_kallsyms_on_each_symbol(const char *modname,
++						 int (*fn)(void *, const char *, unsigned long),
++						 void *data);
 +{
 +	return -EOPNOTSUPP;
 +}
 +#endif  /* CONFIG_MODULES && CONFIG_KALLSYMS */
  
  #endif /* _LINUX_MODULE_H */
diff --cc kernel/module/kallsyms.c
index 4523f99b0358,329cef573675..000000000000
--- a/kernel/module/kallsyms.c
+++ b/kernel/module/kallsyms.c
@@@ -494,8 -494,9 +494,8 @@@ unsigned long module_kallsyms_lookup_na
  	return ret;
  }
  
- int module_kallsyms_on_each_symbol(int (*fn)(void *, const char *,
- 					     struct module *, unsigned long),
 -#ifdef CONFIG_LIVEPATCH
+ int module_kallsyms_on_each_symbol(const char *modname,
+ 				   int (*fn)(void *, const char *, unsigned long),
  				   void *data)
  {
  	struct module *mod;

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]