linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Linus Walleij <linus.walleij@linaro.org>,
	Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>
Cc: ARM <linux-arm-kernel@lists.infradead.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: linux-next: manual merge of the pinctrl tree with the arm-soc tree
Date: Tue, 6 Dec 2022 12:13:36 +1100	[thread overview]
Message-ID: <20221206121336.474457bb@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 2199 bytes --]

Hi all,

Today's linux-next merge of the pinctrl tree got a conflict in:

  drivers/soc/fsl/qe/gpio.c

between commits:

  84582f9ed090 ("soc: fsl: qe: Avoid using gpio_to_desc()")
  66310b5a0fc1 ("soc: fsl: qe: request pins non-exclusively")

from the arm-soc tree and commit:

  c9eb6e546a23 ("soc: fsl: qe: Switch to use fwnode instead of of_node")

from the pinctrl tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc drivers/soc/fsl/qe/gpio.c
index 1440922341d8,9abb45ab138b..000000000000
--- a/drivers/soc/fsl/qe/gpio.c
+++ b/drivers/soc/fsl/qe/gpio.c
@@@ -13,11 -13,14 +13,13 @@@
  #include <linux/err.h>
  #include <linux/io.h>
  #include <linux/of.h>
 -#include <linux/of_gpio.h>
 +#include <linux/of_gpio.h>	/* for of_mm_gpio_chip */
 +#include <linux/gpio/consumer.h>
  #include <linux/gpio/driver.h>
 -/* FIXME: needed for gpio_to_chip() get rid of this */
 -#include <linux/gpio.h>
  #include <linux/slab.h>
  #include <linux/export.h>
+ #include <linux/property.h>
+ 
  #include <soc/fsl/qe/qe.h>
  
  struct qe_gpio_chip {
@@@ -187,16 -181,8 +189,16 @@@ struct qe_pin *qe_pin_request(struct de
  		goto err0;
  	}
  
 +	qe_pin->controller = gpiochip_get_data(gc);
 +	/*
 +	 * FIXME: this gets the local offset on the gpio_chip so that the driver
 +	 * can manipulate pin control settings through its custom API. The real
 +	 * solution is to create a real pin control driver for this.
 +	 */
 +	qe_pin->num = gpio_num - gc->base;
 +
- 	if (!of_device_is_compatible(gc->of_node, "fsl,mpc8323-qe-pario-bank")) {
+ 	if (!fwnode_device_is_compatible(gc->fwnode, "fsl,mpc8323-qe-pario-bank")) {
 -		pr_debug("%s: tried to get a non-qe pin\n", __func__);
 +		dev_dbg(dev, "%s: tried to get a non-qe pin\n", __func__);
  		err = -EINVAL;
  		goto err0;
  	}

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2022-12-06  1:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-06  1:13 Stephen Rothwell [this message]
2022-12-06 15:04 ` linux-next: manual merge of the pinctrl tree with the arm-soc tree Andy Shevchenko
  -- strict thread matches above, loose matches on Subject: below --
2022-11-18  5:06 Stephen Rothwell
2021-12-17  6:29 Stephen Rothwell
2021-12-17  8:02 ` Arnd Bergmann
2021-12-17 11:02 ` Andy Shevchenko
2017-01-31  5:29 Stephen Rothwell
2014-11-10  6:34 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221206121336.474457bb@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=olof@lixom.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).