From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: Signed-off-by missing for commit in the v4l-dvb-next tree
Date: Wed, 7 Dec 2022 23:03:15 +1100 [thread overview]
Message-ID: <20221207212220.66670e30@canb.auug.org.au> (raw)
In-Reply-To: <e250c025-65c4-1760-bcfe-7efb116b5c9d@xs4all.nl>
[-- Attachment #1: Type: text/plain, Size: 2175 bytes --]
Hi Hans,
On Wed, 7 Dec 2022 11:08:37 +0100 Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote:
>
> On 12/6/22 21:56, Stephen Rothwell wrote:
> > Hi all,
> >
> > Commits
> >
> > 85abf40b56af ("media: ipu3-cio2: make the bridge depend on i2c")
> > ca61babacbe8 ("media: MAINTAINERS: Add Hans de Goede as staging/atomisp maintainer")
> >
> > are missing a Signed-off-by from their committer.
> >
>
> They have a SoB, but there is a 'Link:' tag right before that:
>
> commit 85abf40b56af5f3130a4f9dcdb808c7feb64e083
> Author: Adam Borowski <kilobyte@angband.pl>
> Date: Fri Sep 16 00:33:18 2022 +0100
>
> media: ipu3-cio2: make the bridge depend on i2c
>
> drivers/media/pci/intel/ipu3/cio2-bridge.c: In function ‘cio2_bridge_unregister_sensors’:
> drivers/media/pci/intel/ipu3/cio2-bridge.c:258:17: error: implicit declaration of function ‘i2c_unregister_device’; did you mean ‘spi_unregister_device’? [-Werror=implicit-function-declaration]
> 258 | i2c_unregister_device(sensor->vcm_i2c_client);
> | ^~~~~~~~~~~~~~~~~~~~~
> | spi_unregister_device
>
> Link: https://lore.kernel.org/linux-media/S230142AbiJTWql/20221020224641Z+958@vger.kernel.org
> Signed-off-by: Adam Borowski <kilobyte@angband.pl>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
>
> commit ca61babacbe8ada7a0671f910c22b8758f481c0c
> Author: Hans de Goede <hdegoede@redhat.com>
> Date: Wed Nov 23 16:14:47 2022 +0000
>
> media: MAINTAINERS: Add Hans de Goede as staging/atomisp maintainer
>
> Add myself as maintainer for the drivers/staging/media/atomisp code.
>
> Link: https://lore.kernel.org/linux-media/20221123161447.15834-1-hdegoede@redhat.com
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
>
> Could that be the cause? checkpatch doesn't complain about this.
They have no SOB line from you and you are the one who committed them.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-12-07 12:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 20:56 linux-next: Signed-off-by missing for commit in the v4l-dvb-next tree Stephen Rothwell
2022-12-07 10:08 ` Hans Verkuil
2022-12-07 12:03 ` Stephen Rothwell [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-10-08 21:26 Stephen Rothwell
2023-10-08 23:12 ` Mauro Carvalho Chehab
2023-08-14 23:11 Stephen Rothwell
2023-08-20 22:15 ` Stephen Rothwell
2023-07-30 22:00 Stephen Rothwell
2023-02-08 20:56 Stephen Rothwell
2023-02-09 8:26 ` Hans Verkuil
2022-11-15 20:38 Stephen Rothwell
2022-11-27 21:20 ` Stephen Rothwell
2022-03-14 20:52 Stephen Rothwell
2022-03-07 21:01 Stephen Rothwell
2022-03-08 8:15 ` Hans Verkuil
2018-12-16 6:23 Stephen Rothwell
2018-12-17 20:39 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221207212220.66670e30@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).