linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josh Poimboeuf <jpoimboe@kernel.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
	Sathvika Vasireddy <sv@linux.ibm.com>,
	Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
	Peter Zijlstra <peterz@infradead.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	PowerPC <linuxppc-dev@lists.ozlabs.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the powerpc tree
Date: Thu, 16 Feb 2023 10:06:07 -0800	[thread overview]
Message-ID: <20230216180607.w666rnbtm5fumziq@treble> (raw)
In-Reply-To: <20230216144031.45b1fc12@canb.auug.org.au>

On Thu, Feb 16, 2023 at 02:40:31PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the powerpc tree, today's linux-next build (powerpc
> pseries_le_defconfig) produced this warning:
> 
> arch/powerpc/kernel/head_64.o: warning: objtool: .text+0x6128: unannotated intra-function call
> 
> I have no idea what caused this.

Adding Sathvika and Christophe.

The short term fix would be something like the below, but...

If powerpc objtool is only doing mcount, does it even make sense to run
objtool on asm files?  If so, there are probably a lot more cleanups
needed for the asm code.

So I'm thinking either we should cleanup all the powerpc asm code with
annotations like below, or we should try to make objtool mcount-mode
ignore asm files.


diff --git a/arch/powerpc/kernel/head_64.S b/arch/powerpc/kernel/head_64.S
index 3a7266fa8a18..1febb56ebaeb 100644
--- a/arch/powerpc/kernel/head_64.S
+++ b/arch/powerpc/kernel/head_64.S
@@ -472,7 +472,7 @@ SYM_FUNC_START_LOCAL(__mmu_off)
 	b	.	/* prevent speculative execution */
 SYM_FUNC_END(__mmu_off)
 
-start_initialization_book3s:
+SYM_FUNC_START_LOCAL(start_initialization_book3s)
 	mflr	r25
 
 	/* Setup some critical 970 SPRs before switching MMU off */
@@ -494,6 +494,7 @@ start_initialization_book3s:
 
 	mtlr	r25
 	blr
+SYM_FUNC_END(start_initialization_book3s)
 #endif
 
 /*

  reply	other threads:[~2023-02-16 18:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-16  3:40 linux-next: build warning after merge of the powerpc tree Stephen Rothwell
2023-02-16 18:06 ` Josh Poimboeuf [this message]
2023-02-17  1:35   ` Michael Ellerman
2023-02-17  7:05     ` Josh Poimboeuf
  -- strict thread matches above, loose matches on Subject: below --
2021-08-23  9:55 Stephen Rothwell
2021-08-23 10:48 ` Stephen Rothwell
2021-08-23 14:19   ` Jonathan Corbet
2021-08-23 23:21     ` Stephen Rothwell
2021-08-24  5:18   ` Aneesh Kumar K.V
2021-08-24 13:46     ` Jonathan Corbet
2021-04-15  8:52 Stephen Rothwell
2021-04-16 10:54 ` Michael Ellerman
2021-04-14 23:36 Stephen Rothwell
2019-11-13 22:34 Stephen Rothwell
2017-09-04  8:53 Stephen Rothwell
2017-09-04  8:59 ` Cédric Le Goater
2015-10-20  5:21 Stephen Rothwell
2015-10-20 10:06 ` Michael Ellerman
2015-10-20 20:45   ` Stephen Rothwell
2011-05-19  3:19 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230216180607.w666rnbtm5fumziq@treble \
    --to=jpoimboe@kernel.org \
    --cc=christophe.leroy@csgroup.eu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=peterz@infradead.org \
    --cc=sfr@canb.auug.org.au \
    --cc=sv@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).