From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Bastien Nocera <hadess@hadess.net>
Cc: Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the hid tree
Date: Wed, 5 Apr 2023 11:48:07 +1000 [thread overview]
Message-ID: <20230405114807.5a57bf46@canb.auug.org.au> (raw)
In-Reply-To: <366ab6c4d488645aee5cbf49fb2e9b39d9bb1e22.camel@hadess.net>
[-- Attachment #1: Type: text/plain, Size: 2003 bytes --]
Hi Bastien,
On Tue, 04 Apr 2023 11:18:35 +0200 Bastien Nocera <hadess@hadess.net> wrote:
>
> Before I send patches, does this look correct to you?
>
> diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
> index 7930dca84616..7c7f88ca4f62 100644
> --- a/drivers/usb/core/message.c
> +++ b/drivers/usb/core/message.c
> @@ -1926,7 +1926,7 @@ static void __usb_wireless_status_intf(struct work_struct *ws)
> 1926⋮1926│
> 1927⋮1927│ /**
> 1928⋮1928│ * usb_set_wireless_status - sets the wireless_status struct member
> 1929⋮ │- * @dev: the device to modify
> ⋮1929│+ * @iface: the interface to modify
> 1930⋮1930│ * @status: the new wireless status
> 1931⋮1931│ *
> 1932⋮1932│ * Set the wireless_status struct member to the new value, and emit
That looks good.
> diff --git a/include/linux/usb.h b/include/linux/usb.h
> index a48eeec62a66..3d523ebf0c09 100644
> --- a/include/linux/usb.h
> +++ b/include/linux/usb.h
> @@ -261,7 +261,8 @@ struct usb_interface {
> 261⋮ 261│ unsigned needs_binding:1; /* needs delayed unbind/rebind */
> 262⋮ 262│ unsigned resetting_device:1; /* true: bandwidth alloc after reset */
> 263⋮ 263│ unsigned authorized:1; /* used for interface authorization */
> 264⋮ │- enum usb_wireless_status wireless_status;
> ⋮ 264│+ enum usb_wireless_status wireless_status; /* whether the emitter is
> ⋮ 265│+ * connected to this receiver */
> 265⋮ 266│ struct work_struct wireless_status_work;
> 266⋮ 267│
> 267⋮ 268│ struct device dev; /* interface specific device info */
>
This is not right, though. The warning was about
"wireless_status_work" not "wireless_status", so I think you need a
description of wireless_status_work in the block comment above the
struct definition.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-04-05 1:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 5:40 linux-next: build warning after merge of the hid tree Stephen Rothwell
2023-04-04 5:42 ` Stephen Rothwell
2023-04-04 8:22 ` Bastien Nocera
2023-04-04 8:55 ` Stephen Rothwell
2023-04-04 9:18 ` Bastien Nocera
2023-04-05 1:48 ` Stephen Rothwell [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-11-10 4:06 Stephen Rothwell
2021-11-10 8:17 ` Jiri Kosina
2012-07-02 2:14 Stephen Rothwell
2012-07-03 9:22 ` Jiri Kosina
2012-04-30 4:05 Stephen Rothwell
2012-04-30 8:42 ` Jiri Kosina
2012-03-29 0:51 Stephen Rothwell
2012-03-30 8:45 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230405114807.5a57bf46@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=benjamin.tissoires@redhat.com \
--cc=hadess@hadess.net \
--cc=jikos@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).