From: Greg KH <gregkh@linuxfoundation.org>
To: Jeffrey Hugo <quic_jhugo@quicinc.com>
Cc: daniel@ffwll.ch, sfr@canb.auug.org.au, ogabbay@kernel.org,
jacek.lawrynowicz@linux.intel.com, quic_pkanojiy@quicinc.com,
mani@kernel.org, airlied@redhat.com,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org
Subject: Re: [PATCH] Revert "accel/qaic: Add mhi_qaic_cntl"
Date: Wed, 12 Apr 2023 19:15:43 +0200 [thread overview]
Message-ID: <2023041201-underwear-consumer-1eb8@gregkh> (raw)
In-Reply-To: <1681307864-3782-1-git-send-email-quic_jhugo@quicinc.com>
On Wed, Apr 12, 2023 at 07:57:44AM -0600, Jeffrey Hugo wrote:
> This reverts commit 566fc96198b4bb07ca6806386956669881225271.
>
> This exposes a userspace API that is still under debate. Revert the
> change before the uAPI gets exposed to avoid making a mistake. QAIC is
> otherwise still functional.
>
> Suggested-by: Daniel Vetter <daniel@ffwll.ch>
> Signed-off-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
> Reviewed-by: Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@quicinc.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
And can you cc: me when you resubmit this? It's not really correct in a
number of places and can be made simpler if you really want to have your
own class and device major.
thanks,
greg k-h
next prev parent reply other threads:[~2023-04-12 17:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 13:57 [PATCH] Revert "accel/qaic: Add mhi_qaic_cntl" Jeffrey Hugo
2023-04-12 14:00 ` Jeffrey Hugo
2023-04-12 14:27 ` Daniel Vetter
2023-04-12 14:05 ` Stanislaw Gruszka
2023-04-13 8:49 ` Daniel Vetter
2023-04-13 10:15 ` Jacek Lawrynowicz
2023-04-12 17:15 ` Greg KH [this message]
2023-04-13 8:52 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023041201-underwear-consumer-1eb8@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=airlied@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.lawrynowicz@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mani@kernel.org \
--cc=ogabbay@kernel.org \
--cc=quic_jhugo@quicinc.com \
--cc=quic_pkanojiy@quicinc.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).