From: Christian Brauner <brauner@kernel.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: manual merge of the vfs-brauner tree with the djw-vfs tree
Date: Wed, 23 Aug 2023 09:44:49 +0200 [thread overview]
Message-ID: <20230823-wuseln-adrett-2b10dfcb3dee@brauner> (raw)
In-Reply-To: <20230822211456.GC11286@frogsfrogsfrogs>
> Hmm. Looking at the {up,down}_write -> super_{un,}lock_excl conversion,
> I think you missed wait_for_partially_frozen:
Maha, I sure did. Thanks, converted as well.
> That said, freeze_super() took an s_active refcount at the top, called
> super_lock_excl (which means the sb isn't DYING and has been BORN) and
> doesn't release it before calling wait_for_partially_frozen.
Yes.
> AFAICT, the subsequent down_write -> super_lock_excl conversions in
> freeze_super do not gain us much since I don't think the sb can get to
> SB_DYING state without s_active reaching zero, right? According to
Yes, if you have an active reference count the superblock stays alive.
If it ever gets into SB_DYING we have a bug.
> The missing conversion isn't strictly necessary, but it probably makese
> sense to do it anyway.
I did. Thanks for pointing that out!
> (Aside from that, the conversion looks correct to me.)
Thanks!
prev parent reply other threads:[~2023-08-23 7:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 1:05 linux-next: manual merge of the vfs-brauner tree with the djw-vfs tree Stephen Rothwell
2023-08-22 2:51 ` Darrick J. Wong
2023-08-22 9:46 ` Christian Brauner
2023-08-22 18:26 ` Darrick J. Wong
2023-08-22 20:19 ` Christian Brauner
2023-08-22 21:14 ` Darrick J. Wong
2023-08-23 7:44 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230823-wuseln-adrett-2b10dfcb3dee@brauner \
--to=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).