From: Josh Poimboeuf <jpoimboe@kernel.org>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: linux-next: Tree for Sep 12 (bcachefs, objtool)
Date: Thu, 14 Sep 2023 15:41:42 +0200 [thread overview]
Message-ID: <20230914134142.lndfpgqahgkqca5k@treble> (raw)
In-Reply-To: <20230913230626.mu764axueko6ccta@moria.home.lan>
On Wed, Sep 13, 2023 at 07:06:26PM -0400, Kent Overstreet wrote:
> On Wed, Sep 13, 2023 at 11:08:29PM +0200, Josh Poimboeuf wrote:
> > On Tue, Sep 12, 2023 at 04:36:55PM -0700, Randy Dunlap wrote:
> > >
> > >
> > > On 9/11/23 22:26, Stephen Rothwell wrote:
> > > > Hi all,
> > > >
> > > > Changes since 20230911:
> > > >
> > > > New tree: bcachefs
> > > >
> > > > The bcachefs tree gained a semantic conflict against Linus' tree for
> > > > which I applied a patch.
> > > >
> > > > The wireless-next tree gaind a conflict against the wireless tree.
> > > >
> > > > Non-merge commits (relative to Linus' tree): 4095
> > > > 1552 files changed, 346893 insertions(+), 22945 deletions(-)
> > > >
> > > > ----------------------------------------------------------------------------
> > >
> > > on x86_64:
> > >
> > > vmlinux.o: warning: objtool: bch2_dev_buckets_reserved.part.0() is missing an ELF size annotation
> >
> > Here ya go:
> >
> > ---8<---
> >
> > From: Josh Poimboeuf <jpoimboe@kernel.org>
> > Subject: [PATCH] bcachefs: Remove undefined behavior in bch2_dev_buckets_reserved()
> >
> > In general it's a good idea to avoid using bare unreachable() because it
> > introduces undefined behavior in compiled code. In this case it even
> > confuses GCC into emitting an empty unused
> > bch2_dev_buckets_reserved.part.0() function.
> >
> > Use BUG() instead, which is nice and defined. While in theory it should
> > never trigger, if something were to go awry and the BCH_WATERMARK_NR
> > case were to actually hit, the failure mode is much more robust.
>
> Thanks, want to do the other two cases too? :)
Hm, which cases are you referring to?
--
Josh
next prev parent reply other threads:[~2023-09-14 13:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 5:26 linux-next: Tree for Sep 12 Stephen Rothwell
2023-09-12 22:28 ` linux-next: Tree for Sep 12 (drivers/clk/imx/clk-imx8-acm.o) Randy Dunlap
2023-09-21 9:39 ` Abel Vesa
2023-09-12 22:50 ` linux-next: Tree for Sep 12 [drivers/pinctrl/nuvoton/pinctrl-npcm8xx.ko] Randy Dunlap
2023-09-12 23:36 ` linux-next: Tree for Sep 12 (bcachefs, objtool) Randy Dunlap
2023-09-13 21:08 ` Josh Poimboeuf
2023-09-13 21:39 ` Randy Dunlap
2023-09-13 23:06 ` Kent Overstreet
2023-09-14 13:41 ` Josh Poimboeuf [this message]
2023-09-14 1:01 ` Kees Cook
2023-09-14 13:51 ` Josh Poimboeuf
2023-09-14 16:51 ` Kees Cook
2023-09-14 19:15 ` Kent Overstreet
2023-09-14 1:17 ` linux-next: Tree for Sep 12 (bcachefs) Kees Cook
2023-09-14 19:38 ` Kent Overstreet
2023-09-14 20:13 ` Gustavo A. R. Silva
2023-09-15 0:20 ` Kees Cook
2023-09-19 21:23 ` Kent Overstreet
2023-09-20 15:21 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230914134142.lndfpgqahgkqca5k@treble \
--to=jpoimboe@kernel.org \
--cc=kent.overstreet@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).