From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60926E7849A for ; Mon, 2 Oct 2023 11:26:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231290AbjJBL0y (ORCPT ); Mon, 2 Oct 2023 07:26:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231352AbjJBL0w (ORCPT ); Mon, 2 Oct 2023 07:26:52 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29586BF; Mon, 2 Oct 2023 04:26:50 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E0FAD1F747; Mon, 2 Oct 2023 11:26:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1696246008; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=O8HVPZ56bJoZANjNFw676tpkdWp8TtuahrrDrd78TtE=; b=PIgyTep/4Omtrl8nYIssGr0Y/13VL+1/saX/ZBd0Od5zQgKqM5jyEjNmUFWSqqlicfuM1m Ubwe0sqDmdpT6bXBWdtMnQwfKLNwNCciZ63gfv4hirj/SWGjMQqUToIQbGnt1vuKxnFxer CPDpVrNBRZX/OW6s97CZiHWAl/TO9yU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1696246008; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=O8HVPZ56bJoZANjNFw676tpkdWp8TtuahrrDrd78TtE=; b=ViArQbUVyS5DjeLSMcxQ6sjO9/SljQNYX5KbmMS6ryStPPFXMtd7gqndur77ywUQaZ6o0V XM8yZQNLWcN5TIBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D2D5713456; Mon, 2 Oct 2023 11:26:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 54R2M/ioGmVCBAAAMHmgww (envelope-from ); Mon, 02 Oct 2023 11:26:48 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 713F7A07C9; Mon, 2 Oct 2023 13:26:48 +0200 (CEST) Date: Mon, 2 Oct 2023 13:26:48 +0200 From: Jan Kara To: Stephen Rothwell Cc: Christian Brauner , Kent Overstreet , Jan Kara , Linux Kernel Mailing List , Linux Next Mailing List Subject: Re: linux-next: build failure after merge of the vfs-brauner tree Message-ID: <20231002112648.rn2o4dvifn7x4zle@quack3> References: <20230928105443.1b1ad98c@canb.auug.org.au> <20231002112142.bfjj54ikijf4iwfr@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231002112142.bfjj54ikijf4iwfr@quack3> Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Mon 02-10-23 13:21:42, Jan Kara wrote: > Hi! > > On Thu 28-09-23 10:54:43, Stephen Rothwell wrote: > > After merging the vfs-brauner tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > > > fs/bcachefs/super-io.c: In function 'bch2_free_super': > > fs/bcachefs/super-io.c:166:17: error: implicit declaration of function 'blkdev_put'; did you mean 'bdi_put'? [-Werror=implicit-function-declaration] > > 166 | blkdev_put(sb->bdev, sb->holder); > > | ^~~~~~~~~~ > > | bdi_put > > fs/bcachefs/super-io.c: In function 'bch2_read_super': > > fs/bcachefs/super-io.c:687:20: error: implicit declaration of function 'blkdev_get_by_path'; did you mean 'bdev_open_by_path'? [-Werror=implicit-function-declaration] > > 687 | sb->bdev = blkdev_get_by_path(path, sb->mode, sb->holder, &bch2_sb_handle_bdev_ops); > > | ^~~~~~~~~~~~~~~~~~ > > | bdev_open_by_path > > fs/bcachefs/super-io.c:687:18: error: assignment to 'struct block_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion] > > 687 | sb->bdev = blkdev_get_by_path(path, sb->mode, sb->holder, &bch2_sb_handle_bdev_ops); > > | ^ > > fs/bcachefs/super-io.c:693:26: error: assignment to 'struct block_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion] > > 693 | sb->bdev = blkdev_get_by_path(path, sb->mode, sb->holder, &bch2_sb_handle_bdev_ops); > > | ^ > > cc1: all warnings being treated as errors > > > > Caused by commit > > > > 953863a5a2ff ("block: Remove blkdev_get_by_*() functions") > > > > interacting with commit(s) from the bcachefs tree. > > > > I would have reverted that commit for today, except I used the old > > vfs-brauner tree due to another build failure. Can we just delay this > > one commit until after bcachefs has been converted (and any other > > references that may be added are fixed)? > > Yeah, I guess removing the final commit is the easiest solution at this > point. It complicates a bit the series to disallow writing to mounted block > devices which bases on this - either I have to pospone that to the next > cycle after we convert bcachefs or I have to find a way for the old > blkdev_get_by_path() API and the new functionality to coexist. I'll think > about that. Oh, and one more note - Christian is on vacation this week so Stephen please just revert the commit in the linux-next until he returns and updates his tree. Thanks! Honza -- Jan Kara SUSE Labs, CR