From: Melissa Wen <mwen@igalia.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Alex Deucher <alexdeucher@gmail.com>,
Alex Deucher <alexander.deucher@amd.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the amdgpu tree
Date: Tue, 12 Dec 2023 08:01:59 -0100 [thread overview]
Message-ID: <20231212090159.hshy6elwhgkkhuzb@mail.igalia.com> (raw)
In-Reply-To: <20231212140134.13ffafa8@canb.auug.org.au>
On 12/12, Stephen Rothwell wrote:
> Hi all,
>
> On Tue, 12 Dec 2023 11:04:15 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the amdgpu tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> >
> > drivers/gpu/drm/drm_atomic_uapi.c:366:1: warning: 'drm_atomic_replace_property_blob_from_id' defined but not used [-Wunused-function]
> > 366 | drm_atomic_replace_property_blob_from_id(struct drm_device *dev,
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > Introduced by commit
> >
> > 1d2b049e4582 ("drm/drm_property: make replace_property_blob_from_id a DRM helper")
>
> This became a build failure in the i386 defconfig build, so I applied
> the following patch for today.
Yes, I also noticed it yesterday when building amd-staging-drm-next.
Something went wrong when they applied this patch:
https://lore.kernel.org/amd-gfx/20231116195812.906115-3-mwen@igalia.com/
and your patch below is exactly the part of this patch ^ that is
missing.
In addition, only the first four patches of the series were applied.
Thanks,
Melissa
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Tue, 12 Dec 2023 13:53:55 +1100
> Subject: [PATCH] drm: remove unused function drm_atomic_replace_property_blob_from_id()
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> drivers/gpu/drm/drm_atomic_uapi.c | 42 -------------------------------
> 1 file changed, 42 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gpu/drm/drm_atomic_uapi.c
> index 70ddbb93e466..29d4940188d4 100644
> --- a/drivers/gpu/drm/drm_atomic_uapi.c
> +++ b/drivers/gpu/drm/drm_atomic_uapi.c
> @@ -362,48 +362,6 @@ static s32 __user *get_out_fence_for_connector(struct drm_atomic_state *state,
> return fence_ptr;
> }
>
> -static int
> -drm_atomic_replace_property_blob_from_id(struct drm_device *dev,
> - struct drm_property_blob **blob,
> - uint64_t blob_id,
> - ssize_t expected_size,
> - ssize_t expected_elem_size,
> - bool *replaced)
> -{
> - struct drm_property_blob *new_blob = NULL;
> -
> - if (blob_id != 0) {
> - new_blob = drm_property_lookup_blob(dev, blob_id);
> - if (new_blob == NULL) {
> - drm_dbg_atomic(dev,
> - "cannot find blob ID %llu\n", blob_id);
> - return -EINVAL;
> - }
> -
> - if (expected_size > 0 &&
> - new_blob->length != expected_size) {
> - drm_dbg_atomic(dev,
> - "[BLOB:%d] length %zu different from expected %zu\n",
> - new_blob->base.id, new_blob->length, expected_size);
> - drm_property_blob_put(new_blob);
> - return -EINVAL;
> - }
> - if (expected_elem_size > 0 &&
> - new_blob->length % expected_elem_size != 0) {
> - drm_dbg_atomic(dev,
> - "[BLOB:%d] length %zu not divisible by element size %zu\n",
> - new_blob->base.id, new_blob->length, expected_elem_size);
> - drm_property_blob_put(new_blob);
> - return -EINVAL;
> - }
> - }
> -
> - *replaced |= drm_property_replace_blob(blob, new_blob);
> - drm_property_blob_put(new_blob);
> -
> - return 0;
> -}
> -
> static int drm_atomic_crtc_set_property(struct drm_crtc *crtc,
> struct drm_crtc_state *state, struct drm_property *property,
> uint64_t val)
> --
> 2.40.1
>
> --
> Cheers,
> Stephen Rothwell
next prev parent reply other threads:[~2023-12-12 9:02 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 0:04 linux-next: build warning after merge of the amdgpu tree Stephen Rothwell
2023-12-12 3:01 ` Stephen Rothwell
2023-12-12 9:01 ` Melissa Wen [this message]
2023-12-12 15:05 ` Alex Deucher
-- strict thread matches above, loose matches on Subject: below --
2024-01-30 2:56 Stephen Rothwell
2024-04-21 23:56 ` Stephen Rothwell
2024-01-30 2:54 Stephen Rothwell
2024-04-21 23:54 ` Stephen Rothwell
2023-12-14 4:29 Stephen Rothwell
2023-10-17 3:35 Stephen Rothwell
2023-09-21 2:31 Stephen Rothwell
2023-08-15 11:07 Stephen Rothwell
2023-08-16 1:57 ` Stephen Rothwell
2023-08-16 20:45 ` Alex Deucher
2023-06-09 4:02 Stephen Rothwell
2023-06-07 2:45 Stephen Rothwell
2023-04-12 4:36 Stephen Rothwell
2023-04-03 7:42 Stephen Rothwell
2023-03-01 0:34 Stephen Rothwell
2023-02-15 4:13 Stephen Rothwell
2023-01-18 3:13 Stephen Rothwell
2022-12-15 0:35 Stephen Rothwell
2022-11-18 6:47 Stephen Rothwell
2022-11-18 8:29 ` Christian König
2022-11-10 7:23 Stephen Rothwell
2022-10-28 3:33 Stephen Rothwell
2022-10-26 1:14 Stephen Rothwell
2023-07-11 23:12 ` Stephen Rothwell
2022-10-24 4:14 Stephen Rothwell
2022-08-31 5:37 Stephen Rothwell
2022-10-09 22:58 ` Stephen Rothwell
2022-08-11 22:13 Stephen Rothwell
2022-08-30 23:04 ` Stephen Rothwell
2022-10-05 0:36 ` Stephen Rothwell
2022-08-11 2:05 Stephen Rothwell
2022-08-30 1:48 ` Stephen Rothwell
2022-06-23 7:47 Stephen Rothwell
2022-03-25 8:07 Stephen Rothwell
2022-03-25 8:11 ` Christian König
2021-08-25 2:51 Stephen Rothwell
2021-06-05 2:26 Stephen Rothwell
2021-06-05 14:39 ` Eric Huang
2021-06-03 9:22 Stephen Rothwell
2021-05-28 1:50 Stephen Rothwell
2021-05-04 23:39 Stephen Rothwell
[not found] ` <DM4PR12MB5133E6A99840D1E8542C0D23F7599@DM4PR12MB5133.namprd12.prod.outlook.com>
2021-05-05 2:55 ` Stephen Rothwell
2021-04-26 12:40 Stephen Rothwell
2021-04-26 14:40 ` Nirmoy
2021-04-16 2:40 Stephen Rothwell
2021-04-16 3:12 ` Liang, Prike
2021-04-16 4:08 ` Stephen Rothwell
2021-04-16 5:47 ` Liang, Prike
2021-04-16 5:51 ` Alex Deucher
2021-04-21 6:40 ` Stephen Rothwell
2021-04-23 20:36 ` Alex Deucher
2021-04-23 22:39 ` Stephen Rothwell
2021-03-24 6:48 Stephen Rothwell
2021-03-24 2:33 Stephen Rothwell
2021-03-22 6:00 Stephen Rothwell
2021-04-21 6:15 ` Stephen Rothwell
2021-03-11 11:00 Stephen Rothwell
2021-04-21 6:10 ` Stephen Rothwell
2021-03-09 2:55 Stephen Rothwell
2021-03-03 6:00 Stephen Rothwell
2021-02-23 23:48 Stephen Rothwell
2021-01-18 5:29 Stephen Rothwell
2021-01-18 5:56 ` Huang, Ray
2021-01-18 6:52 ` Stephen Rothwell
2021-01-18 12:35 ` Huang Rui
2021-01-15 1:00 Stephen Rothwell
2021-01-20 6:15 ` Stephen Rothwell
2021-01-21 0:53 ` Stephen Rothwell
2021-01-21 3:07 ` Alex Deucher
2021-01-21 8:32 ` Daniel Vetter
2020-11-17 4:45 Stephen Rothwell
2020-12-14 19:56 ` Stephen Rothwell
2020-12-15 2:49 ` Stephen Rothwell
2020-04-23 2:24 Stephen Rothwell
2020-03-13 9:57 Stephen Rothwell
2020-02-04 22:44 Stephen Rothwell
2019-12-18 23:18 Stephen Rothwell
2019-11-08 0:21 Stephen Rothwell
2019-07-02 3:53 Stephen Rothwell
2019-05-10 0:59 Stephen Rothwell
2019-05-31 1:27 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231212090159.hshy6elwhgkkhuzb@mail.igalia.com \
--to=mwen@igalia.com \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).