From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FE4F11CB3 for ; Wed, 14 Feb 2024 00:00:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707868826; cv=none; b=OjCo90DmcO83CX4Yeb2FVi1iEkM7KJdZA+ll2tXIh8SN4AM5T57GIvUY0kjuxv9ySeuuMvPYnj+oeyzPciFTL5wkF3FV5zMnyPXwQV5ECTpLIXaEqNuelpzFv/CtjYX494T7dF36xEeDnbzO7f4tfcvH2srW+SUNbWE6/fee2V4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707868826; c=relaxed/simple; bh=tYu0rqPvKTdx4pnVuOKPIvquYhOnQYYcWPZ47Q6TdhE=; h=From:Date:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=aETok6wumSH9yPtWBoYHiEq2B0EyI0CVx5TdWAFktejGpQ0rNizDP1OiZILE1aOFiWCRDhdOO1XqgxdrFvIYTe6JFPsg/lFg2gIewQxXJJskcCG5Ml456I5Po9k4bSXenvhQZhvsLo2Lf9sDPS5AWJPx3Agwy0IzSCTWbbfMJyM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=g/IdfDh3; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="g/IdfDh3" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1d7431e702dso42698305ad.1 for ; Tue, 13 Feb 2024 16:00:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1707868824; x=1708473624; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:date:from :from:to:cc:subject:date:message-id:reply-to; bh=YMBETSS65YtqnXuGPPIuISSAqLQJ5kfAKukBNt/idE8=; b=g/IdfDh3nFeXG8CsElKPItCVf4m1wtyQYgNh9QQpbtTYjTCm37wJBTCjYIkFTRK661 +5ce6zWvG3EhqweBFILo8w6EIW4/PIvWfvM1ymJ1+bCDr6SKfXwYBSXooXAFesCrMYBV alG4EBsTTnF1DiSrbwB2mi77u5jDgIR3cVmLg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707868824; x=1708473624; h=content-disposition:mime-version:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YMBETSS65YtqnXuGPPIuISSAqLQJ5kfAKukBNt/idE8=; b=N8yMxa9vmvd/dmY5xpdNdk8QxS68pOFYVtKb6HbZp/bFzRRV9//cUlovGKSS+6HG+O 0JlP2do3GCjLbHwI6BeNLKAcbxQQ54xKcxA9J0x8Wicv/lNK11rit/3IDRwSX8eJ12ug W7pPmhd4GnbmJv5Ls7xZroITTI4UqdeM5Iuvzut9yrfAh01WZnW3O0LjhvJcydHPspdr ITMGHLibd3y1EeS6vOLpmgkplGKI7F8PuBJZMkS4b9czMs70hKFLScK7W3P614kor9m1 bex1XNDh1LO0hyKglHJ3XgMRxIALHuWaxpXqwde/ctdKINFu8ip0faGhUC7PHi+kAjpW WTew== X-Forwarded-Encrypted: i=1; AJvYcCVB/4TCeNxCdw1Mt59IFk235glD+DqOeN9ASZVwgByEbZRDpuB1FtgZch8KDyLcSSmm2arbdUg8e0lknkMPFrbddTANkdEcXgnZaw== X-Gm-Message-State: AOJu0Yxfr83L8nTCsumbJ00VWlu5dss9WNMAmdMUW5toD1wsMG1MVwwl 9y92UyxDYuE/GGaHE42Ss1VsOUTSWIcWFUVfhEEmvnAQ5qboisRosNHqll3PUw== X-Google-Smtp-Source: AGHT+IH9rsUe89jGMxEbzEa0N6vUYHDPRuvR/b9/k1IT9a00gMG0R2c9wJlulVF3FzsCot+gzaw1PA== X-Received: by 2002:a17:90a:f40c:b0:296:15ed:b220 with SMTP id ch12-20020a17090af40c00b0029615edb220mr832051pjb.45.1707868824140; Tue, 13 Feb 2024 16:00:24 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXvqigQwCxsR1eRkChMkloewkaYy2M5PIy5Ni/XnHBQDAoKHR/aIWNhHUmSslt8uKRHk2RvI4FXgV3UeO0qZK5hqOibVcIauBOnaVV6bWqTt+6c8dkIprXNrI5L5VfYBFUHS69JyCg+nHpwWH2NA7USk6ZGA7BJYmKeBVNaUv6t7nbX6rD1Z408EwIrtCw4leiFoAOQQxPSKq96raZChBqacZ3+4FYorcIV+LyapGi48IgtKsvYmWtHxOooH1tU+9GuPo7DWxRObhQs2h/a8NPsVDG+8Ii56LWj61JxEfWg8Jpnp22Q5QXdxTZePUUSTJkUCjhZzswaHYKdG9wthJUgMDbiBypE28viY4HtoFLOasVUO9pQGnzZlTiocOiJc/j2G5FPsjyRYU/m/U+tLeylJhN8RRMOG1mblR4pXyrkPq8U4+QBJzK2xCgs4paq+UjHOlY6f8nCDaPTIYca6QGUU4oDY6Wxvl/ffuvXbNTLjgytPTUvb0LZI8DpX3qZ9VXoyFO2DA98Nd/FyAdnCsh9Wx4mk4ILJR0vc+h2OOqUOjdFTYgx1CTlgPMBCwL2wn02OHDgfzIBa4fgsHNuZ2cYDjFG1baEF2loFgOxwfI7AqA2M0tBhkyn56ZLLulIRLW9y2Yhe/oRExou8cAUYnr3X3fcva1E523zl+gb8uJN9PUnSoaBABRO4nU5Zub2E2rHh6pibQJRTd5zMWMDH/6Ng64ln4aFlKDp3UrwcNFtF+9YSPO3aiogzLGUboEk6CYsA2Qc6BtsMMWfB3lxYqpKqJTGb1frpJIrwJTMGNoHZ330172lV9akQVjbSxkHoEY9vEhupNRlyX1PhADYagw9Eug9eM1rAObW7gqFTdA9KWXKUA0JFFdMhd46aF3gGGOFbVnANrA1fRYLe3cigO4CcuNuISMz8MiDonjdbYtNfdfO9UmzV/30vOkiws/N/gTW7P 9ZxedQ9fPgpdcMoM9aUXZcpQijJVqwyZiu0ME7ezdhRn4k0vJV3sxJfd8YsRR/fEySJmzTASB18YtNpPAPC//yt7IQiwiKqBOckpWmQ0j4IQj5XbaBcWuhawwVFuZ4eLJmroLfpIackC8FxNUKY62wd6T0mgw4m9+N2ZG22Gfz Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id mv21-20020a17090b199500b00298c373a820sm100292pjb.23.2024.02.13.16.00.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 16:00:23 -0800 (PST) From: coverity-bot X-Google-Original-From: coverity-bot Date: Tue, 13 Feb 2024 16:00:23 -0800 To: Saleemkhan Jamadar Cc: Sun peng Li , Mario Limonciello , amd-gfx@lists.freedesktop.org, "Pan, Xinhui" , Daniel Vetter , Roman Li , Veerabadhran Gopalakrishnan , Horatio Zhang , James Zhu , Harry Wentland , Yifan Zhang , David Airlie , Aurabindo Pillai , Leo Liu , Bhawanpreet Lakha , Sonny Jiang , Lang Yu , Alex Deucher , Li Ma , Lijo Lazar , Morris Zhang , Tao Zhou , dri-devel@lists.freedesktop.org, Shane Xiao , Christian =?iso-8859-1?Q?K=F6nig?= , Ran Sun , Jane Jian , Hawking Zhang , Ivan Lipski , linux-kernel@vger.kernel.org, Tom Chung , "Gustavo A. R. Silva" , linux-next@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Coverity: jpeg_v4_0_5_start(): Code maintainability issues Message-ID: <202402131600.FF35A56D27@keescook> Precedence: bulk X-Mailing-List: linux-next@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hello! This is an experimental semi-automated report about issues detected by Coverity from a scan of next-20240213 as part of the linux-next scan project: https://scan.coverity.com/projects/linux-next-weekly-scan You're getting this email because you were associated with the identified lines of code (noted below) that were touched by commits: Mon Feb 12 16:09:32 2024 -0500 0a119d53f74a ("drm/amdgpu/jpeg: add support for jpeg DPG mode") Coverity reported the following: *** CID 1583635: Code maintainability issues (UNUSED_VALUE) drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c:461 in jpeg_v4_0_5_start() 455 456 WREG32_SOC15(VCN, i, regVCN_JPEG_DB_CTRL, 457 ring->doorbell_index << VCN_JPEG_DB_CTRL__OFFSET__SHIFT | 458 VCN_JPEG_DB_CTRL__EN_MASK); 459 460 if (adev->pg_flags & AMD_PG_SUPPORT_JPEG_DPG) { vvv CID 1583635: Code maintainability issues (UNUSED_VALUE) vvv Assigning value from "jpeg_v4_0_5_start_dpg_mode(adev, i, adev->jpeg.indirect_sram)" to "r" here, but that stored value is overwritten before it can be used. 461 r = jpeg_v4_0_5_start_dpg_mode(adev, i, adev->jpeg.indirect_sram); 462 continue; 463 } 464 465 /* disable power gating */ 466 r = jpeg_v4_0_5_disable_static_power_gating(adev, i); If this is a false positive, please let us know so we can mark it as such, or teach the Coverity rules to be smarter. If not, please make sure fixes get into linux-next. :) For patches fixing this, please include these lines (but double-check the "Fixes" first): Reported-by: coverity-bot Addresses-Coverity-ID: 1583635 ("Code maintainability issues") Fixes: 0a119d53f74a ("drm/amdgpu/jpeg: add support for jpeg DPG mode") Thanks for your attention! -- Coverity-bot