From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 789B5136666 for ; Thu, 7 Mar 2024 19:32:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709839948; cv=none; b=KPbmTaOcoF1mf9FNXrkIaNOrCDDPKO/gaGjIAfIFGM4b83cq9ImkCNuN4f8dXyBggEB6SszTzyQURUEUsImtWi+g9sqtXzTyn6aSrHRhgOfhn67TTZgEG6y7Kb1xEDo6Xld/scLwwtmn5klTlNATCCKNDqzzdhUXq709+QIo6E0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709839948; c=relaxed/simple; bh=7GcxakZLq2oKSdXj+ofXzEBmRC7bzIxUkfqgxs8FG00=; h=From:Date:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=EcHs/qPJ+2GL8geBCrseoJDc6EIcrKwjbHuNHZLZpiVW/9HBPP/ahznl9xG67lK6cCzWblBvIj8ix3/WVTIxNeEIGRRydKHoM3/aTxokdEfB4xMQ+c2pV4A7wIvHV6FRK1yj+h7nPbD6/fEAa9heJHkocp8aUGkMjHIRDpHNyfE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=H35LTl9r; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="H35LTl9r" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-5d8b887bb0cso1027042a12.2 for ; Thu, 07 Mar 2024 11:32:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1709839946; x=1710444746; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:date:from :from:to:cc:subject:date:message-id:reply-to; bh=N9qoSXzYZPN9ruMFhEGa01LS4BMnI7rAvWb4nFTzmXc=; b=H35LTl9rrbmwdPzJ9BEr5gsW4yRvPb0B1ueFvVOAbbFCM1oOUGvMzXBIBjTaInzwOZ p1FgntUUc1QUgw45r9wD1UyX3tBagKyGJDc7/EqCUuAgNBWsLfkyFwlJiabT7weDLDb+ NjOG3U5WmJKpZcGN2Mft/gDtzpUx7IA18poQE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709839946; x=1710444746; h=content-disposition:mime-version:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N9qoSXzYZPN9ruMFhEGa01LS4BMnI7rAvWb4nFTzmXc=; b=cgJ4bH2OVrSXTuyuIUgG8KHx30V/nt+q0Gcg4KNEtN4WdfjEmgzwwx2KWKB9B6hQgS 6TFWEa7nfiu/oy7TouidHiLfGJ0+PcItIfZKKwNkZYmYy3mssF5KT4whept4XMjGPhXz VS8b/SjhzdPM4sYqMZCpqv/wcjunzxfzCZEuI1LFnedjhNpzZzpRFpdYOcOINfYAXXyQ NJzZElZXo86FkXFj78WSBhGGdkJLQvpWgdleLxQUVsE0jIt6fZuXmgatVG2E+lFbXsqT sgSWVzzQGIYxGjQmQemskX1GmS0pyfrrjTlo8aJYCCJBd6CYrQR1/McgquWJkNJz60+A g/fg== X-Forwarded-Encrypted: i=1; AJvYcCUwl8dOeJsTPzuR+1qyaVLCaGVxijCjkujHGJfeNv1fVOg4jLZ1m0Dv/JFxfTU0hErjurnDM7ZYlU7fE3zRVh0ZF/lGpGw4+6E/Xg== X-Gm-Message-State: AOJu0YxSmAsy9QA3wnu86SKe87KeNHGc14+aVlY2zV7UGc5mFKQjswiE LS3U3aII3g37hKEbZkimKFuAocXULGKiohYBNjgCIu0h7CQdRH+u0dj6O1IZAw== X-Google-Smtp-Source: AGHT+IGOLBi4Qz9QnVx9qVdy304kZfGTtm1ed+Ruod8ne2tyM8cAlmd20ukwkMkoXTBqPPYmDqQq1w== X-Received: by 2002:a17:90b:24d:b0:29b:9c8f:5ea2 with SMTP id fz13-20020a17090b024d00b0029b9c8f5ea2mr1766760pjb.40.1709839945732; Thu, 07 Mar 2024 11:32:25 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id h24-20020a17090adb9800b0029a849e7268sm1908119pjv.28.2024.03.07.11.32.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 11:32:25 -0800 (PST) From: coverity-bot X-Google-Original-From: coverity-bot Date: Thu, 7 Mar 2024 11:32:24 -0800 To: Edward Adam Davis Cc: linux-rdma@vger.kernel.org, Eric Dumazet , syzbot+d4faee732755bba9838e@syzkaller.appspotmail.com, "David S. Miller" , Allison Henderson , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, rds-devel@oss.oracle.com, "Gustavo A. R. Silva" , linux-next@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Coverity: __rds_rdma_map(): Null pointer dereferences Message-ID: <202403071132.37BBF46E@keescook> Precedence: bulk X-Mailing-List: linux-next@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hello! This is an experimental semi-automated report about issues detected by Coverity from a scan of next-20240307 as part of the linux-next scan project: https://scan.coverity.com/projects/linux-next-weekly-scan You're getting this email because you were associated with the identified lines of code (noted below) that were touched by commits: Wed Mar 6 11:58:42 2024 +0000 c055fc00c07b ("net/rds: fix WARNING in rds_conn_connect_if_down") Coverity reported the following: *** CID 1584247: Null pointer dereferences (FORWARD_NULL) net/rds/rdma.c:306 in __rds_rdma_map() 300 unpin_user_pages(pages, nr_pages); 301 kfree(sg); 302 } 303 ret = PTR_ERR(trans_private); 304 /* Trigger connection so that its ready for the next retry */ 305 if (ret == -ENODEV) vvv CID 1584247: Null pointer dereferences (FORWARD_NULL) vvv Dereferencing null pointer "cp". 306 rds_conn_connect_if_down(cp->cp_conn); 307 goto out; 308 } 309 310 mr->r_trans_private = trans_private; 311 If this is a false positive, please let us know so we can mark it as such, or teach the Coverity rules to be smarter. If not, please make sure fixes get into linux-next. :) For patches fixing this, please include these lines (but double-check the "Fixes" first): Reported-by: coverity-bot Addresses-Coverity-ID: 1584247 ("Null pointer dereferences") Fixes: c055fc00c07b ("net/rds: fix WARNING in rds_conn_connect_if_down") Thanks for your attention! -- Coverity-bot