From: Juergen Gross <jgross@suse.com>
To: Eial Czerwacki <eial@scalemp.com>, LKML <linux-kernel@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Randy Dunlap <rdunlap@infradead.org>,
"Shai Fultheim (Shai@ScaleMP.com)" <Shai@ScaleMP.com>,
Andrew Morton <akpm@linux-foundation.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"mhocko@suse.cz" <mhocko@suse.cz>,
Stephen Rothwell <sfr@canb.auug.org.au>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"mm-commits@vger.kernel.org" <mm-commits@vger.kernel.org>,
X86 ML <x86@kernel.org>, Oren Twaig <oren@scalemp.com>
Subject: Re: [PATCH v2] x86/build: Build VSMP support only if CONFIG_PCI is selected
Date: Fri, 2 Nov 2018 08:13:07 +0100 [thread overview]
Message-ID: <2073effd-4f02-c784-ca71-69ba49f51b88@suse.com> (raw)
In-Reply-To: <2130cd90-2c8f-2fc4-0ac8-81a5aea153b2@scalemp.com>
On 01/11/2018 19:27, Eial Czerwacki wrote:
> vsmp dependency on pv_irq_ops removed some years ago, so now let's clean
> it up from vsmp_64.c.
>
> In short, "cap & ctl & (1 << 4)" was always returning 0, as such we can
> remove all the PARAVIRT/PARAVIRT_XXL code handling that.
>
> However, the rest of the code depends on CONFIG_PCI, so fix it accordingly.
> in addition, rename set_vsmp_pv_ops to set_vsmp_ctl.
>
> Signed-off-by: Eial Czerwacki <eial@scalemp.com>
> Acked-by: Shai Fultheim <shai@scalemp.com>
While I'm still thinking selection of HYPERVISOR_GUEST and PARAVIRT
is a little bit strange, you can add:
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
next prev parent reply other threads:[~2018-11-02 7:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 18:27 [PATCH v2] x86/build: Build VSMP support only if CONFIG_PCI is selected Eial Czerwacki
2018-11-02 7:13 ` Juergen Gross [this message]
2018-11-04 21:05 ` Thomas Gleixner
2018-11-05 6:39 ` Eial Czerwacki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2073effd-4f02-c784-ca71-69ba49f51b88@suse.com \
--to=jgross@suse.com \
--cc=Shai@ScaleMP.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=eial@scalemp.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=mm-commits@vger.kernel.org \
--cc=oren@scalemp.com \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).