From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: linux-next: build failure after merge of the block tree Date: Wed, 28 Jun 2017 08:01:20 -0600 Message-ID: <2bd17edb-4a5b-5bf8-7074-1156a5249325@kernel.dk> References: <20170628180456.30cb9242@canb.auug.org.au> <664cc88d-18a5-18c4-5bce-4d4352d15f4f@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <664cc88d-18a5-18c4-5bce-4d4352d15f4f@kernel.dk> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Stephen Rothwell Cc: Linux-Next Mailing List , Linux Kernel Mailing List , "Martin K. Petersen" , Michael Ellerman , Benjamin Herrenschmidt , PowerPC List-Id: linux-next.vger.kernel.org On 06/28/2017 06:43 AM, Jens Axboe wrote: > On 06/28/2017 02:04 AM, Stephen Rothwell wrote: >> Hi Jens, >> >> After merging the block tree, today's linux-next build (powerpc >> allnoconfig) failed like this: >> >> fs/fcntl.o: In function `do_fcntl': >> fcntl.c:(.text+0x6d4): undefined reference to `__get_user_bad' >> fcntl.c:(.text+0x730): undefined reference to `__get_user_bad' >> >> Probably caused by commit >> >> c75b1d9421f8 ("fs: add fcntl() interface for setting/getting write life time hints") >> >> On powerpc (at least) you cannot use get_user() to fetch anything larger >> than "unsigned long" i.e. 32 bits on 32 bit powerpc. >> >> This has been discussed before (and, I think, a fix attempted). > > Gah, thanks for letting me know. I'll test your patch and queue it > up to fix this issue. But put_user() is fine? Just checking here, since the change adds both a u64 put and get user. -- Jens Axboe