linux-next: Fixes tag needs some work in the drm-fixes tree

linux-next: Fixes tag needs some work in the drm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 371 bytes --]

Hi all,

n commit

  64d17f25dcad ("drm/nouveau: Fix drm-core using atomic code-paths on pre-nv50 hardware")

Fixes tag

  Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1706557

has these problem(s):

  - No SHA1 recognised

I haven't seen a Fixes tag with a bug URL before, they usually reference
the buggy commit.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the drm-fixes tree

[Hans de Goede]

Hi,

On 12-12-2019 12:52, Stephen Rothwell wrote:
> Hi all,
> 
> n commit
> 
>    64d17f25dcad ("drm/nouveau: Fix drm-core using atomic code-paths on pre-nv50 hardware")
> 
> Fixes tag
> 
>    Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1706557
> 
> has these problem(s):
> 
>    - No SHA1 recognised
> 
> I haven't seen a Fixes tag with a bug URL before, they usually reference
> the buggy commit.

Sorry my bad, that should have been a BugLink tag. The patch in question is a bugfix,
but it is sorta hard to pinpoint the cause to a specific commit, this problem was
probably introduced during the conversion of nouveau to support atomic modesetting,
which is quite a while ago and involves lots of patches.

Not sure how to best fix this since fixing would require rewriting history. I hope this
is just something we can live with?

Regards,

Hans

linux-next: Fixes tag needs some work in the drm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 441 bytes --]

Hi all,

In commit

  ec8f1813bf8d ("drm/msm/a6xx: Replace kcalloc() with kvzalloc()")

Fixes tag

  Fixes: b859f9b009b (drm/msm/gpu: Snapshot GMU debug buffer)

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the drm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

Hi all,

In commit

  654e9c18dfab ("drm/msm: Fix crash on dev file close")

Fixes tag

  Fixes: 86c2a0f000c1 drm/msm: ("Small submitqueue creation cleanup")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the drm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 406 bytes --]

Hi all,

In commit

  65d437b83b2b ("drm/amdgpu/pm: fix the fan speed in fan1_input in manual mode for navi1x")

Fixes tag

  Fixes: 3033e9f1c2de ("drm/amdgpu/swsmu: handle manual fan readback on SMU11")

has these problem(s):

  - Target SHA1 does not exist

Mayne you meant

Fixes: f6eb433954bf ("drm/amdgpu/swsmu: handle manual fan readback on SMU11")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the drm-fixes tree

[Daniel Vetter]

On Mon, Jul 27, 2020 at 3:38 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   163d5446c37a ("drm/nouveau/disp/gm200-: fix regression from HDA SOR selection changes")
>
> Fixes tag
>
>   Fixes: 9b5ca547bb8 ("drm/nouveau/disp/gm200-: detect and potentially disable HDA support on some SORs")
>
> has these problem(s):
>
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").

Hm dim (our scripting) should be checking for this already, I've added
that after the last big round of malformed Fixes lines we've had ...
Dave, overuse of dim -f in your history?
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

linux-next: Fixes tag needs some work in the drm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

Hi all,

In commit

  163d5446c37a ("drm/nouveau/disp/gm200-: fix regression from HDA SOR selection changes")

Fixes tag

  Fixes: 9b5ca547bb8 ("drm/nouveau/disp/gm200-: detect and potentially disable HDA support on some SORs")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the drm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

Hi all,

In commit

  137caa702f23 ("drm/imx: ipuv3-plane: fix atomic update status query for non-plus i.MX6Q")

Fixes tag

  Fixes: 70e8a0c71e9 ("drm/imx: ipuv3-plane: add function to query atomic update status")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the drm-fixes tree

[Daniel Vetter]

Hi all,

On Wed, Apr 17, 2019 at 11:47 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   453393369dc9 ("drm/ttm: fix incrementing the page pointer for huge pages")
>
> Fixes tag
>
>   Fixes: e16858a7e6e7 drm/ttm: fix start page for huge page check in ttm_put_pages()
>
> has these problem(s):
>
>   - Target SHA1 does not exist
>
> Did you mean
>
> Fixes: ac1e516d5a4c ("drm/ttm: fix start page for huge page check in ttm_put_pages()")

Uh, our tooling should have caught this, and more:

dim: WARNING: Issues in pull request detected, but continuing dry-run
dim: b575f10dbd6f ("drm/amdgpu: shadow in shadow_list without
tbo.mem.start cause page fault in sriov TDR"): author Signed-off-by
missing.

^^ Wentao Lou should fix their git author, it looks a bit more like a
login id than a proper name

dim: 453393369dc9 ("drm/ttm: fix incrementing the page pointer for
huge pages"): SHA1 in fixes line not found:
dim:     e16858a7e6e7 drm/ttm: fix start page for huge page check in
ttm_put_pages()

^^ There we are.

dim: WARNING: issues in commits detected, but continuing dry-run

Dave, maybe drop the default dim -f you probably have in your history
somewhere :-)
Alex, another excuse to at lest copypaste the checks from dim? Or push
your tree using dim first, for these checks (you can still do all the
internal tree dancing for whatever reasons).
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

linux-next: Fixes tag needs some work in the drm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 402 bytes --]

Hi all,

In commit

  453393369dc9 ("drm/ttm: fix incrementing the page pointer for huge pages")

Fixes tag

  Fixes: e16858a7e6e7 drm/ttm: fix start page for huge page check in ttm_put_pages()

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: ac1e516d5a4c ("drm/ttm: fix start page for huge page check in ttm_put_pages()")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the drm-fixes tree

[Heiko Stübner]

Am Freitag, 8. Februar 2019, 12:40:22 CET schrieb Stephen Rothwell:
> Hi Heiko,
> 
> On Fri, 08 Feb 2019 12:31:38 +0100 Heiko Stübner <heiko@sntech.de> wrote:
> > we had this warning already from the drm-misc-fixes tree :-) .
> 
> Sorry about that ... there goes my memory again :-)

No worries :-D ... I don't really expect you to remember
thousands of commits individually :-) .

Re: linux-next: Fixes tag needs some work in the drm-fixes tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 247 bytes --]

Hi Heiko,

On Fri, 08 Feb 2019 12:31:38 +0100 Heiko Stübner <heiko@sntech.de> wrote:
>
> we had this warning already from the drm-misc-fixes tree :-) .

Sorry about that ... there goes my memory again :-)

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: linux-next: Fixes tag needs some work in the drm-fixes tree

[Heiko Stübner]

Am Freitag, 8. Februar 2019, 12:01:37 CET schrieb Stephen Rothwell:
> Hi all,
> 
> In commit
> 
>   053ff09f1a8f ("drm/rockchip: rgb: update SPDX license identifier")
> 
> Fixes tag
> 
>   Fixes: 1f0f01515172 ("Add support for Rockchip Soc RGB output interface")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject

we had this warning already from the drm-misc-fixes tree :-) .

And the drm-* history is very much fixed (due to it being a shared tree)
so we'll probably have to live with that mistake I made (missing the
"drm/rockchip:" prefix from the subject). But as I said the other time,
it should hopefully be still be identifiable.


Heiko





_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

linux-next: Fixes tag needs some work in the drm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

Hi all,

In commit

  053ff09f1a8f ("drm/rockchip: rgb: update SPDX license identifier")

Fixes tag

  Fixes: 1f0f01515172 ("Add support for Rockchip Soc RGB output interface")

has these problem(s):

  - Subject does not match target commit subject

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the drm-fixes tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 302 bytes --]

Hi all,

In commit

  dddce8b49005 ("drm/amd/display: Only get the connector state for VRR when toggled")

Fixes tag

  Fixes: 3cc22f281318 ("drm/amdgpu: Set FreeSync state using drm VRR properties")

has these problem(s):

  - Target SHA1 does not exist

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel