From: "Wan, Kaike" <kaike.wan@intel.com>
To: Doug Ledford <dledford@redhat.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Jason Gunthorpe <jgg@mellanox.com>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Kees Cook <keescook@chromium.org>
Subject: RE: linux-next: build warning after merge of the rdma tree
Date: Thu, 14 Feb 2019 12:35:34 +0000 [thread overview]
Message-ID: <3F128C9216C9B84BB6ED23EF16290AFB750DA68D@CRSMSX101.amr.corp.intel.com> (raw)
In-Reply-To: <86f77ecfe862e224149ada80dd5b5650280c74ec.camel@redhat.com>
> -----Original Message-----
> From: Doug Ledford [mailto:dledford@redhat.com]
> Sent: Wednesday, February 13, 2019 7:21 PM
> To: Stephen Rothwell <sfr@canb.auug.org.au>; Jason Gunthorpe
> <jgg@mellanox.com>
> Cc: Linux Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel
> Mailing List <linux-kernel@vger.kernel.org>; Wan, Kaike
> <kaike.wan@intel.com>; Gustavo A. R. Silva <gustavo@embeddedor.com>;
> Kees Cook <keescook@chromium.org>
> Subject: Re: linux-next: build warning after merge of the rdma tree
>
> On Thu, 2019-02-14 at 11:18 +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the rdma tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> >
> > drivers/infiniband/hw/hfi1/qp.c: In function 'hfi1_setup_wqe':
> > drivers/infiniband/hw/hfi1/qp.c:328:3: warning: this statement may fall
> through [-Wimplicit-fallthrough=]
> > hfi1_setup_tid_rdma_wqe(qp, wqe);
> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > drivers/infiniband/hw/hfi1/qp.c:329:2: note: here
> > case IB_QPT_UC:
> > ^~~~
> >
> > Introduced by commit
> >
> > f1ab4efa6d32 ("IB/hfi1: Enable TID RDMA READ protocol")
> >
> > I get this warning because I am building with -Wimplicit-fallthrough
> > in attempt to catch new additions early. The gcc warning can be
> > turned off by adding a /* fall through */ comment at the point the
> > fall through happens (assuming that the fall through is intentional).
> >
>
> Thanks Stephen, we'll sort it and make an appropriate fixup patch.
>
> Kaike?
It's intentional. We will add a "/* fall through */" comment as a fixup patch.
Kaike
>
> --
> Doug Ledford <dledford@redhat.com>
> GPG KeyID: B826A3330E572FDD
> Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
next prev parent reply other threads:[~2019-02-14 12:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 0:18 linux-next: build warning after merge of the rdma tree Stephen Rothwell
2019-02-14 0:21 ` Doug Ledford
2019-02-14 12:35 ` Wan, Kaike [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-02-10 10:11 Stephen Rothwell
2021-02-10 13:47 ` Jason Gunthorpe
2021-02-10 17:17 ` Nathan Chancellor
2021-02-10 22:08 ` Lee Jones
2020-12-03 7:42 Stephen Rothwell
2020-12-03 9:39 ` Leon Romanovsky
2019-02-14 0:23 Stephen Rothwell
2018-07-26 0:55 Stephen Rothwell
2018-07-26 3:05 ` Jason Gunthorpe
2018-07-26 5:10 ` Bart Van Assche
2018-07-26 17:38 ` Jason Gunthorpe
2018-07-10 1:28 Stephen Rothwell
2018-05-06 23:44 Stephen Rothwell
2018-05-14 18:03 ` Jason Gunthorpe
2018-05-14 18:09 ` Steve Wise
2018-05-14 20:29 ` Steve Wise
2018-05-06 23:40 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F128C9216C9B84BB6ED23EF16290AFB750DA68D@CRSMSX101.amr.corp.intel.com \
--to=kaike.wan@intel.com \
--cc=dledford@redhat.com \
--cc=gustavo@embeddedor.com \
--cc=jgg@mellanox.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).