From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6183C34026 for ; Tue, 18 Feb 2020 11:53:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 771182173E for ; Tue, 18 Feb 2020 11:53:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726363AbgBRLx0 (ORCPT ); Tue, 18 Feb 2020 06:53:26 -0500 Received: from relay.sw.ru ([185.231.240.75]:46434 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726206AbgBRLxZ (ORCPT ); Tue, 18 Feb 2020 06:53:25 -0500 Received: from dhcp-172-16-24-104.sw.ru ([172.16.24.104]) by relay.sw.ru with esmtp (Exim 4.92.3) (envelope-from ) id 1j41R8-0003sQ-HT; Tue, 18 Feb 2020 14:53:10 +0300 Subject: Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9 To: Sachin Sant , Andrew Morton Cc: Linux-Next Mailing List , linuxppc-dev@lists.ozlabs.org, Michal Hocko References: <3381CD91-AB3D-4773-BA04-E7A072A63968@linux.vnet.ibm.com> From: Kirill Tkhai Message-ID: <3b37d94d-2ac4-6b5d-ee8a-eb98cc7f6e5d@virtuozzo.com> Date: Tue, 18 Feb 2020 14:53:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On 18.02.2020 14:38, Sachin Sant wrote: > > >> On 18-Feb-2020, at 4:20 PM, Kirill Tkhai wrote: >> >> Hi, Sachin, >> >> On 18.02.2020 13:45, Sachin Sant wrote: >>> >>> commit a75056fc1e7c >>> mm/memcontrol.c: allocate shrinker_map on appropriate NUMA node >>> >>> I can boot the kernel successfully if the patch is reverted. >> >> >> could you please test your boot with original patch from here: >> >> https://patchwork.kernel.org/patch/11360007/ >> >> ? > With this original patch I can boot the machine successfully. Ok, thanks. I think, there is no a problem in the commited patch, since mem_cgroup_css_alloc() is called from the place, where any memory allocations have to be allowed. This is one of the reason, memory_cgrp_subsys.early_init is 0, and all nodes allocations should be availeble there. The problem is not in vmalloc() itself, since the second patch with kmalloc_node() also fails on your setup. Maybe, the reproduction depends on amount of allocated memory. For me this looks like a problem in powerpc, but it would be interesting to hear some comments from powerpc guys. For now we may replace the commited patch with v2 (https://patchwork.kernel.org/patch/11360007/) containing workaround, which we have in another alloc_mem_cgroup_per_node_info() allocations. Kirill