Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* Re: linux-next: build warning after merge of the scsi tree
       [not found] <20180620132911.5f6ab464@canb.auug.org.au>
@ 2018-07-10  7:31 ` Stephen Rothwell
  2018-07-10 14:09   ` Jens Axboe
  0 siblings, 1 reply; 46+ messages in thread
From: Stephen Rothwell @ 2018-07-10  7:31 UTC (permalink / raw)
  To: James Bottomley
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Matthew Wilcox, Martin K. Petersen, Jens Axboe, Felipe Balbi,
	Omar Sandoval

[-- Attachment #1: Type: text/plain, Size: 2490 bytes --]

Hi all,

On Wed, 20 Jun 2018 13:29:10 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the scsi tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
> 
> In file included from include/target/target_core_base.h:7:0,
>                  from drivers/target/target_core_tmr.c:31:
> include/linux/sbitmap.h:331:46: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>  void sbitmap_show(struct sbitmap *sb, struct seq_file *m);
>                                               ^~~~~~~~
> include/linux/sbitmap.h:342:53: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>  void sbitmap_bitmap_show(struct sbitmap *sb, struct seq_file *m);
>                                                      ^~~~~~~~
> include/linux/sbitmap.h:530:59: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>  void sbitmap_queue_show(struct sbitmap_queue *sbq, struct seq_file *m);
>                                                            ^~~~~~~~
> In file included from include/target/target_core_base.h:7:0,
>                  from drivers/target/target_core_ua.c:30:
> include/linux/sbitmap.h:331:46: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>  void sbitmap_show(struct sbitmap *sb, struct seq_file *m);
>                                               ^~~~~~~~
> include/linux/sbitmap.h:342:53: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>  void sbitmap_bitmap_show(struct sbitmap *sb, struct seq_file *m);
>                                                      ^~~~~~~~
> include/linux/sbitmap.h:530:59: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>  void sbitmap_queue_show(struct sbitmap_queue *sbq, struct seq_file *m);
>                                                            ^~~~~~~~
> 
> Introduced by commit
> 
>   24af1ccfe12a ("sbitmap: add helpers for dumping to a seq_file")
> 
> in v4.11.rc1, but exposed by commit
> 
>   eca7ee1f33e8 ("scsi: target: Convert target drivers to use sbitmap")

I am still seeing these warnings ...

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: linux-next: build warning after merge of the scsi tree
  2018-07-10  7:31 ` linux-next: build warning after merge of the scsi tree Stephen Rothwell
@ 2018-07-10 14:09   ` Jens Axboe
  2018-07-10 14:14     ` James Bottomley
  0 siblings, 1 reply; 46+ messages in thread
From: Jens Axboe @ 2018-07-10 14:09 UTC (permalink / raw)
  To: Stephen Rothwell, James Bottomley
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Matthew Wilcox, Martin K. Petersen, Felipe Balbi, Omar Sandoval

On 7/10/18 1:31 AM, Stephen Rothwell wrote:
> Hi all,
> 
> On Wed, 20 Jun 2018 13:29:10 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> After merging the scsi tree, today's linux-next build (powerpc
>> allyesconfig) produced this warning:
>>
>> In file included from include/target/target_core_base.h:7:0,
>>                  from drivers/target/target_core_tmr.c:31:
>> include/linux/sbitmap.h:331:46: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>>  void sbitmap_show(struct sbitmap *sb, struct seq_file *m);
>>                                               ^~~~~~~~
>> include/linux/sbitmap.h:342:53: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>>  void sbitmap_bitmap_show(struct sbitmap *sb, struct seq_file *m);
>>                                                      ^~~~~~~~
>> include/linux/sbitmap.h:530:59: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>>  void sbitmap_queue_show(struct sbitmap_queue *sbq, struct seq_file *m);
>>                                                            ^~~~~~~~
>> In file included from include/target/target_core_base.h:7:0,
>>                  from drivers/target/target_core_ua.c:30:
>> include/linux/sbitmap.h:331:46: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>>  void sbitmap_show(struct sbitmap *sb, struct seq_file *m);
>>                                               ^~~~~~~~
>> include/linux/sbitmap.h:342:53: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>>  void sbitmap_bitmap_show(struct sbitmap *sb, struct seq_file *m);
>>                                                      ^~~~~~~~
>> include/linux/sbitmap.h:530:59: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>>  void sbitmap_queue_show(struct sbitmap_queue *sbq, struct seq_file *m);
>>                                                            ^~~~~~~~
>>
>> Introduced by commit
>>
>>   24af1ccfe12a ("sbitmap: add helpers for dumping to a seq_file")
>>
>> in v4.11.rc1, but exposed by commit
>>
>>   eca7ee1f33e8 ("scsi: target: Convert target drivers to use sbitmap")
> 
> I am still seeing these warnings ...

Martin queued up the forward declaration patch for this one, not sure
why it isn't showing up in the scsi tree yet.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: linux-next: build warning after merge of the scsi tree
  2018-07-10 14:09   ` Jens Axboe
@ 2018-07-10 14:14     ` James Bottomley
  2018-07-10 14:22       ` Jens Axboe
  0 siblings, 1 reply; 46+ messages in thread
From: James Bottomley @ 2018-07-10 14:14 UTC (permalink / raw)
  To: Jens Axboe, Stephen Rothwell
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Matthew Wilcox, Martin K. Petersen, Felipe Balbi, Omar Sandoval

On Tue, 2018-07-10 at 08:09 -0600, Jens Axboe wrote:
> On 7/10/18 1:31 AM, Stephen Rothwell wrote:
[...]
> > I am still seeing these warnings ...
> 
> Martin queued up the forward declaration patch for this one, not sure
> why it isn't showing up in the scsi tree yet.

All the trees are fully up to date ... which commit is it?

James

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: linux-next: build warning after merge of the scsi tree
  2018-07-10 14:14     ` James Bottomley
@ 2018-07-10 14:22       ` Jens Axboe
  2018-07-10 14:26         ` James Bottomley
  0 siblings, 1 reply; 46+ messages in thread
From: Jens Axboe @ 2018-07-10 14:22 UTC (permalink / raw)
  To: James Bottomley, Stephen Rothwell
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Matthew Wilcox, Martin K. Petersen, Felipe Balbi, Omar Sandoval

On 7/10/18 8:14 AM, James Bottomley wrote:
> On Tue, 2018-07-10 at 08:09 -0600, Jens Axboe wrote:
>> On 7/10/18 1:31 AM, Stephen Rothwell wrote:
> [...]
>>> I am still seeing these warnings ...
>>
>> Martin queued up the forward declaration patch for this one, not sure
>> why it isn't showing up in the scsi tree yet.
> 
> All the trees are fully up to date ... which commit is it?

It's a patch from Arnd, I don't know what commit id it is. But
Martin replied a few days ago that it was applied. I don't have
the email handy, though.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: linux-next: build warning after merge of the scsi tree
  2018-07-10 14:22       ` Jens Axboe
@ 2018-07-10 14:26         ` James Bottomley
  2018-07-10 14:35           ` Jens Axboe
  0 siblings, 1 reply; 46+ messages in thread
From: James Bottomley @ 2018-07-10 14:26 UTC (permalink / raw)
  To: Jens Axboe, Stephen Rothwell
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Matthew Wilcox, Martin K. Petersen, Felipe Balbi, Omar Sandoval

On Tue, 2018-07-10 at 08:22 -0600, Jens Axboe wrote:
> On 7/10/18 8:14 AM, James Bottomley wrote:
> > On Tue, 2018-07-10 at 08:09 -0600, Jens Axboe wrote:
> > > On 7/10/18 1:31 AM, Stephen Rothwell wrote:
> > 
> > [...]
> > > > I am still seeing these warnings ...
> > > 
> > > Martin queued up the forward declaration patch for this one, not
> > > sure
> > > why it isn't showing up in the scsi tree yet.
> > 
> > All the trees are fully up to date ... which commit is it?
> 
> It's a patch from Arnd, I don't know what commit id it is. But
> Martin replied a few days ago that it was applied. I don't have
> the email handy, though.

You mean

Message-Id:	<20180706201920.2185565-1-arnd@arndb.de>
Subject:	[PATCH] [v2] sbitmap, scsi/target: add seq_file forward declaration

?

Martin didn't reply and it's not yet in his tree, although I'm sure it
will be soon.

James

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: linux-next: build warning after merge of the scsi tree
  2018-07-10 14:26         ` James Bottomley
@ 2018-07-10 14:35           ` Jens Axboe
  2018-07-10 15:08             ` Martin K. Petersen
  0 siblings, 1 reply; 46+ messages in thread
From: Jens Axboe @ 2018-07-10 14:35 UTC (permalink / raw)
  To: James Bottomley, Stephen Rothwell
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Matthew Wilcox, Martin K. Petersen, Felipe Balbi, Omar Sandoval

On 7/10/18 8:26 AM, James Bottomley wrote:
> On Tue, 2018-07-10 at 08:22 -0600, Jens Axboe wrote:
>> On 7/10/18 8:14 AM, James Bottomley wrote:
>>> On Tue, 2018-07-10 at 08:09 -0600, Jens Axboe wrote:
>>>> On 7/10/18 1:31 AM, Stephen Rothwell wrote:
>>>
>>> [...]
>>>>> I am still seeing these warnings ...
>>>>
>>>> Martin queued up the forward declaration patch for this one, not
>>>> sure
>>>> why it isn't showing up in the scsi tree yet.
>>>
>>> All the trees are fully up to date ... which commit is it?
>>
>> It's a patch from Arnd, I don't know what commit id it is. But
>> Martin replied a few days ago that it was applied. I don't have
>> the email handy, though.
> 
> You mean
> 
> Message-Id:	<20180706201920.2185565-1-arnd@arndb.de>
> Subject:	[PATCH] [v2] sbitmap, scsi/target: add seq_file forward declaration
> 
> ?
> 
> Martin didn't reply and it's not yet in his tree, although I'm sure it
> will be soon.

Yeah that's the one. I now had to look it up, looks like I mixed it up
with the host busy patch from Ming.

We should get it applied. Feel free to add my reviewed-by, if you want.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: linux-next: build warning after merge of the scsi tree
  2018-07-10 14:35           ` Jens Axboe
@ 2018-07-10 15:08             ` Martin K. Petersen
  0 siblings, 0 replies; 46+ messages in thread
From: Martin K. Petersen @ 2018-07-10 15:08 UTC (permalink / raw)
  To: Jens Axboe
  Cc: James Bottomley, Stephen Rothwell, Linux-Next Mailing List,
	Linux Kernel Mailing List, Matthew Wilcox, Martin K. Petersen,
	Felipe Balbi, Omar Sandoval


Jens,

>> Message-Id:	<20180706201920.2185565-1-arnd@arndb.de>
>> Subject:	[PATCH] [v2] sbitmap, scsi/target: add seq_file forward declaration

>> Martin didn't reply and it's not yet in his tree, although I'm sure it
>> will be soon.

Been out on vacation. I thought I committed it but I guess not. I'll get
to it today.

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: linux-next: build warning after merge of the scsi tree
  2019-11-07 15:51 ` Bart Van Assche
@ 2019-11-08 23:02   ` James Smart
  0 siblings, 0 replies; 46+ messages in thread
From: James Smart @ 2019-11-08 23:02 UTC (permalink / raw)
  To: Bart Van Assche, Stephen Rothwell, James Bottomley
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Martin K. Petersen, Dick Kennedy, James Smart

On 11/7/2019 7:51 AM, Bart Van Assche wrote:
> On 11/6/19 8:01 PM, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the scsi tree, today's linux-next build (powerpc
>> ppc64_defconfig) produced this warning:
>>
>> drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_cpumask_of_node_init':
>> drivers/scsi/lpfc/lpfc_init.c:6020:6: warning: the address of 
>> 'cpu_all_bits' will always evaluate as 'true' [-Waddress]
>>   6020 |  if (!cpumask_of_node(numa_node))
>>        |      ^
>>
>> Introduced by commit
>>
>>    dcaa21367938 ("scsi: lpfc: Change default IRQ model on AMD 
>> architectures")
> 
> Thanks Stephen for this report. A candidate fix has been posted: 
> https://lore.kernel.org/linux-scsi/20191107052158.25788-6-bvanassche@acm.org/T/#u 
> 
> 
> Bart.
> 
> 

See revised fix at:
https://marc.info/?l=linux-scsi&m=157325403920775&w=2

-- james

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: linux-next: build warning after merge of the scsi tree
  2019-11-07  4:01 Stephen Rothwell
@ 2019-11-07 15:51 ` Bart Van Assche
  2019-11-08 23:02   ` James Smart
  0 siblings, 1 reply; 46+ messages in thread
From: Bart Van Assche @ 2019-11-07 15:51 UTC (permalink / raw)
  To: Stephen Rothwell, James Bottomley
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, James Smart,
	Martin K. Petersen, Dick Kennedy

On 11/6/19 8:01 PM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the scsi tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_cpumask_of_node_init':
> drivers/scsi/lpfc/lpfc_init.c:6020:6: warning: the address of 'cpu_all_bits' will always evaluate as 'true' [-Waddress]
>   6020 |  if (!cpumask_of_node(numa_node))
>        |      ^
> 
> Introduced by commit
> 
>    dcaa21367938 ("scsi: lpfc: Change default IRQ model on AMD architectures")

Thanks Stephen for this report. A candidate fix has been posted: 
https://lore.kernel.org/linux-scsi/20191107052158.25788-6-bvanassche@acm.org/T/#u

Bart.



^ permalink raw reply	[flat|nested] 46+ messages in thread

* linux-next: build warning after merge of the scsi tree
@ 2019-11-07  4:01 Stephen Rothwell
  2019-11-07 15:51 ` Bart Van Assche
  0 siblings, 1 reply; 46+ messages in thread
From: Stephen Rothwell @ 2019-11-07  4:01 UTC (permalink / raw)
  To: James Bottomley
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, James Smart,
	Martin K. Petersen, Dick Kennedy

[-- Attachment #1: Type: text/plain, Size: 509 bytes --]

Hi all,

After merging the scsi tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_cpumask_of_node_init':
drivers/scsi/lpfc/lpfc_init.c:6020:6: warning: the address of 'cpu_all_bits' will always evaluate as 'true' [-Waddress]
 6020 |  if (!cpumask_of_node(numa_node))
      |      ^

Introduced by commit

  dcaa21367938 ("scsi: lpfc: Change default IRQ model on AMD architectures")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 46+ messages in thread

* linux-next: build warning after merge of the scsi tree
@ 2019-06-20  6:10 Stephen Rothwell
  0 siblings, 0 replies; 46+ messages in thread
From: Stephen Rothwell @ 2019-06-20  6:10 UTC (permalink / raw)
  To: James Bottomley
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Ming Lei,
	Martin K. Petersen

[-- Attachment #1: Type: text/plain, Size: 814 bytes --]

Hi all,

After merging the scsi tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from include/linux/pci-dma-compat.h:8,
                 from include/linux/pci.h:2408,
                 from drivers/scsi/mvumi.c:13:
drivers/scsi/mvumi.c: In function 'mvumi_queue_command':
include/linux/dma-mapping.h:608:34: warning: 'sg' may be used uninitialized in this function [-Wmaybe-uninitialized]
 #define dma_unmap_sg(d, s, n, r) dma_unmap_sg_attrs(d, s, n, r, 0)
                                  ^~~~~~~~~~~~~~~~~~
drivers/scsi/mvumi.c:192:22: note: 'sg' was declared here
  struct scatterlist *sg;
                      ^~

Introduced by commit

  350d66a72adc ("scsi: mvumi: use sg helper to iterate over scatterlist")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: linux-next: build warning after merge of the scsi tree
  2019-05-31  3:36 Stephen Rothwell
  2019-06-03 20:29 ` Tyrel Datwyler
@ 2019-06-03 23:37 ` Tyrel Datwyler
  1 sibling, 0 replies; 46+ messages in thread
From: Tyrel Datwyler @ 2019-06-03 23:37 UTC (permalink / raw)
  To: Stephen Rothwell, James Bottomley
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Martin K. Petersen

On 05/30/2019 08:36 PM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the scsi tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> drivers/scsi/ibmvscsi/ibmvscsi.c: In function 'ibmvscsi_work':
> drivers/scsi/ibmvscsi/ibmvscsi.c:2151:5: warning: 'rc' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   if (rc) {
>      ^
> drivers/scsi/ibmvscsi/ibmvscsi.c:2121:6: note: 'rc' was declared here
>   int rc;
>       ^~
> 
> Introduced by commit
> 
>   035a3c4046b5 ("scsi: ibmvscsi: redo driver work thread to use enum action states")
> 

Looks like somebody else noticed the warning and a proposed fix was already sent
out.

-Tyrel

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: linux-next: build warning after merge of the scsi tree
  2019-05-31  3:36 Stephen Rothwell
@ 2019-06-03 20:29 ` Tyrel Datwyler
  2019-06-03 23:37 ` Tyrel Datwyler
  1 sibling, 0 replies; 46+ messages in thread
From: Tyrel Datwyler @ 2019-06-03 20:29 UTC (permalink / raw)
  To: Stephen Rothwell, James Bottomley
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Martin K. Petersen

On 05/30/2019 08:36 PM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the scsi tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> drivers/scsi/ibmvscsi/ibmvscsi.c: In function 'ibmvscsi_work':
> drivers/scsi/ibmvscsi/ibmvscsi.c:2151:5: warning: 'rc' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   if (rc) {
>      ^
> drivers/scsi/ibmvscsi/ibmvscsi.c:2121:6: note: 'rc' was declared here
>   int rc;
>       ^~
> 
> Introduced by commit
> 
>   035a3c4046b5 ("scsi: ibmvscsi: redo driver work thread to use enum action states")
> 

Oof, looks like I didn't compile with pedantic enough options, or just didn't
notice the warning. Declaration should be "int rc = 0;". I can send a follow on
patch.

-Tyrel

^ permalink raw reply	[flat|nested] 46+ messages in thread

* linux-next: build warning after merge of the scsi tree
@ 2019-05-31  3:36 Stephen Rothwell
  2019-06-03 20:29 ` Tyrel Datwyler
  2019-06-03 23:37 ` Tyrel Datwyler
  0 siblings, 2 replies; 46+ messages in thread
From: Stephen Rothwell @ 2019-05-31  3:36 UTC (permalink / raw)
  To: James Bottomley
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Tyrel Datwyler, Martin K. Petersen

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]

Hi all,

After merging the scsi tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/scsi/ibmvscsi/ibmvscsi.c: In function 'ibmvscsi_work':
drivers/scsi/ibmvscsi/ibmvscsi.c:2151:5: warning: 'rc' may be used uninitialized in this function [-Wmaybe-uninitialized]
  if (rc) {
     ^
drivers/scsi/ibmvscsi/ibmvscsi.c:2121:6: note: 'rc' was declared here
  int rc;
      ^~

Introduced by commit

  035a3c4046b5 ("scsi: ibmvscsi: redo driver work thread to use enum action states")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: linux-next: build warning after merge of the scsi tree
  2019-04-05  4:30 ` Bart Van Assche
@ 2019-04-05  4:52   ` James Bottomley
  0 siblings, 0 replies; 46+ messages in thread
From: James Bottomley @ 2019-04-05  4:52 UTC (permalink / raw)
  To: Bart Van Assche, Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Martin K. Petersen

On Thu, 2019-04-04 at 21:30 -0700, Bart Van Assche wrote:
> On 4/4/19 8:25 PM, Stephen Rothwell wrote:
> > Hi James,
> > 
> > After merging the scsi tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> > 
> > drivers/scsi/lpfc/lpfc_nvme.c:2140:1: warning:
> > 'lpfc_nvme_lport_unreg_wait' defined but not used [-Wunused-
> > function]
> >   lpfc_nvme_lport_unreg_wait(struct lpfc_vport *vport,
> >   ^~~~~~~~~~~~~~~~~~~~~~~~~~
> > 
> > Introduced by commit
> > 
> >    3999df75bccb ("scsi: lpfc: Declare local functions static")
> > 
> > It use is guarded by IS_ENABLED(CONFIG_NVME_FC).
> 
> I will have a closer look at this tomorrow.

In the meantime, we can just revert the patch.  Making functions static
serves no real purpose except it does tell the compiler they have to be
used internally which is where the problem is coming from.  Once the
issue is sorted, the static patch can be reapplied.

James

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: linux-next: build warning after merge of the scsi tree
  2019-04-05  3:25 Stephen Rothwell
@ 2019-04-05  4:30 ` Bart Van Assche
  2019-04-05  4:52   ` James Bottomley
  0 siblings, 1 reply; 46+ messages in thread
From: Bart Van Assche @ 2019-04-05  4:30 UTC (permalink / raw)
  To: Stephen Rothwell, James Bottomley
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Martin K. Petersen

On 4/4/19 8:25 PM, Stephen Rothwell wrote:
> Hi James,
> 
> After merging the scsi tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> drivers/scsi/lpfc/lpfc_nvme.c:2140:1: warning: 'lpfc_nvme_lport_unreg_wait' defined but not used [-Wunused-function]
>   lpfc_nvme_lport_unreg_wait(struct lpfc_vport *vport,
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Introduced by commit
> 
>    3999df75bccb ("scsi: lpfc: Declare local functions static")
> 
> It use is guarded by IS_ENABLED(CONFIG_NVME_FC).

I will have a closer look at this tomorrow.

Bart.

^ permalink raw reply	[flat|nested] 46+ messages in thread

* linux-next: build warning after merge of the scsi tree
@ 2019-04-05  3:25 Stephen Rothwell
  2019-04-05  4:30 ` Bart Van Assche
  0 siblings, 1 reply; 46+ messages in thread
From: Stephen Rothwell @ 2019-04-05  3:25 UTC (permalink / raw)
  To: James Bottomley
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Bart Van Assche, Martin K. Petersen

[-- Attachment #1: Type: text/plain, Size: 497 bytes --]

Hi James,

After merging the scsi tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/scsi/lpfc/lpfc_nvme.c:2140:1: warning: 'lpfc_nvme_lport_unreg_wait' defined but not used [-Wunused-function]
 lpfc_nvme_lport_unreg_wait(struct lpfc_vport *vport,
 ^~~~~~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

  3999df75bccb ("scsi: lpfc: Declare local functions static")

It use is guarded by IS_ENABLED(CONFIG_NVME_FC).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: linux-next: build warning after merge of the scsi tree
  2018-10-19  4:54 ` James Bottomley
@ 2018-10-19  4:58   ` Stephen Rothwell
  0 siblings, 0 replies; 46+ messages in thread
From: Stephen Rothwell @ 2018-10-19  4:58 UTC (permalink / raw)
  To: James Bottomley
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Martin K. Petersen

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

Hi James,

On Thu, 18 Oct 2018 21:54:03 -0700 James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
>
> It's the merge commit ... it was obviously the wrong choice; I'll fix
> it.

OK, thanks.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: linux-next: build warning after merge of the scsi tree
  2018-10-19  4:50 Stephen Rothwell
@ 2018-10-19  4:54 ` James Bottomley
  2018-10-19  4:58   ` Stephen Rothwell
  0 siblings, 1 reply; 46+ messages in thread
From: James Bottomley @ 2018-10-19  4:54 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Martin K. Petersen

[-- Attachment #1: Type: text/plain, Size: 771 bytes --]

On Fri, 2018-10-19 at 15:50 +1100, Stephen Rothwell wrote:
> Hi James,
> 
> After merging the scsi tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> drivers/scsi/lpfc/lpfc_debugfs.c: In function
> 'lpfc_debugfs_nodelist_open':
> drivers/scsi/lpfc/lpfc_debugfs.c:706:17: warning: 'nrport' may be
> used uninitialized in this function [-Wmaybe-uninitialized]
>    switch (nrport->port_state) {
>            ~~~~~~^~~~~~~~~~~~
> drivers/scsi/lpfc/lpfc_debugfs.c:553:30: note: 'nrport' was declared
> here
>   struct nvme_fc_remote_port *nrport;
>                               ^~~~~~
> 
> I am not sure where this has come from :-(

It's the merge commit ... it was obviously the wrong choice; I'll fix
it.

James

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 46+ messages in thread

* linux-next: build warning after merge of the scsi tree
@ 2018-10-19  4:50 Stephen Rothwell
  2018-10-19  4:54 ` James Bottomley
  0 siblings, 1 reply; 46+ messages in thread
From: Stephen Rothwell @ 2018-10-19  4:50 UTC (permalink / raw)
  To: James Bottomley
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Martin K. Petersen

[-- Attachment #1: Type: text/plain, Size: 621 bytes --]

Hi James,

After merging the scsi tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/scsi/lpfc/lpfc_debugfs.c: In function 'lpfc_debugfs_nodelist_open':
drivers/scsi/lpfc/lpfc_debugfs.c:706:17: warning: 'nrport' may be used uninitialized in this function [-Wmaybe-uninitialized]
   switch (nrport->port_state) {
           ~~~~~~^~~~~~~~~~~~
drivers/scsi/lpfc/lpfc_debugfs.c:553:30: note: 'nrport' was declared here
  struct nvme_fc_remote_port *nrport;
                              ^~~~~~

I am not sure where this has come from :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: linux-next: build warning after merge of the scsi tree
  2018-04-18 21:52 ` Long Li
@ 2018-04-18 23:30   ` Martin K. Petersen
  0 siblings, 0 replies; 46+ messages in thread
From: Martin K. Petersen @ 2018-04-18 23:30 UTC (permalink / raw)
  To: Long Li
  Cc: Stephen Rothwell, James Bottomley, Linux-Next Mailing List,
	Linux Kernel Mailing List, Martin K. Petersen


Long,

> I will fix this by moving those data structure to kmalloc pre-allocated
> when channel is first created.

Sounds good. I'll drop patch 3 for now and wait for you to resubmit.

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 46+ messages in thread

* RE: linux-next: build warning after merge of the scsi tree
  2018-04-17  2:25 Stephen Rothwell
@ 2018-04-18 21:52 ` Long Li
  2018-04-18 23:30   ` Martin K. Petersen
  0 siblings, 1 reply; 46+ messages in thread
From: Long Li @ 2018-04-18 21:52 UTC (permalink / raw)
  To: Stephen Rothwell, James Bottomley
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Martin K. Petersen

> Subject: linux-next: build warning after merge of the scsi tree
> 
> Hi James,
> 
> After merging the scsi tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/scsi/storvsc_drv.c: In function 'storvsc_do_io':
> drivers/scsi/storvsc_drv.c:1402:1: warning: the frame size of 2216 bytes is
> larger than 2048 bytes [-Wframe-larger-than=]  }  ^
> 
> Introduced by commit
> 
>   0b9bc24b8304 ("csi: storvsc: Select channel based on available percentage of
> ring buffer to write")

Thanks for catching this. This is due to the size of struct cpumask is too big, when CONFIG_NR_CPUS=8192 is used in most kernel config.

I will fix this by moving those data structure to kmalloc pre-allocated when channel is first created.

> 
> --
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 46+ messages in thread

* linux-next: build warning after merge of the scsi tree
@ 2018-04-17  2:25 Stephen Rothwell
  2018-04-18 21:52 ` Long Li
  0 siblings, 1 reply; 46+ messages in thread
From: Stephen Rothwell @ 2018-04-17  2:25 UTC (permalink / raw)
  To: James Bottomley
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Long Li,
	Martin K. Petersen

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

Hi James,

After merging the scsi tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/scsi/storvsc_drv.c: In function 'storvsc_do_io':
drivers/scsi/storvsc_drv.c:1402:1: warning: the frame size of 2216 bytes is larger than 2048 bytes [-Wframe-larger-than=]
 }
 ^

Introduced by commit

  0b9bc24b8304 ("csi: storvsc: Select channel based on available percentage of ring buffer to write")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: linux-next: build warning after merge of the scsi tree
  2017-04-06  4:04 Stephen Rothwell
@ 2017-04-06  8:18 ` Fam Zheng
  0 siblings, 0 replies; 46+ messages in thread
From: Fam Zheng @ 2017-04-06  8:18 UTC (permalink / raw)
  To: James Bottomley, Stephen Rothwell
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List

On Thu, 04/06 14:04, Stephen Rothwell wrote:
> Hi James,
> 
> After merging the scsi tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> In file included from include/linux/list.h:8:0,
>                  from include/linux/module.h:9,
>                  from drivers/scsi/sd.c:35:
> drivers/scsi/sd.c: In function 'sd_revalidate_disk':
> include/linux/kernel.h:755:16: warning: comparison of distinct pointer types lacks a cast
>   (void) (&min1 == &min2);   \
>                 ^
> include/linux/kernel.h:758:2: note: in expansion of macro '__min'
>   __min(typeof(x), typeof(y),   \
>   ^
> include/linux/kernel.h:783:39: note: in expansion of macro 'min'
>   __x == 0 ? __y : ((__y == 0) ? __x : min(__x, __y)); })
>                                        ^
> drivers/scsi/sd.c:2959:12: note: in expansion of macro 'min_not_zero'
>    rw_max = min_not_zero(logical_to_sectors(sdp, dev_max),
>             ^
> 
> Introduced by commit
> 
>   c3e62673ee20 ("scsi: sd: Consider max_xfer_blocks if opt_xfer_blocks is unusable")
> 
> logical_to_sectors() is a sector_t and BLK_DEF_MAX_SECTORS is an "enum
> blk_default_limits" (i.e. int).

Hi Stephen, James,

I will send a patch to fix this warning.

Fam

^ permalink raw reply	[flat|nested] 46+ messages in thread

* linux-next: build warning after merge of the scsi tree
@ 2017-04-06  4:04 Stephen Rothwell
  2017-04-06  8:18 ` Fam Zheng
  0 siblings, 1 reply; 46+ messages in thread
From: Stephen Rothwell @ 2017-04-06  4:04 UTC (permalink / raw)
  To: James Bottomley
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Fam Zheng

Hi James,

After merging the scsi tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

In file included from include/linux/list.h:8:0,
                 from include/linux/module.h:9,
                 from drivers/scsi/sd.c:35:
drivers/scsi/sd.c: In function 'sd_revalidate_disk':
include/linux/kernel.h:755:16: warning: comparison of distinct pointer types lacks a cast
  (void) (&min1 == &min2);   \
                ^
include/linux/kernel.h:758:2: note: in expansion of macro '__min'
  __min(typeof(x), typeof(y),   \
  ^
include/linux/kernel.h:783:39: note: in expansion of macro 'min'
  __x == 0 ? __y : ((__y == 0) ? __x : min(__x, __y)); })
                                       ^
drivers/scsi/sd.c:2959:12: note: in expansion of macro 'min_not_zero'
   rw_max = min_not_zero(logical_to_sectors(sdp, dev_max),
            ^

Introduced by commit

  c3e62673ee20 ("scsi: sd: Consider max_xfer_blocks if opt_xfer_blocks is unusable")

logical_to_sectors() is a sector_t and BLK_DEF_MAX_SECTORS is an "enum
blk_default_limits" (i.e. int).

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: linux-next: build warning after merge of the scsi tree
  2016-11-22  7:44 Stephen Rothwell
@ 2016-11-22 22:24 ` Martin K. Petersen
  0 siblings, 0 replies; 46+ messages in thread
From: Martin K. Petersen @ 2016-11-22 22:24 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: James Bottomley, linux-next, linux-kernel, Hannes Reinecke,
	Martin K. Petersen

>>>>> "Stephen" == Stephen Rothwell <sfr@canb.auug.org.au> writes:

Stephen,

Stephen> drivers/scsi/hpsa.c: In function 'hpsa_slave_alloc':
Stephen> drivers/scsi/hpsa.c:2033:5: warning: 'sd' may be used
Stephen> uninitialized in this function [-Wmaybe-uninitialized]
Stephen>   if (!sd)
Stephen>      ^

Stephen> Introduced by commit

Stephen>   4eb307f7b18d ("scsi: hpsa: use bus '3' for legacy HBA
Stephen>   devices")

Fixed this up.

Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 46+ messages in thread

* linux-next: build warning after merge of the scsi tree
@ 2016-11-22  7:44 Stephen Rothwell
  2016-11-22 22:24 ` Martin K. Petersen
  0 siblings, 1 reply; 46+ messages in thread
From: Stephen Rothwell @ 2016-11-22  7:44 UTC (permalink / raw)
  To: James Bottomley
  Cc: linux-next, linux-kernel, Hannes Reinecke, Martin K. Petersen

Hi James,

After merging the scsi tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/scsi/hpsa.c: In function 'hpsa_slave_alloc':
drivers/scsi/hpsa.c:2033:5: warning: 'sd' may be used uninitialized in this function [-Wmaybe-uninitialized]
  if (!sd)
     ^

Introduced by commit

  4eb307f7b18d ("scsi: hpsa: use bus '3' for legacy HBA devices")

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: linux-next: build warning after merge of the scsi tree
  2016-09-13 14:09 ` Bryant G. Ly
@ 2016-09-15 13:55   ` Martin K. Petersen
  0 siblings, 0 replies; 46+ messages in thread
From: Martin K. Petersen @ 2016-09-15 13:55 UTC (permalink / raw)
  To: Bryant G. Ly
  Cc: Stephen Rothwell, James Bottomley, linux-next, linux-kernel,
	Martin K. Petersen, Michael Cyr

>>>>> "Bryant" == Bryant G Ly <bryantly@linux.vnet.ibm.com> writes:

Bryant> On 9/12/16, 11:15 PM, "Stephen Rothwell" <sfr@canb.auug.org.au> wrote:

>> Hi James,
>> 
>> After merging the scsi tree, today's linux-next build (powerpc
>> allyesconfig) produced this warning:
>> 
>> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function
>> 'ibmvscsis_rdma': drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3190:20:
>> warning: unused variable 'srp' [-Wunused-variable] struct srp_cmd
>> *srp = (struct srp_cmd *)iue->sbuf->buf; ^
>> 
>> Introduced by commit
>> 
>> 812902159d41 ("scsi: ibmvscsis: Code cleanup of print statements")
    
Bryant> Looks like cleaning up the print statement made this variable
Bryant> unused so deleting that line would be best.

Please submit a patch to do so.

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: linux-next: build warning after merge of the scsi tree
  2016-09-13  4:15 Stephen Rothwell
@ 2016-09-13 14:09 ` Bryant G. Ly
  2016-09-15 13:55   ` Martin K. Petersen
  0 siblings, 1 reply; 46+ messages in thread
From: Bryant G. Ly @ 2016-09-13 14:09 UTC (permalink / raw)
  To: Stephen Rothwell, James Bottomley
  Cc: linux-next, linux-kernel, Martin K. Petersen, Michael Cyr



On 9/12/16, 11:15 PM, "Stephen Rothwell" <sfr@canb.auug.org.au> wrote:

    > Hi James,
    > 
    > After merging the scsi tree, today's linux-next build (powerpc
    > allyesconfig) produced this warning:
    > 
    > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_rdma':
    > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3190:20: warning: unused variable 'srp' [-Wunused-variable]
    >     struct srp_cmd *srp = (struct srp_cmd *)iue->sbuf->buf;
    >                     ^
    > 
    > Introduced by commit
    > 
     >  812902159d41 ("scsi: ibmvscsis: Code cleanup of print statements")
    
Looks like cleaning up the print statement made this variable unused so deleting that line would be best. 

-Bryant     
    

^ permalink raw reply	[flat|nested] 46+ messages in thread

* linux-next: build warning after merge of the scsi tree
@ 2016-09-13  4:15 Stephen Rothwell
  2016-09-13 14:09 ` Bryant G. Ly
  0 siblings, 1 reply; 46+ messages in thread
From: Stephen Rothwell @ 2016-09-13  4:15 UTC (permalink / raw)
  To: James Bottomley
  Cc: linux-next, linux-kernel, Bryant G. Ly, Martin K. Petersen, Michael Cyr

Hi James,

After merging the scsi tree, today's linux-next build (powerpc
allyesconfig) produced this warning:

drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_rdma':
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3190:20: warning: unused variable 'srp' [-Wunused-variable]
    struct srp_cmd *srp = (struct srp_cmd *)iue->sbuf->buf;
                    ^

Introduced by commit

  812902159d41 ("scsi: ibmvscsis: Code cleanup of print statements")

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: linux-next: build warning after merge of the scsi tree
  2014-11-18  8:21 Stephen Rothwell
@ 2014-11-20  8:23 ` Christoph Hellwig
  0 siblings, 0 replies; 46+ messages in thread
From: Christoph Hellwig @ 2014-11-20  8:23 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: James Bottomley, linux-next, linux-kernel, Christoph Hellwig

On Tue, Nov 18, 2014 at 07:21:48PM +1100, Stephen Rothwell wrote:
> Hi James,
> 
> After merging the scsi tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
> 
> drivers/scsi/ibmvscsi/ibmvfc.c: In function 'ibmvfc_queuecommand_lck':
> drivers/scsi/ibmvscsi/ibmvfc.c:1618:5: warning: unused variable 'tag' [-Wunused-variable]
>   u8 tag[2];

Thanks Stephen, I'll take care of fixing this up.

^ permalink raw reply	[flat|nested] 46+ messages in thread

* linux-next: build warning after merge of the scsi tree
@ 2014-11-18  8:21 Stephen Rothwell
  2014-11-20  8:23 ` Christoph Hellwig
  0 siblings, 1 reply; 46+ messages in thread
From: Stephen Rothwell @ 2014-11-18  8:21 UTC (permalink / raw)
  To: James Bottomley; +Cc: linux-next, linux-kernel, Christoph Hellwig

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

Hi James,

After merging the scsi tree, today's linux-next build (powerpc
allyesconfig) produced this warning:

drivers/scsi/ibmvscsi/ibmvfc.c: In function 'ibmvfc_queuecommand_lck':
drivers/scsi/ibmvscsi/ibmvfc.c:1618:5: warning: unused variable 'tag' [-Wunused-variable]
  u8 tag[2];
     ^

Introduced by commit 5066863337af ("scsi: remove abuses of
scsi_populate_tag").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: linux-next: build warning after merge of the scsi tree
  2013-09-04  9:18 ` Sujit Reddy Thumma
@ 2013-09-04  9:54   ` Sujit Reddy Thumma
  0 siblings, 0 replies; 46+ messages in thread
From: Sujit Reddy Thumma @ 2013-09-04  9:54 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: James Bottomley, linux-next, linux-kernel, Santosh Y, Tejun Heo

On 9/4/2013 2:48 PM, Sujit Reddy Thumma wrote:
> On 9/2/2013 1:58 PM, Stephen Rothwell wrote:
>> Hi James,
>>
>> After merging the scsi tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
>>
>> drivers/scsi/ufs/ufshcd.c: In function 'ufshcd_eh_host_reset_handler':
>> drivers/scsi/ufs/ufshcd.c:2740:3: warning: 'flush_work_sync' is
>> deprecated (declared at
>> /scratch/sfr/next/include/linux/workqueue.h:624)
>> [-Wdeprecated-declarations]
>>     flush_work_sync(&hba->eh_work);
>>     ^
>
> James, would you like to pick up follow-up patch @
> http://marc.info/?l=linux-scsi&m=137819519527432&w=2
> or let me update the commit c1e846ab4422 fixing this?

Ignore this.
I saw you have dropped the patchset already. I will fix and post the
updated patches soon. Thanks.

>
>>
>> Introduced by commit c1e846ab4422 ("[SCSI] ufs: Fix device and host reset
>> methods").  flush_work_sync was deprecated by commit 43829731dd37
>> ("workqueue: deprecate flush[_delayed]_work_sync()") before v3.7-rc1.
>>
>

-- 
Regards,
Sujit

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: linux-next: build warning after merge of the scsi tree
  2013-09-02  8:28 Stephen Rothwell
@ 2013-09-04  9:18 ` Sujit Reddy Thumma
  2013-09-04  9:54   ` Sujit Reddy Thumma
  0 siblings, 1 reply; 46+ messages in thread
From: Sujit Reddy Thumma @ 2013-09-04  9:18 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: James Bottomley, linux-next, linux-kernel, Santosh Y, Tejun Heo

On 9/2/2013 1:58 PM, Stephen Rothwell wrote:
> Hi James,
>
> After merging the scsi tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/scsi/ufs/ufshcd.c: In function 'ufshcd_eh_host_reset_handler':
> drivers/scsi/ufs/ufshcd.c:2740:3: warning: 'flush_work_sync' is deprecated (declared at /scratch/sfr/next/include/linux/workqueue.h:624) [-Wdeprecated-declarations]
>     flush_work_sync(&hba->eh_work);
>     ^

James, would you like to pick up follow-up patch @
http://marc.info/?l=linux-scsi&m=137819519527432&w=2
or let me update the commit c1e846ab4422 fixing this?

>
> Introduced by commit c1e846ab4422 ("[SCSI] ufs: Fix device and host reset
> methods").  flush_work_sync was deprecated by commit 43829731dd37
> ("workqueue: deprecate flush[_delayed]_work_sync()") before v3.7-rc1.
>

-- 
Regards,
Sujit

^ permalink raw reply	[flat|nested] 46+ messages in thread

* linux-next: build warning after merge of the scsi tree
@ 2013-09-02  8:28 Stephen Rothwell
  2013-09-04  9:18 ` Sujit Reddy Thumma
  0 siblings, 1 reply; 46+ messages in thread
From: Stephen Rothwell @ 2013-09-02  8:28 UTC (permalink / raw)
  To: James Bottomley
  Cc: linux-next, linux-kernel, Sujit Reddy Thumma, Santosh Y, Tejun Heo

[-- Attachment #1: Type: text/plain, Size: 685 bytes --]

Hi James,

After merging the scsi tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/scsi/ufs/ufshcd.c: In function 'ufshcd_eh_host_reset_handler':
drivers/scsi/ufs/ufshcd.c:2740:3: warning: 'flush_work_sync' is deprecated (declared at /scratch/sfr/next/include/linux/workqueue.h:624) [-Wdeprecated-declarations]
   flush_work_sync(&hba->eh_work);
   ^

Introduced by commit c1e846ab4422 ("[SCSI] ufs: Fix device and host reset
methods").  flush_work_sync was deprecated by commit 43829731dd37
("workqueue: deprecate flush[_delayed]_work_sync()") before v3.7-rc1.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 46+ messages in thread

* linux-next: build warning after merge of the scsi tree
@ 2011-07-20  4:08 Stephen Rothwell
  0 siblings, 0 replies; 46+ messages in thread
From: Stephen Rothwell @ 2011-07-20  4:08 UTC (permalink / raw)
  To: James Bottomley; +Cc: linux-next, linux-kernel, Kashyap, Desai

[-- Attachment #1: Type: text/plain, Size: 515 bytes --]

Hi James,

After merging the scsi tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/scsi/mpt2sas/mpt2sas_scsih.c: In function '_scsih_sas_broadcast_primative_event':
drivers/scsi/mpt2sas/mpt2sas_scsih.c:5591:40: warning: unused variable 'event_data'

Probably introduced by commit f93213de5c28 ("[SCSI] mpt2sas: fix
broadcast AEN and task management issue").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: linux-next: build warning after merge of the scsi tree
  2011-05-19 16:22     ` Geert Uytterhoeven
@ 2011-06-23 17:02       ` Randy Dunlap
  0 siblings, 0 replies; 46+ messages in thread
From: Randy Dunlap @ 2011-06-23 17:02 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Stephen Rothwell, Nicholas A. Bellinger, James Bottomley,
	linux-next, linux-kernel, Kiran Patil, Joe Eykholt,
	Christoph Hellwig, Yi Zou

On Thu, 19 May 2011 18:22:59 +0200 Geert Uytterhoeven wrote:

> On Wed, May 18, 2011 at 05:58, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >> --- a/drivers/target/tcm_fc/tfc_io.c
> >> +++ b/drivers/target/tcm_fc/tfc_io.c
> >> @@ -206,7 +206,8 @@ int ft_queue_data_in(struct se_cmd *se_cmd)
> >>                                                 "xid <0x%x>, remaining <0x%x>, "
> >>                                                 "lso_max <0x%x>\n",
> >>                                                 __func__, fp, ep->xid,
> >> -                                               remaining, lport->lso_max);
> >> +                                               (unsigned int)remaining,
> >> +                                               lport->lso_max);
> >
> > Given that "remaining" really is a length, surely it makes more sense to
> 
> Exactly my comments ...
> 
> > print it with %zd than to cast it and print it with %x ...
> 
> ... except that size_t is unsigned, so %zu would be a little bit better.


This still needs to be fixed in linux-next (20110623).

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: linux-next: build warning after merge of the scsi tree
  2011-05-18  3:58   ` Stephen Rothwell
  2011-05-19  2:54     ` Nicholas A. Bellinger
@ 2011-05-19 16:22     ` Geert Uytterhoeven
  2011-06-23 17:02       ` Randy Dunlap
  1 sibling, 1 reply; 46+ messages in thread
From: Geert Uytterhoeven @ 2011-05-19 16:22 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Nicholas A. Bellinger, James Bottomley, linux-next, linux-kernel,
	Kiran Patil, Joe Eykholt, Christoph Hellwig, Yi Zou

On Wed, May 18, 2011 at 05:58, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>> --- a/drivers/target/tcm_fc/tfc_io.c
>> +++ b/drivers/target/tcm_fc/tfc_io.c
>> @@ -206,7 +206,8 @@ int ft_queue_data_in(struct se_cmd *se_cmd)
>>                                                 "xid <0x%x>, remaining <0x%x>, "
>>                                                 "lso_max <0x%x>\n",
>>                                                 __func__, fp, ep->xid,
>> -                                               remaining, lport->lso_max);
>> +                                               (unsigned int)remaining,
>> +                                               lport->lso_max);
>
> Given that "remaining" really is a length, surely it makes more sense to

Exactly my comments ...

> print it with %zd than to cast it and print it with %x ...

... except that size_t is unsigned, so %zu would be a little bit better.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: linux-next: build warning after merge of the scsi tree
  2011-05-19  2:54     ` Nicholas A. Bellinger
@ 2011-05-19 16:18       ` Kiran Patil
  0 siblings, 0 replies; 46+ messages in thread
From: Kiran Patil @ 2011-05-19 16:18 UTC (permalink / raw)
  To: Nicholas A. Bellinger
  Cc: Stephen Rothwell, James Bottomley, linux-next, linux-kernel,
	Christoph Hellwig, Yi Zou, Joe Eykholt

Hi All,

Sorry, I should have fixed that issue. Anyways, I will fix it and send 
patch out.


On 5/18/2011 7:54 PM, Nicholas A. Bellinger wrote:
> On Wed, 2011-05-18 at 13:58 +1000, Stephen Rothwell wrote:
>> Hi Nicholas,
>>
>> On Tue, 17 May 2011 19:06:02 -0700 "Nicholas A. Bellinger"<nab@linux-iscsi.org>  wrote:
>>> On Wed, 2011-05-18 at 11:49 +1000, Stephen Rothwell wrote:
>>>> After merging the scsi tree, today's linux-next build (x86_64 allmodconfig)
>>>> produced this warning:
>>>>
>>>> drivers/target/tcm_fc/tfc_io.c: In function 'ft_queue_data_in':
>>>> drivers/target/tcm_fc/tfc_io.c:209: warning: format '%x' expects type 'unsigned int', but argument 5 has type 'size_t'
>>>>
>>>> Introduced by commit 3699d92a4d7b ("[SCSI] tcm_fc: Adding FC_FC4 provider
>>>> (tcm_fc) for FCoE target (TCM - target core) support").
>>>>
>>> It appears that this warning was fixed in LIO upstream a while back, but
>>> did not make it into this morning scsi-misc merge.  Please apply.
>>>
>>> > From b830de5068d0c3745e83393f81d87f745ef7a4f2 Mon Sep 17 00:00:00 2001
>>> From: Nicholas Bellinger<nab@linux-iscsi.org>
>>> Date: Thu, 17 Feb 2011 21:56:16 +0000
>>> Subject: [PATCH] tcm_fc: Fix conversion spec compile warning in ft_queue_data_in
>>> MIME-Version: 1.0
>>> Content-Type: text/plain; charset=UTF-8
>>> Content-Transfer-Encoding: 8bit
>>>
>>> This patch fixes the following compile warning in ft_queue_data_in():
>>>
>>> drivers/target/tcm_fc/tfc_io.c: In function ‘ft_queue_data_in’:
>>> drivers/target/tcm_fc/tfc_io.c:209: warning: format ‘%x’ expects type ‘unsigned int’, but argument 5 has type ‘size_t’
>>>
>>> Signed-off-by: Nicholas A. Bellinger<nab@linux-iscsi.org>
>>> ---
>>>   drivers/target/tcm_fc/tfc_io.c |    3 ++-
>>>   1 files changed, 2 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/target/tcm_fc/tfc_io.c b/drivers/target/tcm_fc/tfc_io.c
>>> index 4c3c0ef..3936bb1 100644
>>> --- a/drivers/target/tcm_fc/tfc_io.c
>>> +++ b/drivers/target/tcm_fc/tfc_io.c
>>> @@ -206,7 +206,8 @@ int ft_queue_data_in(struct se_cmd *se_cmd)
>>>                                                  "xid<0x%x>, remaining<0x%x>, "
>>>                                                  "lso_max<0x%x>\n",
>>>                                                  __func__, fp, ep->xid,
>>> -                                               remaining, lport->lso_max);
>>> +                                               (unsigned int)remaining,
>>> +                                               lport->lso_max);
>> Given that "remaining" really is a length, surely it makes more sense to
>> print it with %zd than to cast it and print it with %x ...
>>
> This is fine with me.  Bad habit of explictly casting conversion
> specifications from sector_t type usage..
>
> Kiran, would you mind fixing this to use %zd in your tree, and include
> this along with the TMR LUN_RESET bugfix for James to include in
> scsi-misc..?
>
> Thanks,
>
> --nab
>
No problem. I will fix it and get it out along with my other patch 
series for offload, big fixes, etc.. via. Open-FCoE which has been 
rebased to scsi-misc yesterday (scsi-misc now has tcm_fc)

Thanks,
-- Kiran P.

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: linux-next: build warning after merge of the scsi tree
  2011-05-18  3:58   ` Stephen Rothwell
@ 2011-05-19  2:54     ` Nicholas A. Bellinger
  2011-05-19 16:18       ` Kiran Patil
  2011-05-19 16:22     ` Geert Uytterhoeven
  1 sibling, 1 reply; 46+ messages in thread
From: Nicholas A. Bellinger @ 2011-05-19  2:54 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: James Bottomley, linux-next, linux-kernel, Kiran Patil,
	Christoph Hellwig, Yi Zou, Joe Eykholt

On Wed, 2011-05-18 at 13:58 +1000, Stephen Rothwell wrote:
> Hi Nicholas,
> 
> On Tue, 17 May 2011 19:06:02 -0700 "Nicholas A. Bellinger" <nab@linux-iscsi.org> wrote:
> >
> > On Wed, 2011-05-18 at 11:49 +1000, Stephen Rothwell wrote:
> > > 
> > > After merging the scsi tree, today's linux-next build (x86_64 allmodconfig)
> > > produced this warning:
> > > 
> > > drivers/target/tcm_fc/tfc_io.c: In function 'ft_queue_data_in':
> > > drivers/target/tcm_fc/tfc_io.c:209: warning: format '%x' expects type 'unsigned int', but argument 5 has type 'size_t'
> > > 
> > > Introduced by commit 3699d92a4d7b ("[SCSI] tcm_fc: Adding FC_FC4 provider
> > > (tcm_fc) for FCoE target (TCM - target core) support").
> > > 
> > 
> > It appears that this warning was fixed in LIO upstream a while back, but
> > did not make it into this morning scsi-misc merge.  Please apply.
> > 
> > >From b830de5068d0c3745e83393f81d87f745ef7a4f2 Mon Sep 17 00:00:00 2001
> > From: Nicholas Bellinger <nab@linux-iscsi.org>
> > Date: Thu, 17 Feb 2011 21:56:16 +0000
> > Subject: [PATCH] tcm_fc: Fix conversion spec compile warning in ft_queue_data_in
> > MIME-Version: 1.0
> > Content-Type: text/plain; charset=UTF-8
> > Content-Transfer-Encoding: 8bit
> > 
> > This patch fixes the following compile warning in ft_queue_data_in():
> > 
> > drivers/target/tcm_fc/tfc_io.c: In function ‘ft_queue_data_in’:
> > drivers/target/tcm_fc/tfc_io.c:209: warning: format ‘%x’ expects type ‘unsigned int’, but argument 5 has type ‘size_t’
> > 
> > Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
> > ---
> >  drivers/target/tcm_fc/tfc_io.c |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/target/tcm_fc/tfc_io.c b/drivers/target/tcm_fc/tfc_io.c
> > index 4c3c0ef..3936bb1 100644
> > --- a/drivers/target/tcm_fc/tfc_io.c
> > +++ b/drivers/target/tcm_fc/tfc_io.c
> > @@ -206,7 +206,8 @@ int ft_queue_data_in(struct se_cmd *se_cmd)
> >                                                 "xid <0x%x>, remaining <0x%x>, "
> >                                                 "lso_max <0x%x>\n",
> >                                                 __func__, fp, ep->xid,
> > -                                               remaining, lport->lso_max);
> > +                                               (unsigned int)remaining,
> > +                                               lport->lso_max);
> 
> Given that "remaining" really is a length, surely it makes more sense to
> print it with %zd than to cast it and print it with %x ...
> 

This is fine with me.  Bad habit of explictly casting conversion
specifications from sector_t type usage..

Kiran, would you mind fixing this to use %zd in your tree, and include
this along with the TMR LUN_RESET bugfix for James to include in
scsi-misc..?

Thanks,

--nab

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: linux-next: build warning after merge of the scsi tree
  2011-05-18  2:06 ` Nicholas A. Bellinger
@ 2011-05-18  3:58   ` Stephen Rothwell
  2011-05-19  2:54     ` Nicholas A. Bellinger
  2011-05-19 16:22     ` Geert Uytterhoeven
  0 siblings, 2 replies; 46+ messages in thread
From: Stephen Rothwell @ 2011-05-18  3:58 UTC (permalink / raw)
  To: Nicholas A. Bellinger
  Cc: James Bottomley, linux-next, linux-kernel, Kiran Patil,
	Joe Eykholt, Christoph Hellwig, Yi Zou

[-- Attachment #1: Type: text/plain, Size: 2557 bytes --]

Hi Nicholas,

On Tue, 17 May 2011 19:06:02 -0700 "Nicholas A. Bellinger" <nab@linux-iscsi.org> wrote:
>
> On Wed, 2011-05-18 at 11:49 +1000, Stephen Rothwell wrote:
> > 
> > After merging the scsi tree, today's linux-next build (x86_64 allmodconfig)
> > produced this warning:
> > 
> > drivers/target/tcm_fc/tfc_io.c: In function 'ft_queue_data_in':
> > drivers/target/tcm_fc/tfc_io.c:209: warning: format '%x' expects type 'unsigned int', but argument 5 has type 'size_t'
> > 
> > Introduced by commit 3699d92a4d7b ("[SCSI] tcm_fc: Adding FC_FC4 provider
> > (tcm_fc) for FCoE target (TCM - target core) support").
> > 
> 
> It appears that this warning was fixed in LIO upstream a while back, but
> did not make it into this morning scsi-misc merge.  Please apply.
> 
> >From b830de5068d0c3745e83393f81d87f745ef7a4f2 Mon Sep 17 00:00:00 2001
> From: Nicholas Bellinger <nab@linux-iscsi.org>
> Date: Thu, 17 Feb 2011 21:56:16 +0000
> Subject: [PATCH] tcm_fc: Fix conversion spec compile warning in ft_queue_data_in
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> This patch fixes the following compile warning in ft_queue_data_in():
> 
> drivers/target/tcm_fc/tfc_io.c: In function ‘ft_queue_data_in’:
> drivers/target/tcm_fc/tfc_io.c:209: warning: format ‘%x’ expects type ‘unsigned int’, but argument 5 has type ‘size_t’
> 
> Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
> ---
>  drivers/target/tcm_fc/tfc_io.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/target/tcm_fc/tfc_io.c b/drivers/target/tcm_fc/tfc_io.c
> index 4c3c0ef..3936bb1 100644
> --- a/drivers/target/tcm_fc/tfc_io.c
> +++ b/drivers/target/tcm_fc/tfc_io.c
> @@ -206,7 +206,8 @@ int ft_queue_data_in(struct se_cmd *se_cmd)
>                                                 "xid <0x%x>, remaining <0x%x>, "
>                                                 "lso_max <0x%x>\n",
>                                                 __func__, fp, ep->xid,
> -                                               remaining, lport->lso_max);
> +                                               (unsigned int)remaining,
> +                                               lport->lso_max);

Given that "remaining" really is a length, surely it makes more sense to
print it with %zd than to cast it and print it with %x ...

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: linux-next: build warning after merge of the scsi tree
       [not found] <20110518114912.dfdf8835.sfr@canb.auug.org.au>
@ 2011-05-18  2:06 ` Nicholas A. Bellinger
  2011-05-18  3:58   ` Stephen Rothwell
  0 siblings, 1 reply; 46+ messages in thread
From: Nicholas A. Bellinger @ 2011-05-18  2:06 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: James Bottomley, linux-next, linux-kernel, Kiran Patil,
	Joe Eykholt, Christoph Hellwig, Yi Zou

On Wed, 2011-05-18 at 11:49 +1000, Stephen Rothwell wrote:
> Hi James,
> 
> After merging the scsi tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> drivers/target/tcm_fc/tfc_io.c: In function 'ft_queue_data_in':
> drivers/target/tcm_fc/tfc_io.c:209: warning: format '%x' expects type 'unsigned int', but argument 5 has type 'size_t'
> 
> Introduced by commit 3699d92a4d7b ("[SCSI] tcm_fc: Adding FC_FC4 provider
> (tcm_fc) for FCoE target (TCM - target core) support").
> 

Hi Stephen,

It appears that this warning was fixed in LIO upstream a while back, but
did not make it into this morning scsi-misc merge.  Please apply.

Thanks!

--nab


>From b830de5068d0c3745e83393f81d87f745ef7a4f2 Mon Sep 17 00:00:00 2001
From: Nicholas Bellinger <nab@linux-iscsi.org>
Date: Thu, 17 Feb 2011 21:56:16 +0000
Subject: [PATCH] tcm_fc: Fix conversion spec compile warning in ft_queue_data_in
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This patch fixes the following compile warning in ft_queue_data_in():

drivers/target/tcm_fc/tfc_io.c: In function ‘ft_queue_data_in’:
drivers/target/tcm_fc/tfc_io.c:209: warning: format ‘%x’ expects type ‘unsigned int’, but argument 5 has type ‘size_t’

Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
---
 drivers/target/tcm_fc/tfc_io.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/target/tcm_fc/tfc_io.c b/drivers/target/tcm_fc/tfc_io.c
index 4c3c0ef..3936bb1 100644
--- a/drivers/target/tcm_fc/tfc_io.c
+++ b/drivers/target/tcm_fc/tfc_io.c
@@ -206,7 +206,8 @@ int ft_queue_data_in(struct se_cmd *se_cmd)
                                                "xid <0x%x>, remaining <0x%x>, "
                                                "lso_max <0x%x>\n",
                                                __func__, fp, ep->xid,
-                                               remaining, lport->lso_max);
+                                               (unsigned int)remaining,
+                                               lport->lso_max);
                }
        }
        return ft_queue_status(se_cmd);
-- 
1.7.5.1

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: linux-next: build warning after merge of the scsi tree
  2010-08-04  3:13 Stephen Rothwell
@ 2010-08-04  4:17 ` James Bottomley
  0 siblings, 0 replies; 46+ messages in thread
From: James Bottomley @ 2010-08-04  4:17 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Alan Stern, linux-scsi

cc linux-scsi added

On Wed, 2010-08-04 at 13:13 +1000, Stephen Rothwell wrote:
> Hi James,
> 
> After merging the scsi tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> drivers/scsi/scsi_sysfs.c:384: warning: dereferencing 'void *' pointer
> 
> Introduced by commit db5bd1e0b505c54ff492172ce4abc245cf6cd639 ("[SCSI]
> convert to the new PM framework").  This build does not have
> CONFIG_PM_OPS set.

So this one looks to be a compiler error.  in the none CONFIG_PM_OPS
case, we have

scsi_priv.h:#define scsi_bus_pm_ops             (*NULL)

So &scsi_bus_pm_ops should be NULL (not a deref of null).

James

^ permalink raw reply	[flat|nested] 46+ messages in thread

* linux-next: build warning after merge of the scsi tree
@ 2010-08-04  3:13 Stephen Rothwell
  2010-08-04  4:17 ` James Bottomley
  0 siblings, 1 reply; 46+ messages in thread
From: Stephen Rothwell @ 2010-08-04  3:13 UTC (permalink / raw)
  To: James Bottomley; +Cc: linux-next, linux-kernel, Alan Stern

[-- Attachment #1: Type: text/plain, Size: 457 bytes --]

Hi James,

After merging the scsi tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/scsi/scsi_sysfs.c:384: warning: dereferencing 'void *' pointer

Introduced by commit db5bd1e0b505c54ff492172ce4abc245cf6cd639 ("[SCSI]
convert to the new PM framework").  This build does not have
CONFIG_PM_OPS set.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: linux-next: build warning after merge of the scsi tree
  2010-02-10  5:51 Stephen Rothwell
@ 2010-02-10 22:13 ` James Bottomley
  0 siblings, 0 replies; 46+ messages in thread
From: James Bottomley @ 2010-02-10 22:13 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: linux-next, linux-kernel, Giridhar Malavali, Sarang Radke

On Wed, 2010-02-10 at 16:51 +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the percpu tree, today's linux-next build (powerpc
> ppc64_defconfig) produced these warnings:
> 
> drivers/scsi/qla2xxx/qla_attr.c: In function 'qla2x00_process_vendor_specific':
> drivers/scsi/qla2xxx/qla_attr.c:2150: warning: 'req_data' may be used uninitialized in this function
> drivers/scsi/qla2xxx/qla_attr.c:2152: warning: 'req_data_len' may be used uninitialized in this function
> 
> If the first "goto done_unmap_sg;" in this function is followed, the
> req_data will be tested even though it has not been assigned to yet and
> if it is non zero, it and req_data_len will be passed to
> dma_free_coherent() while still uninitialised.
> 
> Introduced by commit 9a069e196767d7b87184fd8d8211d22bb5b9c0b8 ("[SCSI]
> qla2xxx: Add BSG support for FC ELS/CT passthrough and vendor commands").
> 
> The compiler also produces these:
> 
> drivers/scsi/qla2xxx/qla_attr.c:2144: warning: 'command_sent' may be used uninitialized in this function
> drivers/scsi/qla2xxx/qla_attr.c:2146: warning: 'type' may be used uninitialized in this function
> 
> but I can't easily tell if they are false positives.

They seem to be false positives.  The unconditional initialisation is on
line 2191, and there's no use before then that I can find ... I also
don't see this error on my builds, so it looks like a toolchain issue.

James

^ permalink raw reply	[flat|nested] 46+ messages in thread

* linux-next: build warning after merge of the scsi tree
@ 2010-02-10  5:51 Stephen Rothwell
  2010-02-10 22:13 ` James Bottomley
  0 siblings, 1 reply; 46+ messages in thread
From: Stephen Rothwell @ 2010-02-10  5:51 UTC (permalink / raw)
  To: James Bottomley; +Cc: linux-next, linux-kernel, Giridhar Malavali, Sarang Radke

[-- Attachment #1: Type: text/plain, Size: 1217 bytes --]

Hi all,

After merging the percpu tree, today's linux-next build (powerpc
ppc64_defconfig) produced these warnings:

drivers/scsi/qla2xxx/qla_attr.c: In function 'qla2x00_process_vendor_specific':
drivers/scsi/qla2xxx/qla_attr.c:2150: warning: 'req_data' may be used uninitialized in this function
drivers/scsi/qla2xxx/qla_attr.c:2152: warning: 'req_data_len' may be used uninitialized in this function

If the first "goto done_unmap_sg;" in this function is followed, the
req_data will be tested even though it has not been assigned to yet and
if it is non zero, it and req_data_len will be passed to
dma_free_coherent() while still uninitialised.

Introduced by commit 9a069e196767d7b87184fd8d8211d22bb5b9c0b8 ("[SCSI]
qla2xxx: Add BSG support for FC ELS/CT passthrough and vendor commands").

The compiler also produces these:

drivers/scsi/qla2xxx/qla_attr.c:2144: warning: 'command_sent' may be used uninitialized in this function
drivers/scsi/qla2xxx/qla_attr.c:2146: warning: 'type' may be used uninitialized in this function

but I can't easily tell if they are false positives.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 46+ messages in thread

end of thread, back to index

Thread overview: 46+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20180620132911.5f6ab464@canb.auug.org.au>
2018-07-10  7:31 ` linux-next: build warning after merge of the scsi tree Stephen Rothwell
2018-07-10 14:09   ` Jens Axboe
2018-07-10 14:14     ` James Bottomley
2018-07-10 14:22       ` Jens Axboe
2018-07-10 14:26         ` James Bottomley
2018-07-10 14:35           ` Jens Axboe
2018-07-10 15:08             ` Martin K. Petersen
2019-11-07  4:01 Stephen Rothwell
2019-11-07 15:51 ` Bart Van Assche
2019-11-08 23:02   ` James Smart
  -- strict thread matches above, loose matches on Subject: below --
2019-06-20  6:10 Stephen Rothwell
2019-05-31  3:36 Stephen Rothwell
2019-06-03 20:29 ` Tyrel Datwyler
2019-06-03 23:37 ` Tyrel Datwyler
2019-04-05  3:25 Stephen Rothwell
2019-04-05  4:30 ` Bart Van Assche
2019-04-05  4:52   ` James Bottomley
2018-10-19  4:50 Stephen Rothwell
2018-10-19  4:54 ` James Bottomley
2018-10-19  4:58   ` Stephen Rothwell
2018-04-17  2:25 Stephen Rothwell
2018-04-18 21:52 ` Long Li
2018-04-18 23:30   ` Martin K. Petersen
2017-04-06  4:04 Stephen Rothwell
2017-04-06  8:18 ` Fam Zheng
2016-11-22  7:44 Stephen Rothwell
2016-11-22 22:24 ` Martin K. Petersen
2016-09-13  4:15 Stephen Rothwell
2016-09-13 14:09 ` Bryant G. Ly
2016-09-15 13:55   ` Martin K. Petersen
2014-11-18  8:21 Stephen Rothwell
2014-11-20  8:23 ` Christoph Hellwig
2013-09-02  8:28 Stephen Rothwell
2013-09-04  9:18 ` Sujit Reddy Thumma
2013-09-04  9:54   ` Sujit Reddy Thumma
2011-07-20  4:08 Stephen Rothwell
     [not found] <20110518114912.dfdf8835.sfr@canb.auug.org.au>
2011-05-18  2:06 ` Nicholas A. Bellinger
2011-05-18  3:58   ` Stephen Rothwell
2011-05-19  2:54     ` Nicholas A. Bellinger
2011-05-19 16:18       ` Kiran Patil
2011-05-19 16:22     ` Geert Uytterhoeven
2011-06-23 17:02       ` Randy Dunlap
2010-08-04  3:13 Stephen Rothwell
2010-08-04  4:17 ` James Bottomley
2010-02-10  5:51 Stephen Rothwell
2010-02-10 22:13 ` James Bottomley

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git